fix clippy

Author: fee1-dead

src/tools/clippy/clippy_dev/src/lib.rs

@@ -12,7 +12,7 @@ extern crate rustc_lexer;
 
 use std::path::PathBuf;
 
-pub mod bless
+pub mod bless;
 pub mod dogfood;
 pub mod fmt;
 pub mod lint;

src/tools/clippy/tests/ui/deprecated.rs

@@ -18,6 +18,5 @@
 #![warn(clippy::filter_map)]
 #![warn(clippy::pub_enum_variant_names)]
 #![warn(clippy::wrong_pub_self_convention)]
-#![warn(clippy::clone_double_ref)]
 
 fn main() {}

src/tools/clippy/tests/ui/deprecated.stderr

@@ -96,11 +96,5 @@ error: lint `clippy::wrong_pub_self_convention` has been removed: set the `avoid
 LL | #![warn(clippy::wrong_pub_self_convention)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: lint `clippy::clone_double_ref` has been renamed to `clone_double_ref`
-  --> $DIR/deprecated.rs:21:9
-   |
-LL | #![warn(clippy::clone_double_ref)]
-   |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clone_double_ref`
-
-error: aborting due to 17 previous errors
+error: aborting due to 16 previous errors
 

src/tools/clippy/tests/ui/unnecessary_clone.rs

@@ -42,14 +42,6 @@ fn clone_on_copy_generic<T: Copy>(t: T) {
     Some(t).clone();
 }
 
-fn clone_on_double_ref() {
-    let x = vec![1];
-    let y = &&x;
-    let z: &Vec<_> = y.clone();
-
-    println!("{:p} {:p}", *y, z);
-}
-
 mod many_derefs {
     struct A;
     struct B;
@@ -84,11 +76,6 @@ mod many_derefs {
         let _: E = a.clone();
         let _: E = *****a;
     }
-
-    fn check(mut encoded: &[u8]) {
-        let _ = &mut encoded.clone();
-        let _ = &encoded.clone();
-    }
 }
 
 mod issue2076 {

src/tools/clippy/tests/ui/unnecessary_clone.stderr

@@ -45,62 +45,16 @@ LL |     Some(t).clone();
    |     ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `Some(t)`
 
 error: using `clone` on type `E` which implements the `Copy` trait
-  --> $DIR/unnecessary_clone.rs:84:20
+  --> $DIR/unnecessary_clone.rs:76:20
    |
 LL |         let _: E = a.clone();
    |                    ^^^^^^^^^ help: try dereferencing it: `*****a`
 
 error: using `.clone()` on a ref-counted pointer
-  --> $DIR/unnecessary_clone.rs:108:14
+  --> $DIR/unnecessary_clone.rs:95:14
    |
 LL |         Some(try_opt!(Some(rc)).clone())
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `Rc::<u8>::clone(&try_opt!(Some(rc)))`
 
-error: using `clone` on a double-reference, which copies the reference of type `std::vec::Vec<i32>` instead of cloning the inner type
-  --> $DIR/unnecessary_clone.rs:48:22
-   |
-LL |     let z: &Vec<_> = y.clone();
-   |                      ^^^^^^^^^
-   |
-   = note: `-D clone-double-ref` implied by `-D warnings`
-help: try dereferencing it
-   |
-LL |     let z: &Vec<_> = &(*y).clone();
-   |                      +++ ~~~~~~~~~
-help: or try being explicit if you are sure, that you want to clone a reference
-   |
-LL |     let z: &Vec<_> = <&std::vec::Vec<i32>>::clone(y);
-   |                      +++++++++++++++++++++++++++++ ~
-
-error: using `clone` on a double-reference, which copies the reference of type `[u8]` instead of cloning the inner type
-  --> $DIR/unnecessary_clone.rs:89:22
-   |
-LL |         let _ = &mut encoded.clone();
-   |                      ^^^^^^^^^^^^^^^
-   |
-help: try dereferencing it
-   |
-LL |         let _ = &mut &(*encoded).clone();
-   |                      +++       ~~~~~~~~~
-help: or try being explicit if you are sure, that you want to clone a reference
-   |
-LL |         let _ = &mut <&[u8]>::clone(encoded);
-   |                      +++++++++++++++       ~
-
-error: using `clone` on a double-reference, which copies the reference of type `[u8]` instead of cloning the inner type
-  --> $DIR/unnecessary_clone.rs:90:18
-   |
-LL |         let _ = &encoded.clone();
-   |                  ^^^^^^^^^^^^^^^
-   |
-help: try dereferencing it
-   |
-LL |         let _ = &&(*encoded).clone();
-   |                  +++       ~~~~~~~~~
-help: or try being explicit if you are sure, that you want to clone a reference
-   |
-LL |         let _ = &<&[u8]>::clone(encoded);
-   |                  +++++++++++++++       ~
-
-error: aborting due to 12 previous errors
+error: aborting due to 9 previous errors
 

tests/ui/lint/clone-double-ref.rs

@@ -20,4 +20,9 @@ fn rust_clippy_issue_9272() {
     println!("{str}")
 }
 
+fn check(mut encoded: &[u8]) {
+    let _ = &mut encoded.clone();
+    let _ = &encoded.clone();
+}
+
 fn main() {}