Skip to content

Commit 85c0479

Browse files
jyn514jyn514
committed
Remove unnecessary Clean impl
1 parent cc0d140 commit 85c0479

File tree

3 files changed

+18
-24
lines changed

3 files changed

+18
-24
lines changed

‎src/librustdoc/clean/inline.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ pub fn try_inline(
130130
attrs,
131131
inner,
132132
visibility: clean::Public,
133-
stability: cx.tcx.lookup_stability(did).clean(cx),
133+
stability: cx.tcx.lookup_stability(did).cloned(),
134134
deprecation: cx.tcx.lookup_deprecation(did).clean(cx),
135135
def_id: did,
136136
});
@@ -461,7 +461,7 @@ pub fn build_impl(
461461
name: None,
462462
attrs,
463463
visibility: clean::Inherited,
464-
stability: tcx.lookup_stability(did).clean(cx),
464+
stability: tcx.lookup_stability(did).cloned(),
465465
deprecation: tcx.lookup_deprecation(did).clean(cx),
466466
def_id: did,
467467
});

‎src/librustdoc/clean/mod.rs‎

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -913,7 +913,7 @@ impl Clean<Item> for doctree::Function<'_> {
913913
attrs: self.attrs.clean(cx),
914914
source: self.span.clean(cx),
915915
visibility: self.vis.clean(cx),
916-
stability: cx.stability(self.id).clean(cx),
916+
stability: cx.stability(self.id),
917917
deprecation: cx.deprecation(self.id).clean(cx),
918918
def_id: did.to_def_id(),
919919
inner: FunctionItem(Function {
@@ -1022,7 +1022,7 @@ impl Clean<Item> for doctree::Trait<'_> {
10221022
source: self.span.clean(cx),
10231023
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
10241024
visibility: self.vis.clean(cx),
1025-
stability: cx.stability(self.id).clean(cx),
1025+
stability: cx.stability(self.id),
10261026
deprecation: cx.deprecation(self.id).clean(cx),
10271027
inner: TraitItem(Trait {
10281028
auto: self.is_auto.clean(cx),
@@ -1046,7 +1046,7 @@ impl Clean<Item> for doctree::TraitAlias<'_> {
10461046
source: self.span.clean(cx),
10471047
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
10481048
visibility: self.vis.clean(cx),
1049-
stability: cx.stability(self.id).clean(cx),
1049+
stability: cx.stability(self.id),
10501050
deprecation: cx.deprecation(self.id).clean(cx),
10511051
inner: TraitAliasItem(TraitAlias {
10521052
generics: self.generics.clean(cx),
@@ -1831,7 +1831,7 @@ impl Clean<Item> for doctree::Struct<'_> {
18311831
source: self.span.clean(cx),
18321832
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
18331833
visibility: self.vis.clean(cx),
1834-
stability: cx.stability(self.id).clean(cx),
1834+
stability: cx.stability(self.id),
18351835
deprecation: cx.deprecation(self.id).clean(cx),
18361836
inner: StructItem(Struct {
18371837
struct_type: self.struct_type,
@@ -1851,7 +1851,7 @@ impl Clean<Item> for doctree::Union<'_> {
18511851
source: self.span.clean(cx),
18521852
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
18531853
visibility: self.vis.clean(cx),
1854-
stability: cx.stability(self.id).clean(cx),
1854+
stability: cx.stability(self.id),
18551855
deprecation: cx.deprecation(self.id).clean(cx),
18561856
inner: UnionItem(Union {
18571857
struct_type: self.struct_type,
@@ -1881,7 +1881,7 @@ impl Clean<Item> for doctree::Enum<'_> {
18811881
source: self.span.clean(cx),
18821882
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
18831883
visibility: self.vis.clean(cx),
1884-
stability: cx.stability(self.id).clean(cx),
1884+
stability: cx.stability(self.id),
18851885
deprecation: cx.deprecation(self.id).clean(cx),
18861886
inner: EnumItem(Enum {
18871887
variants: self.variants.iter().map(|v| v.clean(cx)).collect(),
@@ -1899,7 +1899,7 @@ impl Clean<Item> for doctree::Variant<'_> {
18991899
attrs: self.attrs.clean(cx),
19001900
source: self.span.clean(cx),
19011901
visibility: Inherited,
1902-
stability: cx.stability(self.id).clean(cx),
1902+
stability: cx.stability(self.id),
19031903
deprecation: cx.deprecation(self.id).clean(cx),
19041904
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
19051905
inner: VariantItem(Variant { kind: self.def.clean(cx) }),
@@ -2048,7 +2048,7 @@ impl Clean<Item> for doctree::Typedef<'_> {
20482048
source: self.span.clean(cx),
20492049
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
20502050
visibility: self.vis.clean(cx),
2051-
stability: cx.stability(self.id).clean(cx),
2051+
stability: cx.stability(self.id),
20522052
deprecation: cx.deprecation(self.id).clean(cx),
20532053
inner: TypedefItem(Typedef { type_, generics: self.gen.clean(cx), item_type }, false),
20542054
}
@@ -2063,7 +2063,7 @@ impl Clean<Item> for doctree::OpaqueTy<'_> {
20632063
source: self.span.clean(cx),
20642064
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
20652065
visibility: self.vis.clean(cx),
2066-
stability: cx.stability(self.id).clean(cx),
2066+
stability: cx.stability(self.id),
20672067
deprecation: cx.deprecation(self.id).clean(cx),
20682068
inner: OpaqueTyItem(OpaqueTy {
20692069
bounds: self.opaque_ty.bounds.clean(cx),
@@ -2091,7 +2091,7 @@ impl Clean<Item> for doctree::Static<'_> {
20912091
source: self.span.clean(cx),
20922092
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
20932093
visibility: self.vis.clean(cx),
2094-
stability: cx.stability(self.id).clean(cx),
2094+
stability: cx.stability(self.id),
20952095
deprecation: cx.deprecation(self.id).clean(cx),
20962096
inner: StaticItem(Static {
20972097
type_: self.type_.clean(cx),
@@ -2112,7 +2112,7 @@ impl Clean<Item> for doctree::Constant<'_> {
21122112
source: self.span.clean(cx),
21132113
def_id: def_id.to_def_id(),
21142114
visibility: self.vis.clean(cx),
2115-
stability: cx.stability(self.id).clean(cx),
2115+
stability: cx.stability(self.id),
21162116
deprecation: cx.deprecation(self.id).clean(cx),
21172117
inner: ConstantItem(Constant {
21182118
type_: self.type_.clean(cx),
@@ -2166,7 +2166,7 @@ impl Clean<Vec<Item>> for doctree::Impl<'_> {
21662166
source: self.span.clean(cx),
21672167
def_id: def_id.to_def_id(),
21682168
visibility: self.vis.clean(cx),
2169-
stability: cx.stability(self.id).clean(cx),
2169+
stability: cx.stability(self.id),
21702170
deprecation: cx.deprecation(self.id).clean(cx),
21712171
inner: ImplItem(Impl {
21722172
unsafety: self.unsafety,
@@ -2348,7 +2348,7 @@ impl Clean<Item> for doctree::ForeignItem<'_> {
23482348
source: self.span.clean(cx),
23492349
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
23502350
visibility: self.vis.clean(cx),
2351-
stability: cx.stability(self.id).clean(cx),
2351+
stability: cx.stability(self.id),
23522352
deprecation: cx.deprecation(self.id).clean(cx),
23532353
inner,
23542354
}
@@ -2363,7 +2363,7 @@ impl Clean<Item> for doctree::Macro<'_> {
23632363
attrs: self.attrs.clean(cx),
23642364
source: self.span.clean(cx),
23652365
visibility: Public,
2366-
stability: cx.stability(self.hid).clean(cx),
2366+
stability: cx.stability(self.hid),
23672367
deprecation: cx.deprecation(self.hid).clean(cx),
23682368
def_id: self.def_id,
23692369
inner: MacroItem(Macro {
@@ -2388,20 +2388,14 @@ impl Clean<Item> for doctree::ProcMacro<'_> {
23882388
attrs: self.attrs.clean(cx),
23892389
source: self.span.clean(cx),
23902390
visibility: Public,
2391-
stability: cx.stability(self.id).clean(cx),
2391+
stability: cx.stability(self.id),
23922392
deprecation: cx.deprecation(self.id).clean(cx),
23932393
def_id: cx.tcx.hir().local_def_id(self.id).to_def_id(),
23942394
inner: ProcMacroItem(ProcMacro { kind: self.kind, helpers: self.helpers.clean(cx) }),
23952395
}
23962396
}
23972397
}
23982398

2399-
impl Clean<attr::Stability> for attr::Stability {
2400-
fn clean(&self, _: &DocContext<'_>) -> attr::Stability {
2401-
self.clone()
2402-
}
2403-
}
2404-
24052399
impl Clean<Deprecation> for attr::Deprecation {
24062400
fn clean(&self, _: &DocContext<'_>) -> Deprecation {
24072401
Deprecation {

‎src/librustdoc/clean/utils.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ pub fn krate(mut cx: &mut DocContext<'_>) -> Crate {
103103

104104
// extract the stability index for a node from tcx, if possible
105105
pub fn get_stability(cx: &DocContext<'_>, def_id: DefId) -> Option<Stability> {
106-
cx.tcx.lookup_stability(def_id).clean(cx)
106+
cx.tcx.lookup_stability(def_id).cloned()
107107
}
108108

109109
pub fn get_deprecation(cx: &DocContext<'_>, def_id: DefId) -> Option<Deprecation> {

0 commit comments

Comments
 (0)