instantly_dangling_pointer: remove tracing & bless tests

Author: GrigorenkoPV

compiler/rustc_lint/src/dangling.rs

@@ -49,23 +49,19 @@ impl<'tcx> LateLintPass<'tcx> for InstantlyDanglingPtr {
             return;
         };
         let Ident { name: method_name, span: method_span } = method.ident;
-        tracing::debug!(?method);
 
         // The method is `.as_ptr()` or `.as_mut_ptr`.
         if method_name != sym::as_ptr && method_name != sym::as_mut_ptr {
             return;
         }
 
         // It is called on a temporary rvalue.
-        let is_temp = is_temporary_rvalue(receiver);
-        tracing::debug!(receiver = ?receiver.kind, ?is_temp);
-        if !is_temp {
+        if !is_temporary_rvalue(receiver) {
             return;
         }
 
         // The temporary value's type is array, box, Vec, String, or CString
         let ty = cx.typeck_results().expr_ty(receiver);
-        tracing::debug!(?ty);
         let Some(is_cstring) = as_container(cx, ty) else {
             return;
         };

tests/ui/consts/zst_no_llvm_alloc.rs

@@ -17,8 +17,11 @@ fn main() {
 
     // The exact addresses returned by these library functions are not necessarily stable guarantees
     // but for now we assert that we're still matching.
-    assert_eq!(<Vec<i32>>::new().as_ptr(), <&[i32]>::default().as_ptr());
-    assert_eq!(<Box<[i32]>>::default().as_ptr(), (&[]).as_ptr());
+    #[expect(instantly_dangling_pointer)]
+    {
+        assert_eq!(<Vec<i32>>::new().as_ptr(), <&[i32]>::default().as_ptr());
+        assert_eq!(<Box<[i32]>>::default().as_ptr(), (&[]).as_ptr());
+    };
 
     // statics must have a unique address (see https://github.com/rust-lang/rust/issues/18297, not
     // clear whether this is a stable guarantee)

tests/ui/lint/lint-temporary-cstring-as-param.rs

@@ -7,5 +7,5 @@ fn some_function(data: *const c_char) {}
 
 fn main() {
     some_function(CString::new("").unwrap().as_ptr());
-    //~^ ERROR getting the inner pointer of a temporary `CString`
+    //~^ ERROR this pointer will immediately dangle
 }

tests/ui/lint/lint-temporary-cstring-as-param.stderr

@@ -1,4 +1,4 @@
-error: getting the inner pointer of a temporary `CString`
+error: this pointer will immediately dangle
   --> $DIR/lint-temporary-cstring-as-param.rs:9:45
    |
 LL |     some_function(CString::new("").unwrap().as_ptr());

tests/ui/lint/lint-temporary-cstring-as-ptr.rs

@@ -6,12 +6,12 @@ use std::ffi::CString;
 macro_rules! mymacro {
     () => {
         let s = CString::new("some text").unwrap().as_ptr();
-        //~^ ERROR getting the inner pointer of a temporary `CString`
+        //~^ ERROR this pointer will immediately dangle
     }
 }
 
 fn main() {
     let s = CString::new("some text").unwrap().as_ptr();
-    //~^ ERROR getting the inner pointer of a temporary `CString`
+    //~^ ERROR this pointer will immediately dangle
     mymacro!();
 }

tests/ui/lint/lint-temporary-cstring-as-ptr.stderr

@@ -1,4 +1,4 @@
-error: getting the inner pointer of a temporary `CString`
+error: this pointer will immediately dangle
   --> $DIR/lint-temporary-cstring-as-ptr.rs:14:48
    |
 LL |     let s = CString::new("some text").unwrap().as_ptr();
@@ -14,7 +14,7 @@ note: the lint level is defined here
 LL | #![deny(temporary_cstring_as_ptr)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: getting the inner pointer of a temporary `CString`
+error: this pointer will immediately dangle
   --> $DIR/lint-temporary-cstring-as-ptr.rs:8:52
    |
 LL |         let s = CString::new("some text").unwrap().as_ptr();