Rename all_traits query.

This commit renames the `all_traits` query to `all_suggestible_traits`
to better highlight that it is intended for diagnostic/error reporting
purposes. This was already the case, as highlighted by a doc comment on
the function as it existed previously.

Author: davidtwco

src/librustc/dep_graph/dep_node.rs

@@ -638,7 +638,7 @@ define_dep_nodes!( <'tcx>
     [input] MaybeUnusedExternCrates,
     [input] NamesImportedByGlobUse(DefId),
     [eval_always] StabilityIndex,
-    [eval_always] AllTraits,
+    [eval_always] AllSuggestibleTraits,
     [input] AllCrateNums,
     [] ExportedSymbols(CrateNum),
     [eval_always] CollectAndPartitionMonoItems,

src/librustc/ty/query/config.rs

@@ -838,7 +838,7 @@ impl<'tcx> QueryDescription<'tcx> for queries::stability_index<'tcx> {
     }
 }
 
-impl<'tcx> QueryDescription<'tcx> for queries::all_traits<'tcx> {
+impl<'tcx> QueryDescription<'tcx> for queries::all_suggestible_traits<'tcx> {
     fn describe(_tcx: TyCtxt<'_, '_, '_>, _: CrateNum) -> Cow<'static, str> {
         "fetching all foreign and local traits".into()
     }

src/librustc/ty/query/mod.rs

@@ -563,7 +563,7 @@ define_queries! { <'tcx>
         /// A vector of every trait accessible in the whole crate
         /// (i.e., including those from subcrates). This is used only for
         /// error reporting.
-        [] fn all_traits: all_traits_node(CrateNum) -> Lrc<Vec<DefId>>,
+        [] fn all_suggestible_traits: all_suggestible_traits_node(CrateNum) -> Lrc<Vec<DefId>>,
     },
 
     Linking {
@@ -899,8 +899,8 @@ fn all_crate_nums_node<'tcx>(_: CrateNum) -> DepConstructor<'tcx> {
     DepConstructor::AllCrateNums
 }
 
-fn all_traits_node<'tcx>(_: CrateNum) -> DepConstructor<'tcx> {
-    DepConstructor::AllTraits
+fn all_suggestible_traits_node<'tcx>(_: CrateNum) -> DepConstructor<'tcx> {
+    DepConstructor::AllSuggestibleTraits
 }
 
 fn collect_and_partition_mono_items_node<'tcx>(_: CrateNum) -> DepConstructor<'tcx> {

src/librustc/ty/query/plumbing.rs

@@ -1416,7 +1416,7 @@ pub fn force_from_dep_node<'a, 'gcx, 'lcx>(tcx: TyCtxt<'a, 'gcx, 'lcx>,
         DepKind::NamesImportedByGlobUse => { force!(names_imported_by_glob_use, def_id!()); }
         DepKind::MaybeUnusedExternCrates => { force!(maybe_unused_extern_crates, LOCAL_CRATE); }
         DepKind::StabilityIndex => { force!(stability_index, LOCAL_CRATE); }
-        DepKind::AllTraits => { force!(all_traits, LOCAL_CRATE); }
+        DepKind::AllSuggestibleTraits => { force!(all_suggestible_traits, LOCAL_CRATE); }
         DepKind::AllCrateNums => { force!(all_crate_nums, LOCAL_CRATE); }
         DepKind::ExportedSymbols => { force!(exported_symbols, krate!()); }
         DepKind::CollectAndPartitionMonoItems => {

src/librustc_typeck/check/method/probe.rs

@@ -853,7 +853,7 @@ impl<'a, 'gcx, 'tcx> ProbeContext<'a, 'gcx, 'tcx> {
     fn assemble_extension_candidates_for_all_traits(&mut self) -> Result<(), MethodError<'tcx>> {
         debug!("assemble_extension_candidates_for_all_traits");
         let mut duplicates = FxHashSet::default();
-        for trait_info in suggest::all_traits(self.tcx) {
+        for trait_info in suggest::all_suggestible_traits(self.tcx) {
             if duplicates.insert(trait_info.def_id) {
                 self.assemble_extension_candidates_for_trait(None, trait_info.def_id)?;
             }

src/librustc_typeck/check/method/suggest.rs

@@ -207,7 +207,7 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
                     // Suggest clamping down the type if the method that is being attempted to
                     // be used exists at all, and the type is an ambiuous numeric type
                     // ({integer}/{float}).
-                    let mut candidates = all_traits(self.tcx)
+                    let mut candidates = all_suggestible_traits(self.tcx)
                         .into_iter()
                         .filter_map(|info|
                             self.associated_item(info.def_id, item_name, Namespace::Value)
@@ -593,7 +593,7 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
         // There are no traits implemented, so lets suggest some traits to
         // implement, by finding ones that have the item name, and are
         // legal to implement.
-        let mut candidates = all_traits(self.tcx)
+        let mut candidates = all_suggestible_traits(self.tcx)
             .into_iter()
             .filter(|info| {
                 // We approximate the coherence rules to only suggest
@@ -716,8 +716,8 @@ impl Ord for TraitInfo {
 }
 
 /// Retrieves all traits in this crate and any dependent crates.
-pub fn all_traits<'a, 'gcx, 'tcx>(tcx: TyCtxt<'a, 'gcx, 'tcx>) -> Vec<TraitInfo> {
-    tcx.all_traits(LOCAL_CRATE).iter().map(|&def_id| TraitInfo { def_id }).collect()
+pub fn all_suggestible_traits<'a, 'gcx, 'tcx>(tcx: TyCtxt<'a, 'gcx, 'tcx>) -> Vec<TraitInfo> {
+    tcx.all_suggestible_traits(LOCAL_CRATE).iter().map(|&def_id| TraitInfo { def_id }).collect()
 }
 
 /// Computes all traits in this crate and any dependent crates.
@@ -807,7 +807,7 @@ fn compute_all_traits<'a, 'gcx, 'tcx>(tcx: TyCtxt<'a, 'gcx, 'tcx>) -> Vec<DefId>
 }
 
 pub fn provide(providers: &mut ty::query::Providers) {
-    providers.all_traits = |tcx, cnum| {
+    providers.all_suggestible_traits = |tcx, cnum| {
         assert_eq!(cnum, LOCAL_CRATE);
         Lrc::new(compute_all_traits(tcx))
     }

src/librustdoc/core.rs

@@ -532,7 +532,7 @@ pub fn run_core(options: RustdocOptions) -> (clean::Crate, RenderInfo, RenderOpt
                 fake_def_ids: Default::default(),
                 all_fake_def_ids: Default::default(),
                 generated_synthetics: Default::default(),
-                all_traits: tcx.all_traits(LOCAL_CRATE).to_vec(),
+                all_traits: tcx.all_suggestible_traits(LOCAL_CRATE).to_vec(),
             };
             debug!("crate: {:?}", tcx.hir().krate());