@@ -628,28 +628,29 @@ impl<'cx, 'tcx> LexicalResolver<'cx, 'tcx> {
628628 match * value {
629629 VarValue :: Value ( _) => { /* Inference successful */ }
630630 VarValue :: ErrorValue => {
631- /* Inference impossible: this value contains
632- inconsistent constraints.
633-
634- I think that in this case we should report an
635- error now -- unlike the case above, we can't
636- wait to see whether the user needs the result
637- of this variable. The reason is that the mere
638- existence of this variable implies that the
639- region graph is inconsistent, whether or not it
640- is used.
641-
642- For example, we may have created a region
643- variable that is the GLB of two other regions
644- which do not have a GLB. Even if that variable
645- is not used, it implies that those two regions
646- *should* have a GLB.
647-
648- At least I think this is true. It may be that
649- the mere existence of a conflict in a region variable
650- that is not used is not a problem, so if this rule
651- starts to create problems we'll have to revisit
652- this portion of the code and think hard about it. =) */
631+ // Inference impossible: this value contains
632+ // inconsistent constraints.
633+ //
634+ // I think that in this case we should report an
635+ // error now -- unlike the case above, we can't
636+ // wait to see whether the user needs the result
637+ // of this variable. The reason is that the mere
638+ // existence of this variable implies that the
639+ // region graph is inconsistent, whether or not it
640+ // is used.
641+ //
642+ // For example, we may have created a region
643+ // variable that is the GLB of two other regions
644+ // which do not have a GLB. Even if that variable
645+ // is not used, it implies that those two regions
646+ // *should* have a GLB.
647+ //
648+ // At least I think this is true. It may be that
649+ // the mere existence of a conflict in a region
650+ // variable that is not used is not a problem, so
651+ // if this rule starts to create problems we'll
652+ // have to revisit this portion of the code and
653+ // think hard about it. =) -- nikomatsakis
653654 self . collect_error_for_expanding_node ( graph, & mut dup_vec, node_vid, errors) ;
654655 }
655656 }
0 commit comments