Use chrono instead of time, and permit backtrace

Author: estebank

Cargo.lock

@@ -611,6 +611,16 @@ dependencies = [
  "tracing-tree",
 ]
 
+[[package]]
+name = "chrono"
+version = "0.2.25"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "9213f7cd7c27e95c2b57c49f0e69b1ea65b27138da84a170133fd21b07659c00"
+dependencies = [
+ "num",
+ "time 0.1.43",
+]
+
 [[package]]
 name = "chrono"
 version = "0.4.19"
@@ -2535,7 +2545,7 @@ checksum = "23f3e133c6d515528745ffd3b9f0c7d975ae039f0b6abb099f2168daa2afb4f9"
 dependencies = [
  "ammonia",
  "anyhow",
- "chrono",
+ "chrono 0.4.19",
  "clap 3.2.20",
  "clap_complete",
  "elasticlunr-rs",
@@ -2703,6 +2713,17 @@ version = "0.3.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "61807f77802ff30975e01f4f071c8ba10c022052f98b3294119f3e615d13e5be"
 
+[[package]]
+name = "num"
+version = "0.1.42"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "4703ad64153382334aa8db57c637364c322d3372e097840c72000dabdcf6156e"
+dependencies = [
+ "num-integer",
+ "num-iter",
+ "num-traits",
+]
+
 [[package]]
 name = "num-integer"
 version = "0.1.43"
@@ -2713,6 +2734,17 @@ dependencies = [
  "num-traits",
 ]
 
+[[package]]
+name = "num-iter"
+version = "0.1.43"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "7d03e6c028c5dc5cac6e2dec0efda81fc887605bb3d884578bb6d6bf7514e252"
+dependencies = [
+ "autocfg",
+ "num-integer",
+ "num-traits",
+]
+
 [[package]]
 name = "num-traits"
 version = "0.2.12"
@@ -3916,6 +3948,7 @@ name = "rustc_driver"
 version = "0.0.0"
 dependencies = [
  "backtrace",
+ "chrono 0.2.25",
  "libc",
  "rustc_ast",
  "rustc_ast_pretty",
@@ -3942,7 +3975,6 @@ dependencies = [
  "rustc_span",
  "rustc_target",
  "serde_json",
- "time 0.3.17",
  "tracing",
  "winapi",
 ]
@@ -5252,7 +5284,7 @@ version = "0.5.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "b3c02f6eb7e7b4100c272f685a9ccaccaab302324e8c7ec3e2ee72340fb29ff3"
 dependencies = [
- "chrono",
+ "chrono 0.4.19",
  "log",
  "nom",
  "serde",

compiler/rustc_driver/Cargo.toml

@@ -9,7 +9,7 @@ crate-type = ["dylib"]
 [dependencies]
 backtrace = "0.3.66"
 serde_json = "1.0.59"
-time = { version = "0.3.17", features = ["std", "formatting"] }
+chrono = "0.2"
 tracing = { version = "0.1.35" }
 rustc_log = { path = "../rustc_log" }
 rustc_middle = { path = "../rustc_middle" }

compiler/rustc_driver/src/lib.rs

@@ -1185,16 +1185,7 @@ pub fn catch_with_exit_code(f: impl FnOnce() -> interface::Result<()>) -> i32 {
 }
 
 struct IceError;
-impl From<time::error::InvalidFormatDescription> for IceError {
-    fn from(_: time::error::InvalidFormatDescription) -> IceError {
-        IceError
-    }
-}
-impl From<time::error::Format> for IceError {
-    fn from(_: time::error::Format) -> IceError {
-        IceError
-    }
-}
+
 impl From<std::io::Error> for IceError {
     fn from(_: std::io::Error) -> IceError {
         IceError
@@ -1203,11 +1194,9 @@ impl From<std::io::Error> for IceError {
 
 fn write_ice_to_disk(info: &panic::PanicInfo<'_>) -> Result<String, IceError> {
     let capture = backtrace::Backtrace::force_capture();
-    let now = time::OffsetDateTime::now_utc();
-    let format = time::format_description::parse("[year]-[month]-[day]_[hour]:[minute]:[second]")?;
-    let file_now = now.format(&format)?;
-    let format = time::format_description::parse("[year]-[month]-[day] [hour]:[minute]:[second]")?;
-    let now = now.format(&format)?;
+    let now = chrono::UTC::now();
+    let file_now = now.format("%Y-%m-%d_%H:%M:%S");
+    let now = now.format("%Y-%m-%d %H:%M:%S");
     let path = format!("rustc-ice-context-{file_now}.txt");
     let mut file = std::fs::File::create(&path)?;
     writeln!(

src/tools/tidy/src/deps.rs

@@ -96,6 +96,7 @@ const PERMITTED_RUSTC_DEPENDENCIES: &[&str] = &[
     "arrayvec",
     "atty",
     "autocfg",
+    "backtrace",
     "bitflags",
     "block-buffer",
     "bumpalo", // Included in Cargo's dep graph but only activated on wasm32-*-unknown.