fix: yet another call expr issue, this fixes #146261

Author: NKID00

compiler/rustc_hir_typeck/src/method/suggest.rs

@@ -1632,7 +1632,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                         (
                             Some((hir::def::CtorKind::Fn, def_id)),
                             hir::ExprKind::Call(rcvr, args),
-                        ) => {
+                        ) if rcvr.hir_id == path_expr.hir_id => {
                             let fn_sig = self.tcx.fn_sig(def_id).instantiate_identity();
                             let inputs = fn_sig.inputs().skip_binder();
                             // FIXME: reuse the logic for "change args" suggestion to account for types

tests/ui/suggestions/incorrect-variant-in-arg.rs

@@ -14,7 +14,7 @@ fn foo(_: Enum) {}
 fn main() {
     foo(Enum::Unit);
     foo(Enum::Tuple);
-    foo(Enum::Struct);  // Suggestion was malformed
+    foo(Enum::Struct); // Suggestion was malformed
     foo(Enum::Unit());
     foo(Enum::Tuple());
     foo(Enum::Struct());
@@ -33,25 +33,25 @@ fn main() {
     foo(Enum::Unit { x: 0, y: 0 });
     foo(Enum::Tuple { x: 0, y: 0 });
     foo(Enum::Struct { x: 0, y: 0 });
-    foo(Enum::unit);  // Suggestion was malformed
-    foo(Enum::tuple);  // Suggestion could be enhanced
-    foo(Enum::r#struct);  // Suggestion was malformed
+    foo(Enum::unit); // Suggestion was malformed
+    foo(Enum::tuple); // Suggestion is enhanced
+    foo(Enum::r#struct); // Suggestion was malformed
     foo(Enum::unit());
     foo(Enum::tuple());
     foo(Enum::r#struct());
-    foo(Enum::unit {});  // Suggestion could be enhanced
-    foo(Enum::tuple {});  // Suggestion could be enhanced
-    foo(Enum::r#struct {});  // Suggestion could be enhanced
+    foo(Enum::unit {}); // Suggestion could be enhanced
+    foo(Enum::tuple {}); // Suggestion could be enhanced
+    foo(Enum::r#struct {}); // Suggestion could be enhanced
     foo(Enum::unit(0));
     foo(Enum::tuple(0));
     foo(Enum::r#struct(0));
-    foo(Enum::unit { x: 0 });  // Suggestion could be enhanced
-    foo(Enum::tuple { x: 0 });  // Suggestion could be enhanced
+    foo(Enum::unit { x: 0 }); // Suggestion could be enhanced
+    foo(Enum::tuple { x: 0 }); // Suggestion could be enhanced
     foo(Enum::r#struct { x: 0 });
     foo(Enum::unit(0, 0));
     foo(Enum::tuple(0, 0));
     foo(Enum::r#struct(0, 0));
-    foo(Enum::unit { x: 0, y: 0 });  // Suggestion could be enhanced
-    foo(Enum::tuple { x: 0, y: 0 });  // Suggestion could be enhanced
-    foo(Enum::r#struct { x: 0, y: 0 });  // Suggestion could be enhanced
+    foo(Enum::unit { x: 0, y: 0 }); // Suggestion could be enhanced
+    foo(Enum::tuple { x: 0, y: 0 }); // Suggestion could be enhanced
+    foo(Enum::r#struct { x: 0, y: 0 }); // Suggestion could be enhanced
 }