Resolver: Batched import resolution.

Collect side effects from the current set of undetermined imports and only
apply them at the end.

Author: LorrensP-2158466

compiler/rustc_hir/src/def.rs

@@ -759,6 +759,24 @@ impl<T> PerNS<T> {
     pub fn iter(&self) -> IntoIter<&T, 3> {
         [&self.value_ns, &self.type_ns, &self.macro_ns].into_iter()
     }
+
+    pub fn into_iter_with(self) -> IntoIter<(Namespace, T), 3> {
+        [
+            (Namespace::TypeNS, self.type_ns),
+            (Namespace::ValueNS, self.value_ns),
+            (Namespace::MacroNS, self.macro_ns),
+        ]
+        .into_iter()
+    }
+
+    pub fn iter_with(&self) -> IntoIter<(Namespace, &T), 3> {
+        [
+            (Namespace::TypeNS, &self.type_ns),
+            (Namespace::ValueNS, &self.value_ns),
+            (Namespace::MacroNS, &self.macro_ns),
+        ]
+        .into_iter()
+    }
 }
 
 impl<T> ::std::ops::Index<Namespace> for PerNS<T> {

compiler/rustc_resolve/src/imports.rs

@@ -1,6 +1,7 @@
 //! A bunch of methods and structures more or less related to resolving imports.
 
 use std::mem;
+use std::ops::Deref;
 
 use rustc_ast::NodeId;
 use rustc_data_structures::fx::{FxHashSet, FxIndexSet};
@@ -41,6 +42,96 @@ use crate::{
 
 type Res = def::Res<NodeId>;
 
+struct ImportResolver<'r, 'ra, 'tcx> {
+    r: CmResolver<'r, 'ra, 'tcx>, // always immutable
+    outputs: ImportResolutionOutputs<'ra>,
+}
+
+enum SideEffect<'ra> {
+    None,
+    Single { import_bindings: PerNS<PendingBinding<'ra>> },
+    Glob { import_bindings: Vec<(NameBinding<'ra>, BindingKey, bool /* warn_ambiguity */)> },
+}
+
+#[derive(Default)]
+struct ImportResolutionOutputs<'ra> {
+    indeterminate_imports: Vec<Import<'ra>>,
+    determined_imports: Vec<(Import<'ra>, SideEffect<'ra>)>,
+}
+
+impl<'ra> ImportResolutionOutputs<'ra> {
+    fn commit<'tcx>(self, r: &mut Resolver<'ra, 'tcx>) {
+        r.indeterminate_imports = self.indeterminate_imports;
+        r.determined_imports.reserve(self.determined_imports.len());
+
+        for (import, side_effect) in self.determined_imports {
+            r.determined_imports.push(import);
+
+            let parent = import.parent_scope.module;
+            match (&import.kind, side_effect) {
+                (
+                    ImportKind::Single { target, bindings, .. },
+                    SideEffect::Single { import_bindings },
+                ) => {
+                    for (ns, pending_binding) in import_bindings.into_iter_with() {
+                        match pending_binding {
+                            PendingBinding::Ready(Some(binding)) => {
+                                r.define_binding_local(parent, *target, ns, binding);
+                            }
+                            PendingBinding::Ready(None) => {
+                                let key = BindingKey::new(*target, ns);
+                                r.update_local_resolution(parent, key, false, |_, resolution| {
+                                    resolution.single_imports.swap_remove(&import);
+                                });
+                            }
+                            _ => {}
+                        }
+                        bindings[ns].set(pending_binding);
+                    }
+                }
+                (ImportKind::Glob { id, .. }, SideEffect::Glob { import_bindings }) => {
+                    let ModuleOrUniformRoot::Module(module) = import.imported_module.get().unwrap()
+                    else {
+                        unreachable!();
+                    };
+
+                    module.glob_importers.borrow_mut(r).push(import);
+
+                    for (binding, key, warn_ambiguity) in import_bindings {
+                        let _ = r.try_define_local(
+                            parent,
+                            key.ident.0,
+                            key.ns,
+                            binding,
+                            warn_ambiguity,
+                        );
+                    }
+
+                    r.record_partial_res(*id, PartialRes::new(module.res().unwrap()));
+                }
+
+                (_, SideEffect::None) => {}
+                // Something weird happened, which shouldn't have happened.
+                _ => unreachable!("Mismatched import kind and side effect"),
+            }
+        }
+    }
+}
+
+impl<'r, 'ra, 'tcx> Deref for ImportResolver<'r, 'ra, 'tcx> {
+    type Target = Resolver<'ra, 'tcx>;
+
+    fn deref(&self) -> &Self::Target {
+        self.r.deref()
+    }
+}
+
+impl<'r, 'ra, 'tcx> AsRef<Resolver<'ra, 'tcx>> for ImportResolver<'r, 'ra, 'tcx> {
+    fn as_ref(&self) -> &Resolver<'ra, 'tcx> {
+        self.r.as_ref()
+    }
+}
+
 /// A [`NameBinding`] in the process of being resolved.
 #[derive(Clone, Copy, Default, PartialEq)]
 pub(crate) enum PendingBinding<'ra> {
@@ -555,18 +646,31 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         let mut indeterminate_count = self.indeterminate_imports.len() * 3;
         while indeterminate_count < prev_indeterminate_count {
             prev_indeterminate_count = indeterminate_count;
-            indeterminate_count = 0;
+            let batch = mem::take(&mut self.indeterminate_imports);
             self.assert_speculative = true;
-            for import in mem::take(&mut self.indeterminate_imports) {
-                let import_indeterminate_count = self.cm().resolve_import(import);
-                indeterminate_count += import_indeterminate_count;
-                match import_indeterminate_count {
-                    0 => self.determined_imports.push(import),
-                    _ => self.indeterminate_imports.push(import),
-                }
+            let (outputs, count) =
+                ImportResolver { r: self.cm(), outputs: Default::default() }.resolve_batch(batch);
+            self.assert_speculative = false;
+            indeterminate_count = count;
+            outputs.commit(self);
+        }
+    }
+
+    fn resolve_batch<'r>(
+        mut self: ImportResolver<'r, 'ra, 'tcx>,
+        batch: Vec<Import<'ra>>,
+    ) -> (ImportResolutionOutputs<'ra>, usize) {
+        let mut indeterminate_count = 0;
+        for import in batch {
+            let (side_effect, import_indeterminate_count) = self.resolve_import(import);
+            indeterminate_count += import_indeterminate_count;
+            match import_indeterminate_count {
+                0 => self.outputs.determined_imports.push((import, side_effect)),
+                _ => self.outputs.indeterminate_imports.push(import),
             }
             self.assert_speculative = false;
         }
+        (self.outputs, indeterminate_count)
     }
 
     pub(crate) fn finalize_imports(&mut self) {
@@ -837,7 +941,10 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
     ///
     /// Meanwhile, if resolve successful, the resolved bindings are written
     /// into the module.
-    fn resolve_import<'r>(mut self: CmResolver<'r, 'ra, 'tcx>, import: Import<'ra>) -> usize {
+    fn resolve_import<'r>(
+        self: &mut ImportResolver<'r, 'ra, 'tcx>,
+        import: Import<'ra>,
+    ) -> (SideEffect<'ra>, usize) {
         debug!(
             "(resolving import for module) resolving import `{}::...` in `{}`",
             Segment::names_to_string(&import.module_path),
@@ -846,7 +953,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         let module = if let Some(module) = import.imported_module.get() {
             module
         } else {
-            let path_res = self.reborrow().maybe_resolve_path(
+            let path_res = self.r.reborrow().maybe_resolve_path(
                 &import.module_path,
                 None,
                 &import.parent_scope,
@@ -855,8 +962,10 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
 
             match path_res {
                 PathResult::Module(module) => module,
-                PathResult::Indeterminate => return 3,
-                PathResult::NonModule(..) | PathResult::Failed { .. } => return 0,
+                PathResult::Indeterminate => return (SideEffect::None, 3),
+                PathResult::NonModule(..) | PathResult::Failed { .. } => {
+                    return (SideEffect::None, 0);
+                }
             }
         };
 
@@ -866,14 +975,14 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                 (source, target, bindings, type_ns_only)
             }
             ImportKind::Glob { .. } => {
-                self.get_mut_unchecked().resolve_glob_import(import);
-                return 0;
+                return (self.resolve_glob_import(import), 0);
             }
             _ => unreachable!(),
         };
 
+        let mut import_bindings = PerNS::default();
         let mut indeterminate_count = 0;
-        self.per_ns_cm(|this, ns| {
+        self.r.reborrow().per_ns_cm(|this, ns| {
             if !type_ns_only || ns == TypeNS {
                 if bindings[ns].get() != PendingBinding::Pending {
                     return;
@@ -885,8 +994,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                     &import.parent_scope,
                     Some(import),
                 );
-                let parent = import.parent_scope.module;
-                let binding = match binding_result {
+                let pending_binding = match binding_result {
                     Ok(binding) => {
                         if binding.is_assoc_item()
                             && !this.tcx.features().import_trait_associated_functions()
@@ -901,39 +1009,25 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                         }
                         // We need the `target`, `source` can be extracted.
                         let imported_binding = this.import(binding, import);
-                        this.get_mut_unchecked().define_binding_local(
-                            parent,
-                            target,
-                            ns,
-                            imported_binding,
-                        );
                         PendingBinding::Ready(Some(imported_binding))
                     }
                     Err(Determinacy::Determined) => {
                         // Don't remove underscores from `single_imports`, they were never added.
-                        if target.name != kw::Underscore {
-                            let key = BindingKey::new(target, ns);
-                            this.get_mut_unchecked().update_local_resolution(
-                                parent,
-                                key,
-                                false,
-                                |_, resolution| {
-                                    resolution.single_imports.swap_remove(&import);
-                                },
-                            );
+                        if target.name == kw::Underscore {
+                            return;
                         }
                         PendingBinding::Ready(None)
                     }
                     Err(Determinacy::Undetermined) => {
                         indeterminate_count += 1;
-                        PendingBinding::Pending
+                        return;
                     }
                 };
                 bindings[ns].set_unchecked(binding);
             }
         });
 
-        indeterminate_count
+        (SideEffect::Single { import_bindings }, indeterminate_count)
     }
 
     /// Performs final import resolution, consistency checks and error reporting.
@@ -1476,13 +1570,16 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         false
     }
 
-    fn resolve_glob_import(&mut self, import: Import<'ra>) {
+    fn resolve_glob_import<'r>(
+        self: &mut ImportResolver<'r, 'ra, 'tcx>,
+        import: Import<'ra>,
+    ) -> SideEffect<'ra> {
         // This function is only called for glob imports.
-        let ImportKind::Glob { id, .. } = import.kind else { unreachable!() };
+        let ImportKind::Glob { .. } = import.kind else { unreachable!() };
 
         let ModuleOrUniformRoot::Module(module) = import.imported_module.get().unwrap() else {
             self.dcx().emit_err(CannotGlobImportAllCrates { span: import.span });
-            return;
+            return SideEffect::None;
         };
 
         if module.is_trait() && !self.tcx.features().import_trait_associated_functions() {
@@ -1496,12 +1593,9 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         }
 
         if module == import.parent_scope.module {
-            return;
+            return SideEffect::None;
         }
 
-        // Add to module's glob_importers
-        module.glob_importers.borrow_mut_unchecked().push(import);
-
         // Ensure that `resolutions` isn't borrowed during `try_define`,
         // since it might get updated via a glob cycle.
         let bindings = self
@@ -1512,6 +1606,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                 resolution.borrow().binding().map(|binding| (*key, binding))
             })
             .collect::<Vec<_>>();
+        let mut import_bindings = Vec::with_capacity(bindings.len());
         for (mut key, binding) in bindings {
             let scope = match key.ident.0.span.reverse_glob_adjust(module.expansion, import.span) {
                 Some(Some(def)) => self.expn_def_scope(def),
@@ -1524,18 +1619,12 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                     .resolution(import.parent_scope.module, key)
                     .and_then(|r| r.binding())
                     .is_some_and(|binding| binding.warn_ambiguity_recursive());
-                let _ = self.try_define_local(
-                    import.parent_scope.module,
-                    key.ident.0,
-                    key.ns,
-                    imported_binding,
-                    warn_ambiguity,
-                );
+                import_bindings.push((imported_binding, key, warn_ambiguity));
             }
         }
 
         // Record the destination of this import
-        self.record_partial_res(id, PartialRes::new(module.res().unwrap()));
+        SideEffect::Glob { import_bindings }
     }
 
     // Miscellaneous post-processing, including recording re-exports,

compiler/rustc_resolve/src/lib.rs

@@ -2581,12 +2581,6 @@ mod ref_mut {
                 true => self.p,
             }
         }
-
-        /// Returns a mutable reference to the inner value without checking if
-        /// it's in a mutable state.
-        pub(crate) fn get_mut_unchecked(&mut self) -> &mut T {
-            self.p
-        }
     }
 
     /// A wrapper around a [`Cell`] that only allows mutation based on a condition in the resolver.

fail.rs

@@ -0,0 +1,30 @@
+#![no_core]
+#![feature(no_core)]
+#![allow(internal_features)]
+#![feature(lang_items)]
+
+#[lang = "sized"]
+pub trait Sized: MetaSized {}
+
+#[lang = "meta_sized"]
+pub trait MetaSized: PointeeSized {}
+
+#[lang = "pointee_sized"]
+pub trait PointeeSized {}
+
+mod core_simd {
+    mod vector {
+        pub struct Simd {}
+    }
+    pub mod simd {
+        pub use crate::core_simd::vector::*;
+    }
+}
+
+pub mod simd {
+    pub use crate::core_simd::simd::*;
+}
+
+mod fail {
+    use crate::simd::Simd;
+}