super_local_decl should visit source_info before copying it

kornelski · kornelski · commit 6573b6259b97 · 2025-02-08T00:23:05.000Z
Visiting source_info first makes it consistent with other visitors
diff --git a/compiler/rustc_middle/src/mir/visit.rs b/compiler/rustc_middle/src/mir/visit.rs
@@ -853,6 +853,8 @@ macro_rules! make_mir_visitor {
                     local_info: _,
                 } = local_decl;
 
+                self.visit_source_info(source_info);
+
                 self.visit_ty($(& $mutability)? *ty, TyContext::LocalDecl {
                     local,
                     source_info: *source_info,
@@ -862,7 +864,6 @@ macro_rules! make_mir_visitor {
                         self.visit_user_type_projection(user_ty);
                     }
                 }
-                self.visit_source_info(source_info);
             }
 
             fn super_var_debug_info(

Original file line number	Diff line number	Diff line change
`@@ -853,6 +853,8 @@ macro_rules! make_mir_visitor {`
`853`	`853`	`local_info: _,`
`854`	`854`	`} = local_decl;`
`855`	`855`
	`856`	`+ self.visit_source_info(source_info);`
	`857`	`+`
`856`	`858`	`self.visit_ty($(& $mutability)? *ty, TyContext::LocalDecl {`
`857`	`859`	`local,`
`858`	`860`	`source_info: *source_info,`
`@@ -862,7 +864,6 @@ macro_rules! make_mir_visitor {`
`862`	`864`	`self.visit_user_type_projection(user_ty);`
`863`	`865`	`}`
`864`	`866`	`}`
`865`		`- self.visit_source_info(source_info);`
`866`	`867`	`}`
`867`	`868`
`868`	`869`	`fn super_var_debug_info(`