remove setup special-casing in Flags::parse

Author: bentongxyz

src/bootstrap/flags.rs

@@ -10,7 +10,6 @@ use getopts::Options;
 use crate::builder::{Builder, Kind};
 use crate::config::{Config, TargetSelection};
 use crate::setup::Profile;
-use crate::util::t;
 use crate::{Build, DocTests};
 
 #[derive(Copy, Clone)]
@@ -544,7 +543,7 @@ Arguments:
             Kind::Bench | Kind::Clean | Kind::Dist | Kind::Install => {}
         };
         // Get any optional paths which occur after the subcommand
-        let mut paths = matches.free[1..].iter().map(|p| p.into()).collect::<Vec<PathBuf>>();
+        let paths = matches.free[1..].iter().map(|p| p.into()).collect::<Vec<PathBuf>>();
 
         let verbose = matches.opt_present("verbose");
 
@@ -616,7 +615,7 @@ Arguments:
                 Subcommand::Run { paths }
             }
             Kind::Setup => {
-                let profile = if paths.len() > 1 {
+                if paths.len() > 1 {
                     println!("\nat most one profile can be passed to setup\n");
                     usage(1, &opts, verbose, &subcommand_help)
                 } else if let Some(path) = paths.pop() {

src/bootstrap/setup.rs

@@ -88,6 +88,7 @@ impl fmt::Display for Profile {
 
 impl Step for Profile {
     type Output = ();
+    const DEFAULT: bool = true;
 
     fn should_run(mut run: ShouldRun<'_>) -> ShouldRun<'_> {
         for choice in Profile::all() {
@@ -140,9 +141,7 @@ pub fn setup(config: &Config, profile: Profile) {
         profile, VERSION
     );
 
-    if !config.dry_run {
-        t!(fs::write(path, settings));
-    }
+    t!(fs::write(path, settings));
 
     let include_path = profile.include_path(&config.src);
     println!("`x.py` will now use the configuration at {}", include_path.display());