add should cache to bootstrap command

Author: Shourya742

src/bootstrap/src/utils/exec.rs

@@ -57,9 +57,9 @@ impl OutputMode {
 
 #[derive(Clone, Debug, PartialEq, Eq, Hash, Default)]
 pub struct CommandCacheKey {
-    program: String,
-    args: Vec<String>,
-    envs: Vec<(String, String)>,
+    program: OsString,
+    args: Vec<OsString>,
+    envs: Vec<(OsString, OsString)>,
     cwd: Option<PathBuf>,
 }
 
@@ -77,32 +77,39 @@ pub struct CommandCacheKey {
 /// [allow_failure]: BootstrapCommand::allow_failure
 /// [delay_failure]: BootstrapCommand::delay_failure
 pub struct BootstrapCommand {
-    program: OsString,
-    args: Vec<OsString>,
-    envs: Vec<(OsString, OsString)>,
-    cwd: Option<PathBuf>,
-
+    cache_key: CommandCacheKey,
     command: Command,
     pub failure_behavior: BehaviorOnFailure,
     // Run the command even during dry run
     pub run_always: bool,
     // This field makes sure that each command is executed (or disarmed) before it is dropped,
     // to avoid forgetting to execute a command.
     drop_bomb: DropBomb,
+    should_cache: bool,
 }
 
 impl<'a> BootstrapCommand {
     #[track_caller]
     pub fn new<S: AsRef<OsStr>>(program: S) -> Self {
-        Command::new(program).into()
+        Self {
+            should_cache: true,
+            cache_key: CommandCacheKey {
+                program: program.as_ref().to_os_string(),
+                ..CommandCacheKey::default()
+            },
+            ..Command::new(program).into()
+        }
     }
-
     pub fn arg<S: AsRef<OsStr>>(&mut self, arg: S) -> &mut Self {
-        self.args.push(arg.as_ref().to_os_string());
+        self.cache_key.args.push(arg.as_ref().to_os_string());
         self.command.arg(arg.as_ref());
         self
     }
 
+    pub fn should_cache(&self) -> bool {
+        self.should_cache
+    }
+
     pub fn args<I, S>(&mut self, args: I) -> &mut Self
     where
         I: IntoIterator<Item = S>,
@@ -119,7 +126,7 @@ impl<'a> BootstrapCommand {
         K: AsRef<OsStr>,
         V: AsRef<OsStr>,
     {
-        self.envs.push((key.as_ref().to_os_string(), val.as_ref().to_os_string()));
+        self.cache_key.envs.push((key.as_ref().to_os_string(), val.as_ref().to_os_string()));
         self.command.env(key, val);
         self
     }
@@ -138,7 +145,7 @@ impl<'a> BootstrapCommand {
     }
 
     pub fn current_dir<P: AsRef<Path>>(&mut self, dir: P) -> &mut Self {
-        self.cwd = Some(dir.as_ref().to_path_buf());
+        self.cache_key.cwd = Some(dir.as_ref().to_path_buf());
         self.command.current_dir(dir);
         self
     }
@@ -205,6 +212,7 @@ impl<'a> BootstrapCommand {
         // We don't know what will happen with the returned command, so we need to mark this
         // command as executed proactively.
         self.mark_as_executed();
+        self.should_cache = false;
         &mut self.command
     }
 
@@ -232,12 +240,7 @@ impl<'a> BootstrapCommand {
     }
 
     pub fn cache_key(&self) -> CommandCacheKey {
-        CommandCacheKey {
-            program: self.program.clone(),
-            args: self.args.clone(),
-            envs: self.envs.clone(),
-            cwd: self.cwd.clone(),
-        }
+        self.cache_key.clone()
     }
 }
 
@@ -254,10 +257,8 @@ impl From<Command> for BootstrapCommand {
         let program = command.get_program().to_owned();
 
         Self {
-            program: program.clone(),
-            args: Vec::new(),
-            envs: Vec::new(),
-            cwd: None,
+            cache_key: CommandCacheKey::default(),
+            should_cache: false,
             command,
             failure_behavior: BehaviorOnFailure::Exit,
             run_always: false,

src/bootstrap/src/utils/execution_context.rs

@@ -148,7 +148,9 @@ impl ExecutionContext {
     ) -> CommandOutput {
         let cache_key = command.cache_key();
 
-        if let Some(cached_output) = self.command_cache.get(&cache_key) {
+        if command.should_cache()
+            && let Some(cached_output) = self.command_cache.get(&cache_key)
+        {
             command.mark_as_executed();
             if self.dry_run() && !command.run_always {
                 return CommandOutput::default();
@@ -159,7 +161,7 @@ impl ExecutionContext {
 
         let output = self.start(command, stdout, stderr).wait_for_output(self);
 
-        if !self.dry_run() || command.run_always {
+        if !self.dry_run() || command.run_always && command.should_cache() {
             self.command_cache.insert(cache_key, output.clone());
         }