cleanup

Author: LorrensP-2158466

compiler/rustc_resolve/src/build_reduced_graph.rs

@@ -620,24 +620,14 @@ impl<'a, 'ra, 'tcx> BuildReducedGraphVisitor<'a, 'ra, 'tcx> {
                 let kind = ImportKind::Single {
                     source: source.ident,
                     target: ident,
-                    // source_bindings: PerNS {
-                    //     type_ns: Cell::new(Err(Determinacy::Undetermined)),
-                    //     value_ns: Cell::new(Err(Determinacy::Undetermined)),
-                    //     macro_ns: Cell::new(Err(Determinacy::Undetermined)),
-                    // },
-                    // target_bindings: PerNS {
-                    //     type_ns: Cell::new(None),
-                    //     value_ns: Cell::new(None),
-                    //     macro_ns: Cell::new(None),
-                    // },
-                    type_ns_only,
-                    nested,
-                    id,
                     bindings: PerNS {
                         value_ns: Cell::new(Poll::Pending),
                         type_ns: Cell::new(Poll::Pending),
                         macro_ns: Cell::new(Poll::Pending),
                     },
+                    type_ns_only,
+                    nested,
+                    id,
                 };
 
                 self.add_import(module_path, kind, use_tree.span, item, root_span, item.id, vis);

compiler/rustc_resolve/src/imports.rs

@@ -42,6 +42,7 @@ use crate::{
 type Res = def::Res<NodeId>;
 
 // Poll is a weird name.
+// FIXME: define/use something else because we are not doing async.
 pub(crate) use std::task::Poll as Progress;
 
 /// Contains data for specific kinds of imports.
@@ -53,10 +54,6 @@ pub(crate) enum ImportKind<'ra> {
         /// `target` in `use prefix::source as target`.
         /// It will directly use `source` when the format is `use prefix::source`.
         target: Ident,
-        // Bindings to which `source` refers to.
-        // source_bindings: PerNS<Cell<Result<NameBinding<'ra>, Determinacy>>>,
-        // Bindings introduced by `target`.
-        // target_bindings: PerNS<Cell<Option<NameBinding<'ra>>>>,
         /// Bindings introduced by the import.
         /// `Progress` (Poll) because it's clearer semantically:
         ///  - `Progress::Ready(Some)`: Determined and resolved