Reorder args for visit_results_in_block.

Put `analysis` first, to match `apply_effects_in_range`.

Author: nnethercote

compiler/rustc_mir_dataflow/src/framework/direction.rs

@@ -40,10 +40,10 @@ pub trait Direction {
     /// all locations in a basic block (starting from `entry_state` and to
     /// visit them with `vis`.
     fn visit_results_in_block<'mir, 'tcx, A>(
+        analysis: &mut A,
         state: &mut A::Domain,
         block: BasicBlock,
         block_data: &'mir mir::BasicBlockData<'tcx>,
-        analysis: &mut A,
         vis: &mut impl ResultsVisitor<'tcx, A>,
     ) where
         A: Analysis<'tcx>;
@@ -206,10 +206,10 @@ impl Direction for Backward {
     }
 
     fn visit_results_in_block<'mir, 'tcx, A>(
+        analysis: &mut A,
         state: &mut A::Domain,
         block: BasicBlock,
         block_data: &'mir mir::BasicBlockData<'tcx>,
-        analysis: &mut A,
         vis: &mut impl ResultsVisitor<'tcx, A>,
     ) where
         A: Analysis<'tcx>,
@@ -386,10 +386,10 @@ impl Direction for Forward {
     }
 
     fn visit_results_in_block<'mir, 'tcx, A>(
+        analysis: &mut A,
         state: &mut A::Domain,
         block: BasicBlock,
         block_data: &'mir mir::BasicBlockData<'tcx>,
-        analysis: &mut A,
         vis: &mut impl ResultsVisitor<'tcx, A>,
     ) where
         A: Analysis<'tcx>,

compiler/rustc_mir_dataflow/src/framework/visitor.rs

@@ -24,7 +24,7 @@ pub fn visit_results<'mir, 'tcx, A>(
 
         let block_data = &body[block];
         state.clone_from(&results[block]);
-        A::Direction::visit_results_in_block(&mut state, block, block_data, analysis, vis);
+        A::Direction::visit_results_in_block(analysis, &mut state, block, block_data, vis);
     }
 }