Simplify ring buffer pushes

Author: dtolnay

compiler/rustc_ast_pretty/src/pp.rs

@@ -288,12 +288,11 @@ impl Printer {
             self.left_total = 1;
             self.right_total = 1;
             self.right = self.left;
-            self.buf.truncate(1);
+            self.buf.clear();
         } else {
             self.right += 1;
-            self.buf.advance_right();
         }
-        self.buf[self.right] = BufEntry { token: Token::Begin(b), size: -self.right_total };
+        self.buf.push(BufEntry { token: Token::Begin(b), size: -self.right_total });
         self.scan_stack.push_front(self.right);
     }
 
@@ -302,8 +301,7 @@ impl Printer {
             self.print_end();
         } else {
             self.right += 1;
-            self.buf.advance_right();
-            self.buf[self.right] = BufEntry { token: Token::End, size: -1 };
+            self.buf.push(BufEntry { token: Token::End, size: -1 });
             self.scan_stack.push_front(self.right);
         }
     }
@@ -329,9 +327,8 @@ impl Printer {
             self.print_string(s);
         } else {
             self.right += 1;
-            self.buf.advance_right();
             let len = s.len() as isize;
-            self.buf[self.right] = BufEntry { token: Token::String(s), size: len };
+            self.buf.push(BufEntry { token: Token::String(s), size: len });
             self.right_total += len;
             self.check_stream();
         }

compiler/rustc_ast_pretty/src/pp/ring.rs

@@ -22,6 +22,10 @@ impl<T> RingBuffer<T> {
         RingBuffer { data: VecDeque::new(), offset: 0 }
     }
 
+    pub fn push(&mut self, value: T) {
+        self.data.push_back(value);
+    }
+
     pub fn advance_right(&mut self)
     where
         T: Default,
@@ -34,6 +38,10 @@ impl<T> RingBuffer<T> {
         self.offset += 1;
     }
 
+    pub fn clear(&mut self) {
+        self.data.clear();
+    }
+
     pub fn truncate(&mut self, len: usize) {
         self.data.truncate(len);
     }