More attempts to fix ICE

Author: fee1-dead

compiler/rustc_infer/src/infer/equate.rs

@@ -166,8 +166,10 @@ impl<'tcx> TypeRelation<'tcx> for Equate<'_, '_, 'tcx> {
         a: ty::ConstnessArg,
         b: ty::ConstnessArg,
     ) -> RelateResult<'tcx, ty::ConstnessArg> {
-        // TODO handle infer
-        relate::super_relate_constness(self, a, b)
+        match (a, b) {
+            (ty::ConstnessArg::Infer, x) | (x, ty::ConstnessArg::Infer) => Ok(x),
+            _ => relate::super_relate_constness(self, a, b),
+        }
     }
 }
 

compiler/rustc_middle/src/ty/context.rs

@@ -2964,6 +2964,15 @@ impl<'tcx> TyCtxt<'tcx> {
             })
         )
     }
+
+    pub fn should_have_constness(self, def_id: DefId) -> bool {
+        match self.def_kind(def_id) {
+            DefKind::Trait => true,
+            DefKind::Impl if self.constness(def_id) == hir::Constness::Const => true,
+            DefKind::AssocFn => self.should_have_constness(self.parent(def_id)),
+            _ => false,
+        }
+    }
 }
 
 impl<'tcx> TyCtxtAt<'tcx> {

compiler/rustc_middle/src/ty/generics.rs

@@ -123,6 +123,7 @@ pub struct Generics {
 
     pub has_self: bool,
     pub has_constness: bool,
+    pub parent_has_constness: bool,
     pub has_late_bound_regions: Option<Span>,
 }
 
@@ -240,6 +241,7 @@ impl<'tcx> Generics {
     }
 
     /// Returns the `ConstnessArg`
+    // TODO just use self.has_constness?
     pub fn has_constness_param(&'tcx self) -> bool {
         self.params.iter().any(|param| matches!(param.kind, ty::GenericParamDefKind::Constness))
     }
@@ -295,6 +297,15 @@ impl<'tcx> Generics {
         let own = &substs[self.parent_count..][..self.params.len()];
         if self.has_self && self.parent.is_none() { &own[1..] } else { &own }
     }
+
+    /*pub fn expected_arg_count(&self) -> std::ops::RangeInclusive<usize> {
+        self.count()
+        todo!()
+    }*/
+
+    pub fn expected_parent_count(&self) -> std::ops::RangeInclusive<usize> {
+        self.parent_count..=self.parent_count + self.parent_has_constness as usize
+    }
 }
 
 /// Bounds on generics.

compiler/rustc_middle/src/ty/print/pretty.rs

@@ -1824,11 +1824,15 @@ impl<'tcx> Printer<'tcx> for FmtPrinter<'_, 'tcx> {
                 GenericArgKind::Lifetime(r) => !r.is_erased(),
                 _ => false,
             });
-        let mut args = args.iter().cloned().filter(|arg| match arg.unpack() {
-            GenericArgKind::Lifetime(_) => print_regions,
-            GenericArgKind::Constness(_) => false,
-            _ => true,
-        }).peekable();
+        let mut args = args
+            .iter()
+            .cloned()
+            .filter(|arg| match arg.unpack() {
+                GenericArgKind::Lifetime(_) => print_regions,
+                GenericArgKind::Constness(_) => false,
+                _ => true,
+            })
+            .peekable();
 
         if args.peek().is_some() {
             if self.in_value {

compiler/rustc_middle/src/ty/subst.rs

@@ -580,8 +580,8 @@ impl<'a, 'tcx> TypeFolder<'tcx> for SubstFolder<'a, 'tcx> {
                     _ => {
                         let msg = format!(
                             "Region parameter out of range \
-                             when substituting in region {} (index={})",
-                            data.name, data.index
+                             when substituting in region {} (index={}, substs={:?})",
+                            data.name, data.index, self.substs
                         );
                         span_bug!(DUMMY_SP, "{}", msg);
                     }

compiler/rustc_typeck/src/astconv/mod.rs

@@ -376,7 +376,11 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
         // non-`Self` generic parameters.
         if generics.params.is_empty() {
             return (
-                tcx.intern_substs(&constness.map(Into::into).into_iter().collect::<Vec<_>>()),
+                tcx.intern_substs(&if let Some(ty::ConstnessArg::Const) = constness {
+                    vec![ty::ConstnessArg::Const.into()]
+                } else {
+                    vec![]
+                }),
                 arg_count,
             );
         }

compiler/rustc_typeck/src/check/method/confirm.rs

@@ -345,7 +345,7 @@ impl<'a, 'tcx> ConfirmContext<'a, 'tcx> {
 
         // Create subst for early-bound lifetime parameters, combining
         // parameters from the type and those from the method.
-        assert_eq!(generics.parent_count, parent_substs.len());
+        assert!(generics.expected_parent_count().contains(&parent_substs.len()));
 
         struct MethodSubstsCtxt<'a, 'tcx> {
             cfcx: &'a ConfirmContext<'a, 'tcx>,

compiler/rustc_typeck/src/check/method/mod.rs

@@ -454,7 +454,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
         };
         let def_id = method_item.def_id;
         let generics = tcx.generics_of(def_id);
-        assert_eq!(generics.params.len(), generics.has_constness as usize); // no generics except for constness
+        assert!(generics.params.len() <= generics.has_constness as usize); // no generics except for constness
 
         debug!("lookup_in_trait_adjusted: method_item={:?}", method_item);
         let mut obligations = vec![];

compiler/rustc_typeck/src/check/method/probe.rs

@@ -1783,9 +1783,8 @@ impl<'a, 'tcx> ProbeContext<'a, 'tcx> {
         // method yet. So create fresh variables here for those too,
         // if there are any.
         let generics = self.tcx.generics_of(method);
-        assert_eq!(
-            substs.len(),
-            generics.parent_count as usize,
+        assert!(
+            generics.expected_parent_count().contains(&substs.len()),
             "substs: {:#?}\ngenerics: {:#?}",
             substs,
             generics

compiler/rustc_typeck/src/check/mod.rs

@@ -963,7 +963,10 @@ fn has_expected_num_generic_args<'tcx>(
 ) -> bool {
     trait_did.map_or(true, |trait_did| {
         let generics = tcx.generics_of(trait_did);
-        generics.count() == expected + if generics.has_self { 1 } else { 0 } + if generics.has_constness { 1 } else { 0 }
+        generics.count()
+            == expected
+                + if generics.has_self { 1 } else { 0 }
+                + if generics.has_constness { 1 } else { 0 }
     })
 }