fix ICE 1/2

Author: lcnr

compiler/rustc_hir_typeck/src/opaque_types.rs

@@ -1,4 +1,6 @@
-use rustc_middle::ty::{DefiningScopeKind, EarlyBinder, OpaqueHiddenType, OpaqueTypeKey, Ty};
+use rustc_middle::ty::{
+    DefiningScopeKind, EarlyBinder, OpaqueHiddenType, OpaqueTypeKey, Ty, TypeVisitableExt,
+};
 use rustc_trait_selection::opaque_types::{
     InvalidOpaqueTypeArgs, check_opaque_type_parameter_valid,
 };
@@ -46,6 +48,15 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                 ) => continue,
             }
 
+            if hidden_type.ty.has_non_region_infer() {
+                let guar =
+                    tcx.dcx().span_err(hidden_type.span, "non-defining use in the defining scope");
+                typeck_results
+                    .concrete_opaque_types
+                    .insert(opaque_type_key.def_id, OpaqueHiddenType::new_error(tcx, guar));
+                self.set_tainted_by_errors(guar);
+            }
+
             let hidden_type = hidden_type.remap_generic_params_to_declaration_params(
                 opaque_type_key,
                 tcx,
@@ -81,12 +92,14 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
         opaque_types: &[(OpaqueTypeKey<'tcx>, OpaqueHiddenType<'tcx>)],
     ) {
         let tcx = self.tcx;
-        let typeck_results = &mut *self.typeck_results.borrow_mut();
         for &(key, hidden_type) in opaque_types {
-            let Some(&expected) = typeck_results.concrete_opaque_types.get(&key.def_id) else {
+            let Some(&expected) =
+                self.typeck_results.borrow_mut().concrete_opaque_types.get(&key.def_id)
+            else {
                 let guar =
                     tcx.dcx().span_err(hidden_type.span, "non-defining use in the defining scope");
-                typeck_results
+                self.typeck_results
+                    .borrow_mut()
                     .concrete_opaque_types
                     .insert(key.def_id, OpaqueHiddenType::new_error(tcx, guar));
                 self.set_tainted_by_errors(guar);