Skip to content

Commit 4d52dc4

Browse files
borsbors
committed
Auto merge of #76754 - varkor:diagnostic-cleanup-ii, r=ecstatic-morse
Clean up diagnostics for arithmetic operation errors Plus a small tweak to a range pattern error message.
2 parents 9e34b72 + c0b1057 commit 4d52dc4

File tree

119 files changed

+452
-447
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

119 files changed

+452
-447
lines changed

‎compiler/rustc_middle/src/mir/mod.rs‎

Lines changed: 30 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1300,49 +1300,49 @@ impl<O> AssertKind<O> {
13001300
match self {
13011301
BoundsCheck { ref len, ref index } => write!(
13021302
f,
1303-
"\"index out of bounds: the len is {{}} but the index is {{}}\", {:?}, {:?}",
1303+
"\"index out of bounds: the length is {{}} but the index is {{}}\", {:?}, {:?}",
13041304
len, index
13051305
),
13061306

13071307
OverflowNeg(op) => {
1308-
write!(f, "\"attempt to negate {{}} which would overflow\", {:?}", op)
1308+
write!(f, "\"attempt to negate `{{}}`, which would overflow\", {:?}", op)
13091309
}
1310-
DivisionByZero(op) => write!(f, "\"attempt to divide {{}} by zero\", {:?}", op),
1310+
DivisionByZero(op) => write!(f, "\"attempt to divide `{{}}` by zero\", {:?}", op),
13111311
RemainderByZero(op) => write!(
13121312
f,
1313-
"\"attempt to calculate the remainder of {{}} with a divisor of zero\", {:?}",
1313+
"\"attempt to calculate the remainder of `{{}}` with a divisor of zero\", {:?}",
13141314
op
13151315
),
13161316
Overflow(BinOp::Add, l, r) => write!(
13171317
f,
1318-
"\"attempt to compute `{{}} + {{}}` which would overflow\", {:?}, {:?}",
1318+
"\"attempt to compute `{{}} + {{}}`, which would overflow\", {:?}, {:?}",
13191319
l, r
13201320
),
13211321
Overflow(BinOp::Sub, l, r) => write!(
13221322
f,
1323-
"\"attempt to compute `{{}} - {{}}` which would overflow\", {:?}, {:?}",
1323+
"\"attempt to compute `{{}} - {{}}`, which would overflow\", {:?}, {:?}",
13241324
l, r
13251325
),
13261326
Overflow(BinOp::Mul, l, r) => write!(
13271327
f,
1328-
"\"attempt to compute `{{}} * {{}}` which would overflow\", {:?}, {:?}",
1328+
"\"attempt to compute `{{}} * {{}}`, which would overflow\", {:?}, {:?}",
13291329
l, r
13301330
),
13311331
Overflow(BinOp::Div, l, r) => write!(
13321332
f,
1333-
"\"attempt to compute `{{}} / {{}}` which would overflow\", {:?}, {:?}",
1333+
"\"attempt to compute `{{}} / {{}}`, which would overflow\", {:?}, {:?}",
13341334
l, r
13351335
),
13361336
Overflow(BinOp::Rem, l, r) => write!(
13371337
f,
1338-
"\"attempt to compute the remainder of `{{}} % {{}}` which would overflow\", {:?}, {:?}",
1338+
"\"attempt to compute the remainder of `{{}} % {{}}`, which would overflow\", {:?}, {:?}",
13391339
l, r
13401340
),
13411341
Overflow(BinOp::Shr, _, r) => {
1342-
write!(f, "\"attempt to shift right by {{}} which would overflow\", {:?}", r)
1342+
write!(f, "\"attempt to shift right by `{{}}`, which would overflow\", {:?}", r)
13431343
}
13441344
Overflow(BinOp::Shl, _, r) => {
1345-
write!(f, "\"attempt to shift left by {{}} which would overflow\", {:?}", r)
1345+
write!(f, "\"attempt to shift left by `{{}}`, which would overflow\", {:?}", r)
13461346
}
13471347
_ => write!(f, "\"{}\"", self.description()),
13481348
}
@@ -1353,36 +1353,40 @@ impl<O: fmt::Debug> fmt::Debug for AssertKind<O> {
13531353
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
13541354
use AssertKind::*;
13551355
match self {
1356-
BoundsCheck { ref len, ref index } => {
1357-
write!(f, "index out of bounds: the len is {:?} but the index is {:?}", len, index)
1358-
}
1359-
OverflowNeg(op) => write!(f, "attempt to negate {:#?} which would overflow", op),
1360-
DivisionByZero(op) => write!(f, "attempt to divide {:#?} by zero", op),
1361-
RemainderByZero(op) => {
1362-
write!(f, "attempt to calculate the remainder of {:#?} with a divisor of zero", op)
1363-
}
1356+
BoundsCheck { ref len, ref index } => write!(
1357+
f,
1358+
"index out of bounds: the length is {:?} but the index is {:?}",
1359+
len, index
1360+
),
1361+
OverflowNeg(op) => write!(f, "attempt to negate `{:#?}`, which would overflow", op),
1362+
DivisionByZero(op) => write!(f, "attempt to divide `{:#?}` by zero", op),
1363+
RemainderByZero(op) => write!(
1364+
f,
1365+
"attempt to calculate the remainder of `{:#?}` with a divisor of zero",
1366+
op
1367+
),
13641368
Overflow(BinOp::Add, l, r) => {
1365-
write!(f, "attempt to compute `{:#?} + {:#?}` which would overflow", l, r)
1369+
write!(f, "attempt to compute `{:#?} + {:#?}`, which would overflow", l, r)
13661370
}
13671371
Overflow(BinOp::Sub, l, r) => {
1368-
write!(f, "attempt to compute `{:#?} - {:#?}` which would overflow", l, r)
1372+
write!(f, "attempt to compute `{:#?} - {:#?}`, which would overflow", l, r)
13691373
}
13701374
Overflow(BinOp::Mul, l, r) => {
1371-
write!(f, "attempt to compute `{:#?} * {:#?}` which would overflow", l, r)
1375+
write!(f, "attempt to compute `{:#?} * {:#?}`, which would overflow", l, r)
13721376
}
13731377
Overflow(BinOp::Div, l, r) => {
1374-
write!(f, "attempt to compute `{:#?} / {:#?}` which would overflow", l, r)
1378+
write!(f, "attempt to compute `{:#?} / {:#?}`, which would overflow", l, r)
13751379
}
13761380
Overflow(BinOp::Rem, l, r) => write!(
13771381
f,
1378-
"attempt to compute the remainder of `{:#?} % {:#?}` which would overflow",
1382+
"attempt to compute the remainder of `{:#?} % {:#?}`, which would overflow",
13791383
l, r
13801384
),
13811385
Overflow(BinOp::Shr, _, r) => {
1382-
write!(f, "attempt to shift right by {:#?} which would overflow", r)
1386+
write!(f, "attempt to shift right by `{:#?}`, which would overflow", r)
13831387
}
13841388
Overflow(BinOp::Shl, _, r) => {
1385-
write!(f, "attempt to shift left by {:#?} which would overflow", r)
1389+
write!(f, "attempt to shift left by `{:#?}`, which would overflow", r)
13861390
}
13871391
_ => write!(f, "{}", self.description()),
13881392
}

‎compiler/rustc_typeck/src/check/pat.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
495495
self.tcx.sess,
496496
span,
497497
E0029,
498-
"only char and numeric types are allowed in range patterns"
498+
"only `char` and numeric types are allowed in range patterns"
499499
);
500500
let msg = |ty| format!("this is of type `{}` but it should be `char` or numeric", ty);
501501
let mut one_side_err = |first_span, first_ty, second: Option<(bool, Ty<'tcx>, Span)>| {

‎src/test/mir-opt/array_index_is_temporary.main.SimplifyCfg-elaborate-drops.after.32bit.mir‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ fn main() -> () {
4848
_7 = _2; // scope 3 at $DIR/array-index-is-temporary.rs:16:7: 16:8
4949
_8 = Len(_1); // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
5050
_9 = Lt(_7, _8); // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
51-
assert(move _9, "index out of bounds: the len is {} but the index is {}", move _8, _7) -> bb2; // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
51+
assert(move _9, "index out of bounds: the length is {} but the index is {}", move _8, _7) -> bb2; // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
5252
}
5353

5454
bb2: {

‎src/test/mir-opt/array_index_is_temporary.main.SimplifyCfg-elaborate-drops.after.64bit.mir‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ fn main() -> () {
4848
_7 = _2; // scope 3 at $DIR/array-index-is-temporary.rs:16:7: 16:8
4949
_8 = Len(_1); // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
5050
_9 = Lt(_7, _8); // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
51-
assert(move _9, "index out of bounds: the len is {} but the index is {}", move _8, _7) -> bb2; // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
51+
assert(move _9, "index out of bounds: the length is {} but the index is {}", move _8, _7) -> bb2; // scope 3 at $DIR/array-index-is-temporary.rs:16:5: 16:9
5252
}
5353

5454
bb2: {

‎src/test/mir-opt/combine_array_len.norm2.InstCombine.32bit.diff‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
- _4 = Len(_1); // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
3333
+ _4 = const 2_usize; // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
3434
_5 = Lt(_3, _4); // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
35-
assert(move _5, "index out of bounds: the len is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
35+
assert(move _5, "index out of bounds: the length is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
3636
}
3737

3838
bb1: {
@@ -44,7 +44,7 @@
4444
- _8 = Len(_1); // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
4545
+ _8 = const 2_usize; // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
4646
_9 = Lt(_7, _8); // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
47-
assert(move _9, "index out of bounds: the len is {} but the index is {}", move _8, _7) -> bb2; // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
47+
assert(move _9, "index out of bounds: the length is {} but the index is {}", move _8, _7) -> bb2; // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
4848
}
4949

5050
bb2: {

‎src/test/mir-opt/combine_array_len.norm2.InstCombine.64bit.diff‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
- _4 = Len(_1); // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
3333
+ _4 = const 2_usize; // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
3434
_5 = Lt(_3, _4); // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
35-
assert(move _5, "index out of bounds: the len is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
35+
assert(move _5, "index out of bounds: the length is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/combine_array_len.rs:5:13: 5:17
3636
}
3737

3838
bb1: {
@@ -44,7 +44,7 @@
4444
- _8 = Len(_1); // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
4545
+ _8 = const 2_usize; // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
4646
_9 = Lt(_7, _8); // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
47-
assert(move _9, "index out of bounds: the len is {} but the index is {}", move _8, _7) -> bb2; // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
47+
assert(move _9, "index out of bounds: the length is {} but the index is {}", move _8, _7) -> bb2; // scope 1 at $DIR/combine_array_len.rs:6:13: 6:17
4848
}
4949

5050
bb2: {

‎src/test/mir-opt/const_prop/array_index.main.ConstProp.32bit.diff‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
_3 = const 2_usize; // scope 0 at $DIR/array_index.rs:5:31: 5:32
2121
_4 = const 4_usize; // scope 0 at $DIR/array_index.rs:5:18: 5:33
2222
- _5 = Lt(_3, _4); // scope 0 at $DIR/array_index.rs:5:18: 5:33
23-
- assert(move _5, "index out of bounds: the len is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
23+
- assert(move _5, "index out of bounds: the length is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
2424
+ _5 = const true; // scope 0 at $DIR/array_index.rs:5:18: 5:33
25-
+ assert(const true, "index out of bounds: the len is {} but the index is {}", const 4_usize, const 2_usize) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
25+
+ assert(const true, "index out of bounds: the length is {} but the index is {}", const 4_usize, const 2_usize) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
2626
}
2727

2828
bb1: {

‎src/test/mir-opt/const_prop/array_index.main.ConstProp.64bit.diff‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
_3 = const 2_usize; // scope 0 at $DIR/array_index.rs:5:31: 5:32
2121
_4 = const 4_usize; // scope 0 at $DIR/array_index.rs:5:18: 5:33
2222
- _5 = Lt(_3, _4); // scope 0 at $DIR/array_index.rs:5:18: 5:33
23-
- assert(move _5, "index out of bounds: the len is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
23+
- assert(move _5, "index out of bounds: the length is {} but the index is {}", move _4, _3) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
2424
+ _5 = const true; // scope 0 at $DIR/array_index.rs:5:18: 5:33
25-
+ assert(const true, "index out of bounds: the len is {} but the index is {}", const 4_usize, const 2_usize) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
25+
+ assert(const true, "index out of bounds: the length is {} but the index is {}", const 4_usize, const 2_usize) -> bb1; // scope 0 at $DIR/array_index.rs:5:18: 5:33
2626
}
2727

2828
bb1: {

‎src/test/mir-opt/const_prop/bad_op_div_by_zero.main.ConstProp.diff‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,21 @@
2424
StorageLive(_3); // scope 1 at $DIR/bad_op_div_by_zero.rs:5:18: 5:19
2525
- _3 = _1; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:18: 5:19
2626
- _4 = Eq(_3, const 0_i32); // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
27-
- assert(!move _4, "attempt to divide {} by zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
27+
- assert(!move _4, "attempt to divide `{}` by zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
2828
+ _3 = const 0_i32; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:18: 5:19
2929
+ _4 = const true; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
30-
+ assert(!const true, "attempt to divide {} by zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
30+
+ assert(!const true, "attempt to divide `{}` by zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
3131
}
3232

3333
bb1: {
3434
- _5 = Eq(_3, const -1_i32); // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
3535
- _6 = Eq(const 1_i32, const i32::MIN); // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
3636
- _7 = BitAnd(move _5, move _6); // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
37-
- assert(!move _7, "attempt to compute `{} / {}` which would overflow", const 1_i32, _3) -> bb2; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
37+
- assert(!move _7, "attempt to compute `{} / {}`, which would overflow", const 1_i32, _3) -> bb2; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
3838
+ _5 = const false; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
3939
+ _6 = const false; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
4040
+ _7 = const false; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
41-
+ assert(!const false, "attempt to compute `{} / {}` which would overflow", const 1_i32, const 0_i32) -> bb2; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
41+
+ assert(!const false, "attempt to compute `{} / {}`, which would overflow", const 1_i32, const 0_i32) -> bb2; // scope 1 at $DIR/bad_op_div_by_zero.rs:5:14: 5:19
4242
}
4343

4444
bb2: {

‎src/test/mir-opt/const_prop/bad_op_mod_by_zero.main.ConstProp.diff‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,21 @@
2424
StorageLive(_3); // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:18: 5:19
2525
- _3 = _1; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:18: 5:19
2626
- _4 = Eq(_3, const 0_i32); // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
27-
- assert(!move _4, "attempt to calculate the remainder of {} with a divisor of zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
27+
- assert(!move _4, "attempt to calculate the remainder of `{}` with a divisor of zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
2828
+ _3 = const 0_i32; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:18: 5:19
2929
+ _4 = const true; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
30-
+ assert(!const true, "attempt to calculate the remainder of {} with a divisor of zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
30+
+ assert(!const true, "attempt to calculate the remainder of `{}` with a divisor of zero", const 1_i32) -> bb1; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
3131
}
3232

3333
bb1: {
3434
- _5 = Eq(_3, const -1_i32); // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
3535
- _6 = Eq(const 1_i32, const i32::MIN); // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
3636
- _7 = BitAnd(move _5, move _6); // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
37-
- assert(!move _7, "attempt to compute the remainder of `{} % {}` which would overflow", const 1_i32, _3) -> bb2; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
37+
- assert(!move _7, "attempt to compute the remainder of `{} % {}`, which would overflow", const 1_i32, _3) -> bb2; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
3838
+ _5 = const false; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
3939
+ _6 = const false; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
4040
+ _7 = const false; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
41-
+ assert(!const false, "attempt to compute the remainder of `{} % {}` which would overflow", const 1_i32, const 0_i32) -> bb2; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
41+
+ assert(!const false, "attempt to compute the remainder of `{} % {}`, which would overflow", const 1_i32, const 0_i32) -> bb2; // scope 1 at $DIR/bad_op_mod_by_zero.rs:5:14: 5:19
4242
}
4343

4444
bb2: {

0 commit comments

Comments
 (0)