bind LLVMRemoveEnumAttributeAtIndex and remove noinline attribute from function

Author: Shourya742

compiler/rustc_codegen_llvm/src/attributes.rs

@@ -28,10 +28,14 @@ pub(crate) fn apply_to_callsite(callsite: &Value, idx: AttributePlace, attrs: &[
     }
 }
 
-pub(crate) fn has_attr(llfn: &Value, idx: AttributePlace, attr: &Attribute) -> bool {
+pub(crate) fn has_attr(llfn: &Value, idx: u32, attr: AttributeKind) -> bool {
     llvm::HasAttributeAtIndex(llfn, idx, attr)
 }
 
+pub(crate) fn remove_from_llfn(llfn: &Value, place: AttributePlace, kind: AttributeKind) {
+    llvm::RemoveEnumAttributeAtIndex(llfn, place, kind);
+}
+
 /// Get LLVM attribute for the provided inline heuristic.
 #[inline]
 fn inline_attr<'ll>(cx: &CodegenCx<'ll, '_>, inline: InlineAttr) -> Option<&'ll Attribute> {

compiler/rustc_codegen_llvm/src/back/lto.rs

@@ -677,10 +677,13 @@ pub(crate) fn run_pass_manager(
                 // This is not strictly necessary for correctness, but serves as a sanity check
                 // in case the autodiff pass stops injecting `noinline` in the future.
                 assert!(
-                    attributes::has_attr(function, llvm::AttributeKind::NoInline, Function),
+                    !attributes::has_attr(function, 0, llvm::AttributeKind::NoInline),
                     "Expected __enzyme function to have 'noinline' before adding 'alwaysinline'"
                 );
 
+                // Removing no-inline from function.
+                attributes::remove_from_llfn(function, Function, llvm::AttributeKind::NoInline);
+
                 let attr = llvm::AttributeKind::AlwaysInline.create_attr(cx.llcx);
                 attributes::apply_to_llfn(function, Function, &[attr]);
             }

compiler/rustc_codegen_llvm/src/llvm/ffi.rs

@@ -1160,6 +1160,7 @@ unsafe extern "C" {
 
     pub(crate) fn LLVMGetFirstFunction(M: &Module) -> Option<&Value>;
     pub(crate) fn LLVMGetNextFunction(Fn: &Value) -> Option<&Value>;
+    pub(crate) fn LLVMRemoveEnumAttributeAtIndex(Fn: &Value, index: c_uint, kind: AttributeKind);
 
     pub(crate) fn LLVMDeleteGlobal(GlobalVar: &Value);
     pub(crate) fn LLVMGetInitializer(GlobalVar: &Value) -> Option<&Value>;

compiler/rustc_codegen_llvm/src/llvm/mod.rs

@@ -41,12 +41,14 @@ pub(crate) fn AddFunctionAttributes<'ll>(
     }
 }
 
-pub(crate) fn HasAttributeAtIndex<'ll>(
-    llfn: &'ll Value,
-    idx: AttributePlace,
-    attr: &'ll Attribute,
-) -> bool {
-    unsafe { LLVMRustHasAttributeAtIndex(llfn, idx.as_uint(), attrs.as_ptr()) }
+pub(crate) fn HasAttributeAtIndex<'ll>(llfn: &'ll Value, idx: u32, kind: AttributeKind) -> bool {
+    unsafe { LLVMRustHasAttributeAtIndex(llfn, idx, kind) }
+}
+
+pub(crate) fn RemoveEnumAttributeAtIndex(llfn: &Value, place: AttributePlace, kind: AttributeKind) {
+    unsafe {
+        LLVMRemoveEnumAttributeAtIndex(llfn, place.as_uint(), kind);
+    }
 }
 
 pub(crate) fn AddCallSiteAttributes<'ll>(