rustc: split Generics of a method from its parent Generics.

Author: eddyb

src/librustc/infer/error_reporting.rs

@@ -82,7 +82,6 @@ use hir::def::Def;
 use hir::def_id::DefId;
 use infer::{self, TypeOrigin};
 use middle::region;
-use ty::subst;
 use ty::{self, TyCtxt, TypeFoldable};
 use ty::{Region, ReFree};
 use ty::error::TypeError;
@@ -1369,7 +1368,7 @@ impl<'a, 'gcx, 'tcx> Rebuilder<'a, 'gcx, 'tcx> {
                             let generics = self.tcx.lookup_generics(did);
 
                             let expected =
-                                generics.regions.len(subst::TypeSpace) as u32;
+                                generics.regions.len() as u32;
                             let lifetimes =
                                 path.segments.last().unwrap().parameters.lifetimes();
                             let mut insert = Vec::new();

src/librustc/traits/error_reporting.rs

@@ -271,14 +271,10 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
                 let def = self.tcx.lookup_trait_def(trait_ref.def_id);
                 let trait_str = def.trait_ref.to_string();
                 if let Some(ref istring) = item.value_str() {
-                    let mut generic_map = def.generics.types.iter_enumerated()
-                                             .map(|(param, i, gen)| {
-                                                   (gen.name.as_str().to_string(),
-                                                    trait_ref.substs.types.get(param, i)
-                                                             .to_string())
-                                                  }).collect::<FnvHashMap<String, String>>();
-                    generic_map.insert("Self".to_string(),
-                                       trait_ref.self_ty().to_string());
+                    let generic_map = def.generics.types.iter().map(|param| {
+                        (param.name.as_str().to_string(),
+                         trait_ref.substs.type_for_def(param).to_string())
+                    }).collect::<FnvHashMap<String, String>>();
                     let parser = Parser::new(&istring);
                     let mut errored = false;
                     let err: String = parser.filter_map(|p| {

src/librustc/traits/object_safety.rs

@@ -20,7 +20,6 @@
 use super::elaborate_predicates;
 
 use hir::def_id::DefId;
-use ty::subst;
 use traits;
 use ty::{self, ToPolyTraitRef, Ty, TyCtxt, TypeFoldable};
 use std::rc::Rc;
@@ -266,7 +265,7 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> {
         }
 
         // We can't monomorphize things like `fn foo<A>(...)`.
-        if !method.generics.types.is_empty_in(subst::FnSpace) {
+        if !method.generics.types.is_empty() {
             return Some(MethodViolationCode::Generic);
         }
 

src/librustc/ty/mod.rs

@@ -757,33 +757,14 @@ impl RegionParameterDef {
 /// with an item or method. Analogous to hir::Generics.
 #[derive(Clone, Debug)]
 pub struct Generics<'tcx> {
-    pub types: VecPerParamSpace<TypeParameterDef<'tcx>>,
-    pub regions: VecPerParamSpace<RegionParameterDef>,
+    pub parent: Option<DefId>,
+    pub parent_regions: u32,
+    pub parent_types: u32,
+    pub regions: Vec<RegionParameterDef>,
+    pub types: Vec<TypeParameterDef<'tcx>>,
     pub has_self: bool,
 }
 
-impl<'tcx> Generics<'tcx> {
-    pub fn empty() -> Generics<'tcx> {
-        Generics {
-            types: VecPerParamSpace::empty(),
-            regions: VecPerParamSpace::empty(),
-            has_self: false,
-        }
-    }
-
-    pub fn is_empty(&self) -> bool {
-        self.types.is_empty() && self.regions.is_empty()
-    }
-
-    pub fn has_type_params(&self, space: subst::ParamSpace) -> bool {
-        !self.types.is_empty_in(space)
-    }
-
-    pub fn has_region_params(&self, space: subst::ParamSpace) -> bool {
-        !self.regions.is_empty_in(space)
-    }
-}
-
 /// Bounds on generics.
 #[derive(Clone)]
 pub struct GenericPredicates<'tcx> {

src/librustc/ty/structural_impls.rs

@@ -832,20 +832,6 @@ impl<'tcx> TypeFoldable<'tcx> for ty::RegionParameterDef {
     }
 }
 
-impl<'tcx> TypeFoldable<'tcx> for ty::Generics<'tcx> {
-    fn super_fold_with<'gcx: 'tcx, F: TypeFolder<'gcx, 'tcx>>(&self, folder: &mut F) -> Self {
-        ty::Generics {
-            types: self.types.fold_with(folder),
-            regions: self.regions.fold_with(folder),
-            has_self: self.has_self
-        }
-    }
-
-    fn super_visit_with<V: TypeVisitor<'tcx>>(&self, visitor: &mut V) -> bool {
-        self.types.visit_with(visitor) || self.regions.visit_with(visitor)
-    }
-}
-
 impl<'tcx> TypeFoldable<'tcx> for ty::GenericPredicates<'tcx> {
     fn super_fold_with<'gcx: 'tcx, F: TypeFolder<'gcx, 'tcx>>(&self, folder: &mut F) -> Self {
         ty::GenericPredicates {

src/librustc/ty/subst.rs

@@ -89,42 +89,55 @@ impl<'a, 'gcx, 'tcx> Substs<'tcx> {
     where FR: FnMut(&ty::RegionParameterDef, &Substs<'tcx>) -> ty::Region,
           FT: FnMut(&ty::TypeParameterDef<'tcx>, &Substs<'tcx>) -> Ty<'tcx> {
         let defs = tcx.lookup_generics(def_id);
+        let num_regions = defs.parent_regions as usize + defs.regions.len();
+        let num_types = defs.parent_types as usize + defs.types.len();
         let mut substs = Substs {
-            types: VecPerParamSpace {
+            regions: VecPerParamSpace {
                 type_limit: 0,
-                content: Vec::with_capacity(defs.types.content.len())
+                content: Vec::with_capacity(num_regions)
             },
-            regions: VecPerParamSpace {
+            types: VecPerParamSpace {
                 type_limit: 0,
-                content: Vec::with_capacity(defs.regions.content.len())
+                content: Vec::with_capacity(num_types)
             }
         };
 
-        for &space in &ParamSpace::all() {
-            for def in defs.regions.get_slice(space) {
-                assert_eq!(def.space, space);
-
-                let region = mk_region(def, &substs);
-                substs.regions.content.push(region);
+        substs.fill_item(tcx, defs, &mut mk_region, &mut mk_type);
 
-                if space == TypeSpace {
-                    substs.regions.type_limit += 1;
-                }
-            }
+        Substs::new(tcx, substs.types, substs.regions)
+    }
 
-            for def in defs.types.get_slice(space) {
-                assert_eq!(def.space, space);
+    fn fill_item<FR, FT>(&mut self,
+                         tcx: TyCtxt<'a, 'gcx, 'tcx>,
+                         defs: &ty::Generics<'tcx>,
+                         mk_region: &mut FR,
+                         mk_type: &mut FT)
+    where FR: FnMut(&ty::RegionParameterDef, &Substs<'tcx>) -> ty::Region,
+          FT: FnMut(&ty::TypeParameterDef<'tcx>, &Substs<'tcx>) -> Ty<'tcx> {
+        if let Some(def_id) = defs.parent {
+            let parent_defs = tcx.lookup_generics(def_id);
+            self.fill_item(tcx, parent_defs, mk_region, mk_type);
+        }
 
-                let ty = mk_type(def, &substs);
-                substs.types.content.push(ty);
+        for def in &defs.regions {
+            let region = mk_region(def, self);
+            self.regions.content.push(region);
 
-                if space == TypeSpace {
-                    substs.types.type_limit += 1;
-                }
+            if def.space == TypeSpace {
+                self.regions.type_limit += 1;
+                assert_eq!(self.regions.content.len(), self.regions.type_limit);
             }
         }
 
-        Substs::new(tcx, substs.types, substs.regions)
+        for def in &defs.types {
+            let ty = mk_type(def, self);
+            self.types.content.push(ty);
+
+            if def.space == TypeSpace {
+                self.types.type_limit += 1;
+                assert_eq!(self.types.content.len(), self.types.type_limit);
+            }
+        }
     }
 
     pub fn is_noop(&self) -> bool {
@@ -149,16 +162,14 @@ impl<'a, 'gcx, 'tcx> Substs<'tcx> {
                        target_substs: &Substs<'tcx>)
                        -> &'tcx Substs<'tcx> {
         let defs = tcx.lookup_generics(source_ancestor);
-        assert_eq!(self.types.len(TypeSpace), defs.types.len(TypeSpace));
+        assert_eq!(self.types.len(TypeSpace), defs.types.len());
         assert_eq!(target_substs.types.len(FnSpace), 0);
-        assert_eq!(defs.types.len(FnSpace), 0);
-        assert_eq!(self.regions.len(TypeSpace), defs.regions.len(TypeSpace));
+        assert_eq!(self.regions.len(TypeSpace), defs.regions.len());
         assert_eq!(target_substs.regions.len(FnSpace), 0);
-        assert_eq!(defs.regions.len(FnSpace), 0);
 
         let Substs { mut types, mut regions } = target_substs.clone();
-        types.content.extend(&self.types.as_full_slice()[defs.types.content.len()..]);
-        regions.content.extend(&self.regions.as_full_slice()[defs.regions.content.len()..]);
+        types.content.extend(&self.types.as_full_slice()[defs.types.len()..]);
+        regions.content.extend(&self.regions.as_full_slice()[defs.regions.len()..]);
         Substs::new(tcx, types, regions)
     }
 }
@@ -597,8 +608,8 @@ impl<'a, 'gcx, 'tcx> ty::TraitRef<'tcx> {
                        -> ty::TraitRef<'tcx> {
         let Substs { mut types, mut regions } = substs.clone();
         let defs = tcx.lookup_generics(trait_id);
-        types.content.truncate(defs.types.type_limit);
-        regions.content.truncate(defs.regions.type_limit);
+        types.content.truncate(defs.types.len());
+        regions.content.truncate(defs.regions.len());
 
         ty::TraitRef {
             def_id: trait_id,

src/librustc/util/ppaux.rs

@@ -73,13 +73,15 @@ pub fn parameterized(f: &mut fmt::Formatter,
     let mut has_self = false;
     let (fn_trait_kind, item_name) = ty::tls::with(|tcx| {
         verbose = tcx.sess.verbose();
-        let generics = tcx.lookup_generics(did);
+        let mut generics = tcx.lookup_generics(did);
+        if let Some(def_id) = generics.parent {
+            generics = tcx.lookup_generics(def_id);
+        }
         if !verbose {
-            let ty_params = generics.types.get_slice(subst::TypeSpace);
-            if ty_params.last().map_or(false, |def| def.default.is_some()) {
+            if generics.types.last().map_or(false, |def| def.default.is_some()) {
                 if let Some(substs) = tcx.lift(&substs) {
                     let tps = substs.types.get_slice(subst::TypeSpace);
-                    for (def, actual) in ty_params.iter().zip(tps).rev() {
+                    for (def, actual) in generics.types.iter().zip(tps).rev() {
                         if def.default.subst(tcx, substs) != Some(actual) {
                             break;
                         }

src/librustc_metadata/encoder.rs

@@ -620,9 +620,9 @@ fn encode_info_for_method<'a, 'tcx>(ecx: &EncodeContext<'a, 'tcx>,
     if let Some(impl_item) = impl_item_opt {
         if let hir::ImplItemKind::Method(ref sig, _) = impl_item.node {
             encode_attributes(rbml_w, &impl_item.attrs);
-            let scheme = ecx.tcx.lookup_item_type(m.def_id);
-            let any_types = !scheme.generics.types.is_empty();
-            let needs_inline = any_types || is_default_impl ||
+            let generics = ecx.tcx.lookup_generics(m.def_id);
+            let types = generics.parent_types as usize + generics.types.len();
+            let needs_inline = types > 0 || is_default_impl ||
                                attr::requests_inline(&impl_item.attrs);
             if needs_inline || sig.constness == hir::Constness::Const {
                 encode_inlined_item(ecx,

src/librustc_metadata/tydecode.rs

@@ -149,9 +149,29 @@ impl<'a,'tcx> TyDecoder<'a,'tcx> {
     }
 
     pub fn parse_generics(&mut self) -> &'tcx ty::Generics<'tcx> {
-        let regions = self.parse_vec_per_param_space(|this| this.parse_region_param_def());
-        let types = self.parse_vec_per_param_space(|this| this.parse_type_param_def());
+        let parent = self.parse_opt(|this| this.parse_def());
+        let parent_regions = self.parse_u32();
+        assert_eq!(self.next(), '|');
+        let parent_types = self.parse_u32();
+
+        let mut regions = vec![];
+        assert_eq!(self.next(), '[');
+        while self.peek() != ']' {
+            regions.push(self.parse_region_param_def());
+        }
+        assert_eq!(self.next(), ']');
+
+        let mut types = vec![];
+        assert_eq!(self.next(), '[');
+        while self.peek() != ']' {
+            types.push(self.parse_type_param_def());
+        }
+        assert_eq!(self.next(), ']');
+
         self.tcx.alloc_generics(ty::Generics {
+            parent: parent,
+            parent_regions: parent_regions,
+            parent_types: parent_types,
             regions: regions,
             types: types,
             has_self: self.next() == 'S'

src/librustc_metadata/tyencode.rs

@@ -274,10 +274,21 @@ pub fn enc_substs<'a, 'tcx>(w: &mut Cursor<Vec<u8>>, cx: &ctxt<'a, 'tcx>,
 
 pub fn enc_generics<'a, 'tcx>(w: &mut Cursor<Vec<u8>>, cx: &ctxt<'a, 'tcx>,
                               generics: &ty::Generics<'tcx>) {
-    enc_vec_per_param_space(w, cx, &generics.regions,
-                            |w, cx, r| enc_region_param_def(w, cx, r));
-    enc_vec_per_param_space(w, cx, &generics.types,
-                            |w, cx, ty| enc_type_param_def(w, cx, ty));
+    enc_opt(w, generics.parent, |w, def_id| {
+        write!(w, "{}|", (cx.ds)(cx.tcx, def_id));
+    });
+    write!(w, "{}|{}[",
+           generics.parent_regions,
+           generics.parent_types);
+
+    for r in &generics.regions {
+        enc_region_param_def(w, cx, r)
+    }
+    write!(w, "][");
+    for t in &generics.types {
+        enc_type_param_def(w, cx, t);
+    }
+    write!(w, "]");
 
     if generics.has_self {
         write!(w, "S");