Feed visibilities for trait impl items as well

Author: petrochenkov

compiler/rustc_privacy/src/lib.rs

@@ -1816,23 +1816,6 @@ fn local_visibility(tcx: TyCtxt<'_>, def_id: LocalDefId) -> ty::Visibility {
                 | hir::ItemKind::OpaqueTy(..),
             ..
         }) => ty::Visibility::Restricted(tcx.parent_module(hir_id).to_local_def_id()),
-        // Visibilities of trait impl items are inherited from their traits
-        // and are not filled in resolve.
-        Node::ImplItem(impl_item) => {
-            match tcx.hir().get_by_def_id(tcx.hir().get_parent_item(hir_id).def_id) {
-                Node::Item(hir::Item {
-                    kind: hir::ItemKind::Impl(hir::Impl { of_trait: Some(tr), .. }),
-                    ..
-                }) => tr.path.res.opt_def_id().map_or_else(
-                    || {
-                        tcx.sess.span_delayed_bug(tr.path.span, "trait without a def-id");
-                        ty::Visibility::Public
-                    },
-                    |def_id| tcx.visibility(def_id).expect_local(),
-                ),
-                _ => span_bug!(impl_item.span, "the parent is not a trait impl"),
-            }
-        }
         _ => span_bug!(
             tcx.def_span(def_id),
             "visibility table unexpectedly missing a def-id: {:?}",

compiler/rustc_resolve/src/late.rs

@@ -3108,6 +3108,8 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
             | (DefKind::AssocFn, AssocItemKind::Fn(..))
             | (DefKind::AssocConst, AssocItemKind::Const(..)) => {
                 self.r.record_partial_res(id, PartialRes::new(res));
+                let vis = self.r.tcx.visibility(id_in_trait).expect_local();
+                self.r.feed_visibility(self.r.local_def_id(id), vis);
                 return;
             }
             _ => {}