review comments: inline bindings and fix typo

Author: estebank

compiler/rustc_borrowck/src/diagnostics/conflict_errors.rs

@@ -721,11 +721,15 @@ impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> {
         let tcx = self.infcx.tcx;
         // Try to find predicates on *generic params* that would allow copying `ty`
         let infcx = tcx.infer_ctxt().build();
-        let clone_did = tcx.lang_items().clone_trait().unwrap();
-        let params = ty::List::empty();
-        let ty = tcx.erase_regions(ty);
-        let env = self.param_env;
-        if infcx.type_implements_trait(clone_did, ty, params, env).must_apply_modulo_regions() {
+        if infcx
+            .type_implements_trait(
+                tcx.lang_items().clone_trait().unwrap(),
+                tcx.erase_regions(ty),
+                ty::List::empty(),
+                self.param_env,
+            )
+            .must_apply_modulo_regions()
+        {
             err.span_suggestion_verbose(
                 span.shrink_to_hi(),
                 "consider cloning the value if the performance cost is acceptable",

src/test/ui/borrowck/borrowck-consume-unsize-vec.stderr

@@ -8,7 +8,7 @@ LL |     consume(b);
 LL |     consume(b);
    |             ^ value used here after move
    |
-note: consider changing this parameter type in function `consume` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `consume` to borrow instead if owning the value isn't necessary
   --> $DIR/borrowck-consume-unsize-vec.rs:3:15
    |
 LL | fn consume(_: Box<[i32]>) {

src/test/ui/borrowck/borrowck-consume-upcast-box.stderr

@@ -8,7 +8,7 @@ LL |     consume(b);
 LL |     consume(b);
    |             ^ value used here after move
    |
-note: consider changing this parameter type in function `consume` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `consume` to borrow instead if owning the value isn't necessary
   --> $DIR/borrowck-consume-upcast-box.rs:5:15
    |
 LL | fn consume(_: Box<dyn Foo>) {

src/test/ui/borrowck/mut-borrow-in-loop-2.stderr

@@ -8,7 +8,7 @@ LL |     for _ in 0..3 {
 LL |         Other::handle(value);
    |                       ^^^^^ value moved here, in previous iteration of loop
    |
-note: consider changing this parameter type in function `handle` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `handle` to borrow instead if owning the value isn't necessary
   --> $DIR/mut-borrow-in-loop-2.rs:9:22
    |
 LL |     fn handle(value: T) -> Self;

src/test/ui/liveness/liveness-move-call-arg.stderr

@@ -9,7 +9,7 @@ LL |     loop {
 LL |         take(x);
    |              ^ value moved here, in previous iteration of loop
    |
-note: consider changing this parameter type in function `take` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `take` to borrow instead if owning the value isn't necessary
   --> $DIR/liveness-move-call-arg.rs:1:13
    |
 LL | fn take(_x: Box<isize>) {}

src/test/ui/liveness/liveness-use-after-send.stderr

@@ -8,7 +8,7 @@ LL |     send(ch, message);
 LL |     println!("{}", message);
    |                    ^^^^^^^ value borrowed here after move
    |
-note: consider changing this parameter type in function `send` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `send` to borrow instead if owning the value isn't necessary
   --> $DIR/liveness-use-after-send.rs:3:54
    |
 LL | fn send<T:Send + std::fmt::Debug>(ch: Chan<T>, data: T) {

src/test/ui/moves/borrow-closures-instead-of-move.stderr

@@ -8,7 +8,7 @@ LL |     loop {
 LL |         takes_fnonce(f);
    |                      ^ value moved here, in previous iteration of loop
    |
-note: consider changing this parameter type in function `takes_fnonce` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `takes_fnonce` to borrow instead if owning the value isn't necessary
   --> $DIR/borrow-closures-instead-of-move.rs:34:20
    |
 LL | fn takes_fnonce(_: impl FnOnce()) {}
@@ -32,7 +32,7 @@ LL |         takes_fnonce(m);
 LL |     takes_fnonce(m);
    |                  ^ value used here after move
    |
-note: consider changing this parameter type in function `takes_fnonce` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `takes_fnonce` to borrow instead if owning the value isn't necessary
   --> $DIR/borrow-closures-instead-of-move.rs:34:20
    |
 LL | fn takes_fnonce(_: impl FnOnce()) {}
@@ -58,7 +58,7 @@ note: closure cannot be moved more than once as it is not `Copy` due to moving t
    |
 LL |         x += 1;
    |         ^
-note: consider changing this parameter type in function `takes_fnonce` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `takes_fnonce` to borrow instead if owning the value isn't necessary
   --> $DIR/borrow-closures-instead-of-move.rs:34:20
    |
 LL | fn takes_fnonce(_: impl FnOnce()) {}

src/test/ui/moves/move-guard-same-consts.stderr

@@ -9,7 +9,7 @@ LL |         (1, 2) if take(x) => (),
 LL |         (1, 2) if take(x) => (),
    |                        ^ value used here after move
    |
-note: consider changing this parameter type in function `take` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `take` to borrow instead if owning the value isn't necessary
   --> $DIR/move-guard-same-consts.rs:25:15
    |
 LL | fn take<T>(_: T) -> bool { false }

src/test/ui/moves/move-in-guard-1.stderr

@@ -9,7 +9,7 @@ LL |         (1, _) if take(x) => (),
 LL |         (_, 2) if take(x) => (),
    |                        ^ value used here after move
    |
-note: consider changing this parameter type in function `take` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `take` to borrow instead if owning the value isn't necessary
   --> $DIR/move-in-guard-1.rs:15:15
    |
 LL | fn take<T>(_: T) -> bool { false }

src/test/ui/moves/move-in-guard-2.stderr

@@ -7,7 +7,7 @@ LL |     let x: Box<_> = Box::new(1);
 LL |         (_, 2) if take(x) => (),
    |                        ^ value used here after move
    |
-note: consider changing this parameter type in function `take` to borrow instead if ownering the value isn't necessary
+note: consider changing this parameter type in function `take` to borrow instead if owning the value isn't necessary
   --> $DIR/move-in-guard-2.rs:13:15
    |
 LL | fn take<T>(_: T) -> bool { false }