add error message for unused duplicate

Author: jdonszelmann

compiler/rustc_ast_lowering/src/expr.rs

@@ -74,15 +74,12 @@ impl<'hir> LoweringContext<'_, 'hir> {
                     // Merge attributes into the inner expression.
                     if !e.attrs.is_empty() {
                         let old_attrs = self.attrs.get(&ex.hir_id.local_id).copied().unwrap_or(&[]);
-                        let new_attrs = self.lower_attrs_vec(&e.attrs, e.span, ex.hir_id)
-                                    .into_iter()
-                                    .chain(old_attrs.iter().cloned());
-                        self.attrs.insert(
-                            ex.hir_id.local_id,
-                            &*self.arena.alloc_from_iter(
-                                new_attrs,
-                            ),
-                        );
+                        let new_attrs = self
+                            .lower_attrs_vec(&e.attrs, e.span, ex.hir_id)
+                            .into_iter()
+                            .chain(old_attrs.iter().cloned());
+                        self.attrs
+                            .insert(ex.hir_id.local_id, &*self.arena.alloc_from_iter(new_attrs));
                     }
                     return ex;
                 }

compiler/rustc_ast_lowering/src/item.rs

@@ -58,7 +58,7 @@ impl<'a, 'hir> ItemLowerer<'a, 'hir> {
         &mut self,
         owner: NodeId,
         f: impl FnOnce(&mut LoweringContext<'_, 'hir>) -> hir::OwnerNode<'hir>,
-    )  {
+    ) {
         let mut lctx = LoweringContext::new(self.tcx, self.resolver);
         lctx.with_hir_id_owner(owner, |lctx| f(lctx));
 

compiler/rustc_ast_lowering/src/lib.rs

@@ -52,7 +52,7 @@ use rustc_data_structures::stable_hasher::{HashStable, StableHasher};
 use rustc_data_structures::tagged_ptr::TaggedRef;
 use rustc_errors::{DiagArgFromDisplay, DiagCtxtHandle, StashKey};
 use rustc_hir::def::{DefKind, LifetimeRes, Namespace, PartialRes, PerNS, Res};
-use rustc_hir::def_id::{LocalDefId, CRATE_DEF_ID, LOCAL_CRATE};
+use rustc_hir::def_id::{CRATE_DEF_ID, LOCAL_CRATE, LocalDefId};
 use rustc_hir::{
     self as hir, ConstArg, GenericArg, HirId, ItemLocalMap, LangItem, ParamName, TraitCandidate,
 };

compiler/rustc_attr_parsing/messages.ftl

@@ -135,9 +135,7 @@ attr_parsing_unused_duplicate =
     unused attribute
     .suggestion = remove this attribute
     .note = attribute also specified here
-    .warn = {-attr_parsing_previously_accepted}
-
-
+    .warn = {-passes_previously_accepted}
 attr_parsing_unused_multiple =
     multiple `{$name}` attributes
     .suggestion = remove this attribute

compiler/rustc_attr_parsing/src/context.rs

@@ -195,9 +195,7 @@ impl Stage for Late {
         diag: impl DynSend + for<'x> LintDiagnostic<'x, ()> + 'static,
     ) {
         println!("stashing lint");
-        dcx.delay_lint_during_ast_lowering((lint, id, span, Box::new(|x| {
-            diag.decorate_lint(x)
-        })));
+        dcx.delay_lint_during_ast_lowering((lint, id, span, Box::new(|x| diag.decorate_lint(x))));
     }
 }
 
@@ -221,7 +219,7 @@ impl<'f, 'sess: 'f, S: Stage> AcceptContext<'f, 'sess, S> {
     }
 
     pub(crate) fn emit_lint(
-        & self,
+        &self,
         lint: &'static Lint,
         span: Span,
         diag: impl DynSend + for<'x> LintDiagnostic<'x, ()> + 'static,
@@ -316,12 +314,12 @@ impl<'sess> AttributeParser<'sess, Early> {
     ) -> Option<Attribute> {
         let mut p = Self { features: None, tools: Vec::new(), parse_only: Some(sym), sess };
         let mut parsed = p.parse_attribute_list(
-                attrs,
-                target_span,
-                target_node_id,
-                OmitDoc::Skip,
-                std::convert::identity,
-            );
+            attrs,
+            target_span,
+            target_node_id,
+            OmitDoc::Skip,
+            std::convert::identity,
+        );
         assert!(parsed.len() <= 1);
 
         parsed.pop()

compiler/rustc_attr_parsing/src/session_diagnostics.rs

@@ -452,7 +452,7 @@ pub(crate) struct UnusedMultiple {
 }
 
 #[derive(LintDiagnostic)]
-#[diag(attr_parsing_unused_multiple)]
+#[diag(attr_parsing_unused_duplicate)]
 pub(crate) struct UnusedDuplicate {
     #[suggestion(code = "", applicability = "machine-applicable")]
     pub this: Span,

compiler/rustc_errors/src/lib.rs

@@ -54,8 +54,6 @@ pub use diagnostic_impls::{
     DiagArgFromDisplay, DiagSymbolList, ElidedLifetimeInPathSubdiag, ExpectedLifetimeParameter,
     IndicateAnonymousLifetime, SingleLabelManySpans,
 };
-use rustc_lint_defs::Lint;
-use rustc_hir::HirId;
 pub use emitter::ColorConfig;
 use emitter::{DynEmitter, Emitter, is_case_difference, is_different};
 use rustc_data_structures::AtomicRef;
@@ -67,8 +65,9 @@ pub use rustc_error_messages::{
     SubdiagMessage, fallback_fluent_bundle, fluent_bundle,
 };
 use rustc_hashes::Hash128;
-use rustc_lint_defs::LintExpectationId;
+use rustc_hir::HirId;
 pub use rustc_lint_defs::{Applicability, listify, pluralize};
+use rustc_lint_defs::{Lint, LintExpectationId};
 use rustc_macros::{Decodable, Encodable};
 pub use rustc_span::ErrorGuaranteed;
 pub use rustc_span::fatal_error::{FatalError, FatalErrorMarker};
@@ -543,7 +542,7 @@ pub type HirDelayedLint = (
     &'static Lint,
     HirId,
     Span,
-    Box<dyn DynSend + for<'a, 'b> FnOnce(&'b mut Diag<'a, ()>) + 'static>
+    Box<dyn DynSend + for<'a, 'b> FnOnce(&'b mut Diag<'a, ()>) + 'static>,
 );
 
 /// This inner struct exists to keep it all behind a single lock;