wip

Author: JonathanBrouwer

compiler/rustc_attr_parsing/src/attributes/deprecation.rs

@@ -58,7 +58,7 @@ impl<S: Stage> SingleAttributeParser<S> for DeprecationParser {
         Allow(Target::AssocTy),
         Allow(Target::AssocConst),
         Allow(Target::Variant),
-        Allow(Target::Impl { of_trait: false }), //TODO what does that even do?
+        Allow(Target::Impl { of_trait: false }), //FIXME This does not make sense
         Error(Target::WherePredicate),
     ]);
     const TEMPLATE: AttributeTemplate = template!(

compiler/rustc_attr_parsing/src/attributes/link_attrs.rs

@@ -71,7 +71,7 @@ pub(crate) struct ExportStableParser;
 impl<S: Stage> NoArgsAttributeParser<S> for ExportStableParser {
     const PATH: &[Symbol] = &[sym::export_stable];
     const ON_DUPLICATE: OnDuplicate<S> = OnDuplicate::Warn;
-    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowAll; //TODO
+    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowAll; //FIXME Still checked fully in `check_attr.rs`
     const CREATE: fn(Span) -> AttributeKind = |_| AttributeKind::ExportStable;
 }
 

compiler/rustc_attr_parsing/src/attributes/repr.rs

@@ -60,7 +60,8 @@ impl<S: Stage> CombineAttributeParser<S> for ReprParser {
         reprs
     }
 
-    //TODO should be done here in the future, argument-dependent
+    //FIXME Still checked fully in `check_attr.rs`
+    //This one is slightly more complicated because the allowed targets depend on the arguments
     const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowAll;
 }
 
@@ -327,7 +328,6 @@ impl<S: Stage> AttributeParser<S> for AlignParser {
         Allow(Target::Method(MethodKind::TraitImpl)),
         Allow(Target::Method(MethodKind::Trait { body: false })),
         Allow(Target::ForeignFn),
-        // TODO special error for struct,enum,union
     ]);
 
     fn finalize(self, _cx: &FinalizeContext<'_, '_, S>) -> Option<AttributeKind> {

compiler/rustc_attr_parsing/src/attributes/semantics.rs

@@ -7,6 +7,6 @@ pub(crate) struct MayDangleParser;
 impl<S: Stage> NoArgsAttributeParser<S> for MayDangleParser {
     const PATH: &[Symbol] = &[sym::may_dangle];
     const ON_DUPLICATE: OnDuplicate<S> = OnDuplicate::Warn;
-    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowAll; //TODO
+    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowAll; //FIXME Still checked fully in `check_attr.rs`
     const CREATE: fn(span: Span) -> AttributeKind = AttributeKind::MayDangle;
 }

compiler/rustc_attr_parsing/src/attributes/stability.rs

@@ -41,7 +41,7 @@ const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowList(&[
     Allow(Target::MacroDef),
     Allow(Target::Crate),
     Allow(Target::Mod),
-    Allow(Target::Use), // TODO I don't think this does anything?
+    Allow(Target::Use), // FIXME I don't think this does anything?
     Allow(Target::Const),
     Allow(Target::AssocConst),
     Allow(Target::AssocTy),

compiler/rustc_attr_parsing/src/attributes/traits.rs

@@ -172,6 +172,6 @@ pub(crate) struct PointeeParser;
 impl<S: Stage> NoArgsAttributeParser<S> for PointeeParser {
     const PATH: &[Symbol] = &[sym::pointee];
     const ON_DUPLICATE: OnDuplicate<S> = OnDuplicate::Error;
-    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowAll; //TODO
+    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowAll; //FIXME Still checked fully in `check_attr.rs`
     const CREATE: fn(Span) -> AttributeKind = AttributeKind::Pointee;
 }

compiler/rustc_passes/src/check_attr.rs

@@ -220,7 +220,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
                     | AttributeKind::ParenSugar(..)
                     | AttributeKind::AllowIncoherentImpl(..)
                     | AttributeKind::Confusables { .. }
-                    // #[doc]` is actually a lot more than just doc comments, so is checked below
+                    // `#[doc]` is actually a lot more than just doc comments, so is checked below
                     | AttributeKind::DocComment {..}
                     // handled below this loop and elsewhere
                     | AttributeKind::Repr { .. }