Improve code of run-make/llvm-ident

Author: GuillaumeGomez

tests/run-make/llvm-ident/rmake.rs

@@ -2,7 +2,9 @@
 //@ ignore-cross-compile
 
 use run_make_support::llvm::llvm_bin_dir;
-use run_make_support::{cmd, env_var, llvm_filecheck, read_dir, rustc, source_root};
+use run_make_support::{
+    cmd, env_var, get_files_with_extension, llvm_filecheck, rustc, source_root,
+};
 
 use std::ffi::OsStr;
 
@@ -22,20 +24,12 @@ fn main() {
 
     // `llvm-dis` is used here since `--emit=llvm-ir` does not emit LLVM IR
     // for temporary outputs.
-    let mut files = Vec::new();
-    read_dir(".", |path| {
-        if path.is_file() && path.extension().is_some_and(|ext| ext == OsStr::new("bc")) {
-            files.push(path.to_path_buf());
-        }
-    });
-    cmd(llvm_bin_dir().join("llvm-dis")).args(&files).run();
+    cmd(llvm_bin_dir().join("llvm-dis")).args(get_files_with_extension(".", "bc")).run();
 
     // Check LLVM IR files (including temporary outputs) have `!llvm.ident`
     // named metadata, reusing the related codegen test.
     let llvm_ident_path = source_root().join("tests/codegen/llvm-ident.rs");
-    read_dir(".", |path| {
-        if path.is_file() && path.extension().is_some_and(|ext| ext == OsStr::new("ll")) {
-            llvm_filecheck().input_file(path).arg(&llvm_ident_path).run();
-        }
-    });
+    for file in get_files_with_extension(".", "ll") {
+        llvm_filecheck().input_file(file).arg(&llvm_ident_path).run();
+    }
 }