No longer treat pointee as a builtin attribute

Also includes a drive-by typo fix

Author: Brezak

compiler/rustc_feature/src/builtin_attrs.rs

@@ -578,12 +578,6 @@ pub const BUILTIN_ATTRIBUTES: &[BuiltinAttribute] = &[
         EncodeCrossCrate::No, coroutines, experimental!(coroutines)
     ),
 
-    // `#[pointee]` attribute to designate the pointee type in SmartPointer derive-macro
-    gated!(
-        pointee, Normal, template!(Word), ErrorFollowing,
-        EncodeCrossCrate::No, derive_smart_pointer, experimental!(pointee)
-    ),
-
     // RFC 3543
     // `#[patchable_function_entry(prefix_nops = m, entry_nops = n)]`
     gated!(

compiler/rustc_passes/messages.ftl

@@ -584,10 +584,6 @@ passes_pass_by_value =
     `pass_by_value` attribute should be applied to a struct, enum or type alias
     .label = is not a struct, enum or type alias
 
-passes_pointee_on_non_generic_ty =
-    attribute should be applied to generic type parameters
-    .label = not a generic type parameter
-
 passes_proc_macro_bad_sig = {$kind} has incorrect signature
 
 passes_remove_fields =

compiler/rustc_passes/src/check_attr.rs

@@ -242,9 +242,6 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
                 [sym::coroutine, ..] => {
                     self.check_coroutine(attr, target);
                 }
-                [sym::pointee, ..] => {
-                    self.check_pointee(attr, target);
-                }
                 [
                     // ok
                     sym::allow
@@ -2345,15 +2342,6 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
             }
         }
     }
-
-    fn check_pointee(&self, attr: &Attribute, target: Target) {
-        match target {
-            Target::GenericParam(hir::target::GenericParamKind::Type) => return,
-            _ => {
-                self.dcx().emit_err(errors::PointeeOnNonGenericTy { attr_span: attr.span });
-            }
-        }
-    }
 }
 
 impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {

compiler/rustc_passes/src/errors.rs

@@ -643,13 +643,6 @@ pub struct CoroutineOnNonClosure {
     pub span: Span,
 }
 
-#[derive(Diagnostic)]
-#[diag(passes_pointee_on_non_generic_ty)]
-pub struct PointeeOnNonGenericTy {
-    #[primary_span]
-    pub attr_span: Span,
-}
-
 #[derive(Diagnostic)]
 #[diag(passes_empty_confusables)]
 pub(crate) struct EmptyConfusables {

compiler/rustc_resolve/src/ident.rs

@@ -441,7 +441,7 @@ impl<'a, 'tcx> Resolver<'a, 'tcx> {
                         }
                     }
                     Scope::DeriveHelpersCompat => {
-                        // FIXME: Try running this logic eariler, to allocate name bindings for
+                        // FIXME: Try running this logic earlier, to allocate name bindings for
                         // legacy derive helpers when creating an attribute invocation with
                         // following derives. Legacy derive helpers are not common, so it shouldn't
                         // affect performance. It should also allow to remove the `derives`