Address comments

Author: Zoxc

compiler/rustc_codegen_cranelift/src/driver/aot.rs

@@ -732,21 +732,14 @@ pub(crate) fn run_aot(
         tcx.sess.time("codegen mono items", || {
             let modules: Vec<_> = par_map(todo_cgus, |(_, cgu)| {
                 let dep_node = cgu.codegen_dep_node(tcx);
-                IntoDynSyncSend(
-                    tcx.dep_graph
-                        .with_task(
-                            dep_node,
-                            tcx,
-                            (
-                                global_asm_config.clone(),
-                                cgu.name(),
-                                concurrency_limiter.acquire(tcx.dcx()),
-                            ),
-                            module_codegen,
-                            Some(rustc_middle::dep_graph::hash_result),
-                        )
-                        .0,
-                )
+                let (module, _) = tcx.dep_graph.with_task(
+                    dep_node,
+                    tcx,
+                    (global_asm_config.clone(), cgu.name(), concurrency_limiter.acquire(tcx.dcx())),
+                    module_codegen,
+                    Some(rustc_middle::dep_graph::hash_result),
+                );
+                IntoDynSyncSend(module)
             });
             modules
                 .into_iter()

compiler/rustc_data_structures/src/sync/parallel.rs

@@ -175,6 +175,10 @@ pub fn par_for_each_in<I: DynSend, T: IntoIterator<Item = I>>(
     });
 }
 
+/// This runs `for_each` in parallel for each iterator item. If one or more of the
+/// `for_each` calls returns `Err`, the function will also return `Err`. The error returned
+/// will be non-deterministic, but this is expected to be used with `ErrorGuaranteed` which
+/// are all equivalent.
 pub fn try_par_for_each_in<T: IntoIterator, E: DynSend>(
     t: T,
     for_each: impl Fn(&<T as IntoIterator>::Item) -> Result<(), E> + DynSync + DynSend,