rustdoc: fix colors for top buttons and search

Make sure the top buttons and search have the same border color and the
same color for the icon inside.

Author: jsha

src/librustdoc/html/static/css/rustdoc.css

@@ -902,7 +902,6 @@ table,
 	margin-left: 0.25em;
 	padding-left: 0.3125em;
 	padding-right: 23px;
-	border: 0;
 	border-radius: 4px;
 	outline: none;
 	cursor: pointer;

src/librustdoc/html/static/css/themes/ayu.css

@@ -234,14 +234,19 @@ details.undocumented > summary::before {
 	filter: invert(100%);
 }
 
-#crate-search, .search-input {
+#theme-picker, #settings-menu, #help-button,
+#crate-search, .search-input, .search-input::placeholder {
 	background-color: #141920;
 	border-color: #424c57;
-	color: #c5c5c5;
+	color: grey;
+}
+
+#crate-search {
+	color: white;
 }
 
 .search-input {
-	color: #ffffff;
+	color: white;
 }
 
 .module-item .stab,
@@ -531,16 +536,14 @@ kbd {
 	box-shadow: inset 0 -1px 0 #5c6773;
 }
 
-#theme-picker, #settings-menu, #help-button {
-	border-color: #5c6773;
-	background-color: #0f1419;
-	color: #fff;
-}
-
 #theme-picker > img, #settings-menu > img {
 	filter: invert(100);
 }
 
+.sub-container img {
+	opacity: 50%;
+}
+
 #copy-path {
 	color: #fff;
 }

src/librustdoc/html/static/css/themes/dark.css

@@ -214,14 +214,23 @@ details.undocumented > summary::before {
 	filter: invert(100%);
 }
 
-#crate-search, .search-input {
-	color: #111;
-	background-color: #f0f0f0;
-	border-color: #000;
+#theme-picker, #settings-menu, #help-button,
+#crate-search, .search-input, .search-input::placeholder {
+	color: grey;
+	background-color: #353535;
+	border-color: #505050;
+}
+
+#theme-picker > img, #settings-menu > img {
+	filter: invert(50%);
+}
+
+#crate-search {
+	color: white;
 }
 
 .search-input {
-	border-color: #e0e0e0;
+	color: white;
 }
 
 .search-input:focus {
@@ -408,12 +417,6 @@ kbd {
 	box-shadow: inset 0 -1px 0 #c6cbd1;
 }
 
-#theme-picker, #settings-menu, #help-button {
-	border-color: #e0e0e0;
-	background: #f0f0f0;
-	color: #000;
-}
-
 #theme-picker:hover, #theme-picker:focus,
 #settings-menu:hover, #settings-menu:focus,
 #help-button:hover, #help-button:focus {

src/librustdoc/html/static/css/themes/light.css

@@ -208,12 +208,27 @@ details.undocumented > summary::before {
 	color: #999;
 }
 
-#crate-search, .search-input {
-	color: #555;
+#theme-picker:hover, #theme-picker:focus,
+#settings-menu:hover, #settings-menu:focus,
+#help-button:hover, #help-button:focus {
+	border-color: #717171;
+}
+
+#theme-picker, #settings-menu, #help-button,
+#crate-search, .search-input, .search-input::placeholder {
+	color: grey;
 	background-color: white;
 	border-color: #e0e0e0;
 }
 
+#crate-search {
+	color: black;
+}
+
+.sub-container img {
+	opacity: 50%;
+}
+
 .search-input:focus {
 	border-color: #66afe9;
 }
@@ -394,17 +409,6 @@ kbd {
 	box-shadow: inset 0 -1px 0 #c6cbd1;
 }
 
-#theme-picker, #settings-menu, #help-button {
-	border-color: #e0e0e0;
-	background-color: #fff;
-}
-
-#theme-picker:hover, #theme-picker:focus,
-#settings-menu:hover, #settings-menu:focus,
-#help-button:hover, #help-button:focus {
-	border-color: #717171;
-}
-
 #copy-path {
 	color: #999;
 }

src/test/rustdoc-gui/headers-color.goml

@@ -19,10 +19,13 @@ assert-css: (
 )
 assert-css: (
     ".impl .code-header",
-    {"color": "rgb(230, 225, 207)", "background-color": "rgb(15, 20, 25)"},
+    {"color": "rgb(230, 225, 207)", "background-color": "rgba(0, 0, 0, 0)"},
     ALL,
 )
 
+compare-elements-css: ("#settings-menu", "#help-button", ["border-color", "background-color", "color"])
+compare-elements-css: ("#settings-menu", ".search-input", ["border-color", "color"])
+
 goto: file://|DOC_PATH|/test_docs/struct.Foo.html#impl
 assert-css: (
     "#impl",
@@ -58,7 +61,7 @@ assert-css: (
 )
 assert-css: (
     ".impl .code-header",
-    {"color": "rgb(221, 221, 221)", "background-color": "rgb(53, 53, 53)"},
+    {"color": "rgb(221, 221, 221)", "background-color": "rgba(0, 0, 0, 0)"},
     ALL,
 )
 
@@ -75,6 +78,9 @@ assert-css: (
     ALL,
 )
 
+compare-elements-css: ("#settings-menu", "#help-button", ["border-color", "background-color", "color"])
+compare-elements-css: ("#settings-menu", ".search-input", ["border-color", "color"])
+
 goto: file://|DOC_PATH|/test_docs/index.html
 assert-css: (".small-section-header a", {"color": "rgb(221, 221, 221)"}, ALL)
 
@@ -95,10 +101,13 @@ assert-css: (
 )
 assert-css: (
     ".impl .code-header",
-    {"color": "rgb(0, 0, 0)", "background-color": "rgb(255, 255, 255)"},
+    {"color": "rgb(0, 0, 0)", "background-color": "rgba(0, 0, 0, 0)"},
     ALL,
 )
 
+compare-elements-css: ("#settings-menu", "#help-button", ["border-color", "background-color", "color"])
+compare-elements-css: ("#settings-menu", ".search-input", ["border-color", "color"])
+
 goto: file://|DOC_PATH|/test_docs/struct.Foo.html#impl
 assert-css: ("#impl", {"color": "rgb(0, 0, 0)", "background-color": "rgb(253, 255, 211)"})