Explain side-effects from simplify_operand.

Author: cjgillot

compiler/rustc_mir_transform/src/gvn.rs

@@ -784,6 +784,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
                 let ty = lhs.ty(self.local_decls, self.tcx);
                 let lhs = self.simplify_operand(lhs, location);
                 let rhs = self.simplify_operand(rhs, location);
+                // Only short-circuit options after we called `simplify_operand`
+                // on both operands for side effect.
                 let lhs = lhs?;
                 let rhs = rhs?;
                 if let Some(value) = self.simplify_binary(op, false, ty, lhs, rhs) {
@@ -795,6 +797,8 @@ impl<'body, 'tcx> VnState<'body, 'tcx> {
                 let ty = lhs.ty(self.local_decls, self.tcx);
                 let lhs = self.simplify_operand(lhs, location);
                 let rhs = self.simplify_operand(rhs, location);
+                // Only short-circuit options after we called `simplify_operand`
+                // on both operands for side effect.
                 let lhs = lhs?;
                 let rhs = rhs?;
                 if let Some(value) = self.simplify_binary(op, true, ty, lhs, rhs) {