Address review comments.

Author: nnethercote

compiler/rustc_ast_lowering/src/expr.rs

@@ -1777,7 +1777,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
             self.arena.alloc(hir::Path {
                 span: self.lower_span(span),
                 res,
-                segments: arena_vec![self; hir::PathSegment::from_ident(ident, hir_id, res)],
+                segments: arena_vec![self; hir::PathSegment::new(ident, hir_id, res)],
             }),
         ));
 

compiler/rustc_ast_lowering/src/item.rs

@@ -1438,7 +1438,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
                     res,
                     segments: self
                         .arena
-                        .alloc_from_iter([hir::PathSegment::from_ident(ident, hir_id, res)]),
+                        .alloc_from_iter([hir::PathSegment::new(ident, hir_id, res)]),
                 });
                 let ty_id = self.next_id();
                 let bounded_ty =

compiler/rustc_ast_lowering/src/lib.rs

@@ -1264,7 +1264,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
                     None,
                     self.arena.alloc(hir::Path {
                         res,
-                        segments: arena_vec![self; hir::PathSegment::from_ident(
+                        segments: arena_vec![self; hir::PathSegment::new(
                             Ident::with_dummy_span(kw::SelfUpper),
                             hir_id,
                             res
@@ -2200,7 +2200,8 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
             self.arena.alloc(hir::Path {
                 span: self.lower_span(span),
                 res,
-                segments: arena_vec![self; hir::PathSegment::from_ident(self.lower_ident(ident), hir_id, res)],
+                segments:
+                    arena_vec![self; hir::PathSegment::new(self.lower_ident(ident), hir_id, res)],
             }),
         ));
 

compiler/rustc_ast_lowering/src/pat.rs

@@ -262,7 +262,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
                     self.arena.alloc(hir::Path {
                         span: self.lower_span(ident.span),
                         res,
-                        segments: arena_vec![self; hir::PathSegment::from_ident(self.lower_ident(ident), hir_id, res)],
+                        segments: arena_vec![self; hir::PathSegment::new(self.lower_ident(ident), hir_id, res)],
                     }),
             ))
             }

compiler/rustc_hir/src/hir.rs

@@ -202,9 +202,7 @@ impl Path<'_> {
 pub struct PathSegment<'hir> {
     /// The identifier portion of this path segment.
     pub ident: Ident,
-
     pub hir_id: HirId,
-
     pub res: Res,
 
     /// Type/lifetime parameters attached to this path. They come in
@@ -223,12 +221,12 @@ pub struct PathSegment<'hir> {
 
 impl<'hir> PathSegment<'hir> {
     /// Converts an identifier to the corresponding segment.
-    pub fn from_ident(ident: Ident, hir_id: HirId, res: Res) -> PathSegment<'hir> {
+    pub fn new(ident: Ident, hir_id: HirId, res: Res) -> PathSegment<'hir> {
         PathSegment { ident, hir_id, res, infer_args: true, args: None }
     }
 
     pub fn invalid() -> Self {
-        Self::from_ident(Ident::empty(), HirId::INVALID, Res::Err)
+        Self::new(Ident::empty(), HirId::INVALID, Res::Err)
     }
 
     pub fn args(&self) -> &GenericArgs<'hir> {

compiler/rustc_save_analysis/src/dump_visitor.rs

@@ -916,7 +916,7 @@ impl<'tcx> DumpVisitor<'tcx> {
                 | Res::SelfTy { .. } => {
                     self.dump_path_segment_ref(
                         id,
-                        &hir::PathSegment::from_ident(ident, hir::HirId::INVALID, Res::Err),
+                        &hir::PathSegment::new(ident, hir::HirId::INVALID, Res::Err),
                     );
                 }
                 def => {