Update redundant_type_annotations doc and tests to remove String

Author: zachs18

src/tools/clippy/clippy_lints/src/redundant_type_annotations.rs

@@ -25,11 +25,11 @@ declare_clippy_lint! {
     ///
     /// ### Example
     /// ```no_run
-    /// let foo: String = String::new();
+    /// let foo: usize = usize::MAX;
     /// ```
     /// Use instead:
     /// ```no_run
-    /// let foo = String::new();
+    /// let foo = usize::MAX;
     /// ```
     #[clippy::version = "1.72.0"]
     pub REDUNDANT_TYPE_ANNOTATIONS,

src/tools/clippy/tests/ui/redundant_type_annotations.rs

@@ -154,10 +154,10 @@ fn test_complex_types<T>() {
 }
 
 fn test_functions() {
-    // Everything here should be lint
+    // Everything here should be lint, except for String, due to #101551
 
+    // FIXME: if generics support is added, the lint should fire here
     let _return: String = return_a_string();
-    //~^ ERROR: redundant type annotation
 
     let _return: Pie = return_a_struct();
     //~^ ERROR: redundant type annotation
@@ -168,8 +168,8 @@ fn test_functions() {
     let _return: u32 = return_an_int();
     //~^ ERROR: redundant type annotation
 
+    // FIXME: if generics support is added, the lint should fire here
     let _return: String = String::new();
-    //~^ ERROR: redundant type annotation
 
     let new_pie: Pie = Pie::new();
     //~^ ERROR: redundant type annotation
@@ -180,8 +180,8 @@ fn test_functions() {
     let _return: u32 = Pie::associated_return_an_int();
     //~^ ERROR: redundant type annotation
 
+    // FIXME: if generics support is added, the lint should fire here
     let _return: String = Pie::associated_return_a_string();
-    //~^ ERROR: redundant type annotation
 }
 
 fn test_simple_types() {

src/tools/clippy/tests/ui/redundant_type_annotations.stderr

@@ -19,12 +19,6 @@ error: redundant type annotation
 LL |         let v: &Slice = self.return_a_ref_to_struct();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: redundant type annotation
-  --> tests/ui/redundant_type_annotations.rs:159:5
-   |
-LL |     let _return: String = return_a_string();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
 error: redundant type annotation
   --> tests/ui/redundant_type_annotations.rs:162:5
    |
@@ -43,12 +37,6 @@ error: redundant type annotation
 LL |     let _return: u32 = return_an_int();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: redundant type annotation
-  --> tests/ui/redundant_type_annotations.rs:171:5
-   |
-LL |     let _return: String = String::new();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
 error: redundant type annotation
   --> tests/ui/redundant_type_annotations.rs:174:5
    |
@@ -67,12 +55,6 @@ error: redundant type annotation
 LL |     let _return: u32 = Pie::associated_return_an_int();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: redundant type annotation
-  --> tests/ui/redundant_type_annotations.rs:183:5
-   |
-LL |     let _return: String = Pie::associated_return_a_string();
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
 error: redundant type annotation
   --> tests/ui/redundant_type_annotations.rs:190:5
    |
@@ -103,5 +85,5 @@ error: redundant type annotation
 LL |     let _var: bool = false;
    |     ^^^^^^^^^^^^^^^^^^^^^^^
 
-error: aborting due to 17 previous errors
+error: aborting due to 14 previous errors