Address review comments

Author: varkor

src/librustc_lint/unused.rs

@@ -244,6 +244,8 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnusedResults {
                 }
                 ty::Array(ty, mut len) => {
                     // Try to evaluate the length if it's unevaluated.
+                    // FIXME(59369): we should be able to remove this once we merge
+                    // https://github.com/rust-lang/rust/pull/59369.
                     if let ConstValue::Unevaluated(def_id, substs) = len.val {
                         let instance = ty::Instance::resolve(
                             cx.tcx.global_tcx(),
@@ -261,17 +263,16 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnusedResults {
                     }
 
                     match len.assert_usize(cx.tcx) {
-                        // If the array is definitely non-empty, we can do `#[must_use]` checking.
-                        Some(n) if n != 0 => {
+                        Some(0) => false, // Empty arrays won't contain any `#[must_use]` types.
+                        // If the array may be non-empty, we do `#[must_use]` checking.
+                        _ => {
                             let descr_pre = &format!(
                                 "{}array{} of ",
                                 descr_pre,
                                 plural_suffix,
                             );
                             check_must_use_ty(cx, ty, expr, span, descr_pre, descr_post, true)
                         }
-                        // Otherwise, we don't lint, to avoid false positives.
-                        _ => false,
                     }
                 }
                 _ => false,

src/libstd/panicking.rs

@@ -103,9 +103,7 @@ pub fn set_hook(hook: Box<dyn Fn(&PanicInfo<'_>) + 'static + Sync + Send>) {
         HOOK_LOCK.write_unlock();
 
         if let Hook::Custom(ptr) = old_hook {
-            #[allow(unused_must_use)] {
-                Box::from_raw(ptr);
-            }
+            mem::drop(Box::from_raw(ptr));
         }
     }
 }