remove github caches (#301)

* remove github caches

* do not persist github data on disk

* triagebot is special

* don't need this dep anymore

* ignore triagebot properly

* whoops...

* say 'available'

---------

Co-authored-by: Niko Matsakis <nikomat@amazon.com>

Author: nikomatsakis

Cargo.lock

@@ -23,6 +23,10 @@ command = "cargo run -p mdbook-goals --"
 [preprocessor.goals.users]
 "@Nadrieril" = "@Nadrieril"
 
+preprocessor.goals.ignore_users = [
+    "@triagebot",
+]
+
 
 [output.html]
 git-repository-url = "https://github.com/rust-lang/rust-project-goals"

book.toml

@@ -20,6 +20,7 @@ use rust_project_goals::{
 const LINKS: &str = "links";
 const LINKIFIERS: &str = "linkifiers";
 const USERS: &str = "users";
+const IGNORE_USERS: &str = "ignore_users";
 
 pub struct GoalPreprocessor;
 
@@ -45,6 +46,7 @@ pub struct GoalPreprocessorWithContext<'c> {
     links: Vec<(String, String)>,
     linkifiers: Vec<(Regex, String)>,
     display_names: BTreeMap<String, Rc<String>>,
+    ignore_users: Vec<String>,
     goal_document_map: BTreeMap<PathBuf, Arc<Vec<GoalDocument>>>,
 }
 
@@ -55,6 +57,7 @@ impl<'c> GoalPreprocessorWithContext<'c> {
         let mut links: Vec<(String, String)> = Default::default();
         let mut linkifiers = Default::default();
         let mut display_names: BTreeMap<String, Rc<String>> = Default::default();
+        let mut ignore_users: Vec<String> = Default::default();
         if let Some(config) = ctx.config.get_preprocessor(GoalPreprocessor.name()) {
             if let Some(value) = config.get(LINKS) {
                 links = value
@@ -112,6 +115,24 @@ impl<'c> GoalPreprocessorWithContext<'c> {
                     display_names.insert(user, Rc::new(display_name));
                 }
             }
+
+            if let Some(value) = config.get(IGNORE_USERS) {
+                ignore_users = value
+                    .as_array()
+                    .with_context(|| format!("`{}` must be an array", IGNORE_USERS))?
+                    .iter()
+                    .map(|v| {
+                        if let Some(v) = v.as_str() {
+                            Ok(v.to_string())
+                        } else {
+                            Err(anyhow::anyhow!(
+                                "ignore user value `{}` must be a string",
+                                v
+                            ))
+                        }
+                    })
+                    .collect::<anyhow::Result<Vec<_>>>()?;
+            }
         }
 
         Ok(GoalPreprocessorWithContext {
@@ -122,6 +143,7 @@ impl<'c> GoalPreprocessorWithContext<'c> {
             links,
             linkifiers,
             display_names,
+            ignore_users,
             goal_document_map: Default::default(),
         })
     }
@@ -312,6 +334,7 @@ impl<'c> GoalPreprocessorWithContext<'c> {
             .username
             .find_iter(&chapter.content)
             .map(|m| m.as_str().to_string())
+            .filter(|username| !self.ignore_users.contains(username))
             .collect();
 
         for username in &usernames {

crates/mdbook-goals/src/mdbook_preprocessor.rs

@@ -123,9 +123,9 @@ async fn prepare_goals(
         let why_this_goal = why_this_goal(&issue_id, issue)?;
 
         let details_summary = match comments.len() {
-            0 => String::from("No updates posted."),
-            1 => String::from("1 update posted."),
-            len => format!("{len} updates posted."),
+            0 => String::from("No detailed updates available."),
+            1 => String::from("1 detailed update available."),
+            len => format!("{len} detailed updates availabled."),
         };
         result.push(UpdatesGoal {
             title: title.clone(),

crates/rust-project-goals-cli-llm/src/updates.rs

@@ -6,7 +6,6 @@ edition = "2021"
 [dependencies]
 anyhow = "1.0.94"
 chrono = "0.4.39"
-disk-persist = "0.1.0"
 lazy_static = "1.5.0"
 regex = "1.11.1"
 reqwest = { version = "0.12.9", features = ["blocking", "json"] }

crates/rust-project-goals/Cargo.toml

@@ -4,7 +4,6 @@ use std::{
     path::{Path, PathBuf},
 };
 
-use disk_persist::DiskPersist;
 use walkdir::WalkDir;
 
 pub const ARROW: &str = "↳";
@@ -59,20 +58,7 @@ pub struct GithubUserInfo {
 
 impl GithubUserInfo {
     pub fn load(login: &str) -> anyhow::Result<Self> {
-        let path = PathBuf::from("gh-cache").join(format!("{}.bincode", login));
-        let persist = DiskPersist::init_with_path(&path)?;
-        if let Some(info) = persist.read()? {
-            Ok(info)
-        } else {
-            let info = Self::github_request(login)?;
-            persist.write(&info)?;
-            eprintln!(
-                "cached info for `{}` from github in `{}`",
-                login,
-                path.display()
-            );
-            Ok(info)
-        }
+        Self::github_request(login)
     }
 
     fn github_request(login: &str) -> anyhow::Result<Self> {