Merge pull request #842 from integer32llc/ts-type-errors

Author: shepmaster

tests/spec/features/compilation_targets_spec.rb

@@ -42,7 +42,7 @@
     end
   end
 
-  context "when AT&T syntax is selected" do
+  context "when AT&T syntax is selected", :assembly do
     before do
       in_config_menu { choose("AT&T") }
     end
@@ -59,7 +59,7 @@
     end
   end
 
-  context "when Intel syntax is selected" do
+  context "when Intel syntax is selected", :assembly do
     before do
       in_config_menu { choose("Intel") }
     end

tests/spec/features/navigation_spec.rb

@@ -44,7 +44,7 @@
     expect(page).to be_at_url('/')
   end
 
-  scenario "Navigating to help changes the URL" do
+  scenario "Navigating to help changes the URL", :flaky do
     visit '/'
     expect(page).to have_content('RUN')
 

ui/frontend/Icon.tsx

@@ -31,11 +31,8 @@ export const MoreOptionsIcon = () => (
 
 export const MoreOptionsActiveIcon = () => (
   <svg className={styles.icon} height="18" viewBox="0 0 24 24" width="18" xmlns="http://www.w3.org/2000/svg">
-    <g fillRule="evenodd" fill="#428bca">
-
-      <path d="M4,5 h16 a3,3 0 0,1 3,3 v8 a3,3 0 0,1 -3,3 h-16 a3,3 0 0,1 -3,-3 v-8 a3,3 0 0,1 3,-3 Z
-               M6 10c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm12 0c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm-6 0c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2z" />
-    </g>
+    {/* eslint-disable-next-line react/no-unknown-property */}
+    <path fillRule="evenodd" fill="#428bca" d="M4,5 h16 a3,3 0 0,1 3,3 v8 a3,3 0 0,1 -3,3 h-16 a3,3 0 0,1 -3,-3 v-8 a3,3 0 0,1 3,-3 Z M6 10c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm12 0c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2zm-6 0c-1.1 0-2 .9-2 2s.9 2 2 2 2-.9 2-2-.9-2-2-2z" />
   </svg>
 );
 

ui/frontend/Output/Gist.tsx

@@ -29,7 +29,7 @@ interface CopiedState {
 }
 
 class Copied extends React.PureComponent<CopiedProps, CopiedState> {
-  public constructor(props) {
+  public constructor(props: CopiedProps) {
     super(props);
     this.state = { copied: false };
   }

ui/frontend/Playground.tsx

@@ -44,13 +44,15 @@ const ResizableArea: React.FC = () => {
   const dispatch = useDispatch();
   const resizeComplete = useCallback(() => dispatch(actions.splitRatioChanged()), [dispatch]);
 
-  const grid = useRef(null);
+  const grid = useRef<HTMLDivElement | null>(null);
   const dragHandle = useRef(null);
 
   // Reset styles left on the grid from split-grid when we change orientation or focus.
   useEffect(() => {
-    grid.current.style['grid-template-columns'] = null;
-    grid.current.style['grid-template-rows'] = null;
+    if (grid.current) {
+      grid.current.style.removeProperty('grid-template-columns');
+      grid.current.style.removeProperty('grid-template-rows');
+    }
 
     resizeComplete();
   }, [orientation, isFocused, resizeComplete])

ui/frontend/PopButton.tsx

@@ -33,7 +33,9 @@ const PopButton: React.FC<NewPopProps> = ({ Button, Menu }) => {
       return;
     }
 
-    const handleClickOutside = (event) => {
+    const handleClickOutside = (event: MouseEvent) => {
+      if (!(event.target instanceof Node)) { return; }
+
       if (referenceElement && referenceElement.contains(event.target)) {
         // They are clicking on the button, so let that go ahead and close us.
         return;

ui/frontend/Router.tsx

@@ -1,18 +1,29 @@
 import React from 'react';
 
-import { createBrowserHistory as createHistory } from 'history';
-import { createRouter } from './uss-router';
+import { createBrowserHistory as createHistory, Path, Location } from 'history';
+import { createRouter, PlainOrThunk } from './uss-router';
 import UssRouter from './uss-router/Router';
 
 import qs from 'qs';
 import Route from 'route-parser';
 
 import * as actions from './actions';
+import State from './state';
+import { Channel, Edition, Mode, Page } from './types';
 
 const homeRoute = new Route('/');
 const helpRoute = new Route('/help');
 
-const stateSelector = ({ page, configuration: { channel, mode, edition } }) => ({
+interface Substate {
+  page: Page;
+  configuration: {
+    channel: Channel;
+    mode: Mode;
+    edition: Edition;
+  }
+}
+
+const stateSelector = ({ page, configuration: { channel, mode, edition } }: State): Substate => ({
   page,
   configuration: {
     channel,
@@ -21,7 +32,7 @@ const stateSelector = ({ page, configuration: { channel, mode, edition } }) => (
   },
 });
 
-const stateToLocation = ({ page, configuration }) => {
+const stateToLocation = ({ page, configuration }: Substate): Partial<Path> => {
   switch (page) {
     case 'help': {
       return {
@@ -42,7 +53,7 @@ const stateToLocation = ({ page, configuration }) => {
   }
 };
 
-const locationToAction = location => {
+const locationToAction = (location: Location): PlainOrThunk<State, actions.Action> | null => {
   const matchedHelp = helpRoute.match(location.pathname);
 
   if (matchedHelp) {
@@ -61,7 +72,7 @@ const locationToAction = location => {
 export default class Router extends React.Component<RouterProps> {
   private router: any;
 
-  public constructor(props) {
+  public constructor(props: RouterProps) {
     super(props);
 
     const history = createHistory();