-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add new check for passing pointers to an asm! block with nomem option
#13247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
y21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a useful lint to have. Implementation generally looks good to me aside from a few small things 👍
|
I think all the comments were addressed
Yeah, after spending two days to debug this issue, certainly 😅 |
y21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small nits/typos then this should be good
|
Also went ahead and opened the FCP thread on zulip that we require for new lints: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/FCP.3A.20pointer_in_nomem_asm_block |
|
LGTM :) |
|
☔ The latest upstream changes (presumably #11476) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The FCP thread has been up for about two weeks and has received some 👍 reactions and no concerns, so I'd say we're good. Just needs a rebase now. Can you also squash the commits while you're at it? |
2599e6c to
273b561
Compare
|
@y21 done |
|
Thanks for implementing this lint! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
🎉 |
changelog: Add new check for passing pointers to an
asm!block withnomemoptionContinuing work from rust-lang/rust#127063