Rename CLIPPY_CTFE->CTFE and use declare_tool_lint to declare it

Author: flip1995

clippy_lints/src/ctfe.rs

@@ -1,29 +1,25 @@
+#![cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
+
 use rustc_hir::def_id::LocalDefId;
 use rustc_hir::intravisit::FnKind;
 use rustc_hir::{Body, FnDecl};
-use rustc_lint::Level::Deny;
-use rustc_lint::{LateContext, LateLintPass, Lint};
-use rustc_session::declare_lint_pass;
+use rustc_lint::{LateContext, LateLintPass};
+use rustc_session::{declare_lint_pass, declare_tool_lint};
 use rustc_span::Span;
 
-/// Ensures that Constant-time Function Evaluation is being done (specifically, MIR lint passes).
-/// As Clippy deactivates codegen, this lint ensures that CTFE (used in hard errors) is still ran.
-pub static CLIPPY_CTFE: &Lint = &Lint {
-    name: &"clippy::CLIPPY_CTFE",
-    default_level: Deny,
-    desc: "Ensure CTFE is being made",
-    edition_lint_opts: None,
+// Not using `declare_clippy_lint`, so that no static CLIPPY_CTFE_INFO is created, so this lint
+// doesn't show up in the documentation.
+declare_tool_lint! {
+    /// Ensures that Constant-time Function Evaluation is being done (specifically, MIR lint passes).
+    /// As Clippy deactivates codegen, this lint ensures that CTFE (used in hard errors) is still ran.
+    pub clippy::CTFE,
+    Allow,
+    "Ensure CTFE is being made",
     report_in_external_macro: true,
-    future_incompatible: None,
-    is_externally_loaded: true,
-    crate_level_only: false,
-    eval_always: true,
-    ..Lint::default_fields_for_macro()
-};
-
-// No static CLIPPY_CTFE_INFO because we want this lint to be invisible
+    @eval_always = true
+}
 
-declare_lint_pass! { ClippyCtfe => [CLIPPY_CTFE] }
+declare_lint_pass! { ClippyCtfe => [CTFE] }
 
 impl<'tcx> LateLintPass<'tcx> for ClippyCtfe {
     fn check_fn(

clippy_lints/src/lib.rs

@@ -62,13 +62,13 @@ mod declare_clippy_lint;
 #[macro_use]
 extern crate clippy_utils;
 
-#[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
 mod utils;
 
-pub mod ctfe; // Very important lint, do not remove (rust#125116)
 pub mod declared_lints;
 pub mod deprecated_lints;
 
+mod ctfe; // Very important lint, do not remove (rust#125116)
+
 // begin lints modules, do not remove this comment, it’s used in `update_lints`
 mod absolute_paths;
 mod almost_complete_range;

clippy_lints/src/utils/mod.rs

@@ -1,3 +1,5 @@
+#![cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
+
 pub mod author;
 pub mod dump_hir;
 pub mod format_args_collector;