responding to feedback, inline msg, update comments

Author: ParkMyCar

clippy_lints/src/pub_underscore_fields.rs

@@ -23,6 +23,10 @@ declare_clippy_lint! {
     /// struct FileHandle {
     ///     _descriptor: usize,
     /// }
+    /// // OR
+    /// struct FileHandle {
+    ///     pub descriptor: usize,
+    /// }
     /// ```
     #[clippy::version = "1.74.0"]
     pub PUB_UNDERSCORE_FIELDS,
@@ -38,16 +42,15 @@ impl EarlyLintPass for PubUnderscoreFields {
             return;
         };
 
-        let msg = "field marked as public but also inferred as unused because it's prefixed with `_`";
-        for field in st.fields().iter() {
+        for field in st.fields() {
             if let Some(ident) = field.ident.as_ref()
             && ident.as_str().starts_with('_')
             && !matches!(field.vis.kind, VisibilityKind::Inherited) {
                 span_lint_and_help(
                     cx,
                     PUB_UNDERSCORE_FIELDS,
                     field.vis.span.to(ident.span),
-                    msg,
+                    "field marked as public but also inferred as unused because it's prefixed with `_`",
                     None,
                     "consider removing the underscore, or making the field private",
                 );