Rename the lint

Author: botahamec

CHANGELOG.md

@@ -3969,6 +3969,7 @@ Released 2018-09-13
 [`unit_hash`]: https://rust-lang.github.io/rust-clippy/master/index.html#unit_hash
 [`unit_return_expecting_ord`]: https://rust-lang.github.io/rust-clippy/master/index.html#unit_return_expecting_ord
 [`unknown_clippy_lints`]: https://rust-lang.github.io/rust-clippy/master/index.html#unknown_clippy_lints
+[`unnecessary_box_return`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_box_return
 [`unnecessary_cast`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
 [`unnecessary_filter_map`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
 [`unnecessary_find_map`]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_find_map
@@ -3996,7 +3997,6 @@ Released 2018-09-13
 [`unstable_as_mut_slice`]: https://rust-lang.github.io/rust-clippy/master/index.html#unstable_as_mut_slice
 [`unstable_as_slice`]: https://rust-lang.github.io/rust-clippy/master/index.html#unstable_as_slice
 [`unused_async`]: https://rust-lang.github.io/rust-clippy/master/index.html#unused_async
-[`unused_box`]: https://rust-lang.github.io/rust-clippy/master/index.html#unused_box
 [`unused_collect`]: https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect
 [`unused_io_amount`]: https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
 [`unused_label`]: https://rust-lang.github.io/rust-clippy/master/index.html#unused_label

clippy_lints/src/lib.register_lints.rs

@@ -560,14 +560,14 @@ store.register_lints(&[
     unit_types::UNIT_CMP,
     unnamed_address::FN_ADDRESS_COMPARISONS,
     unnamed_address::VTABLE_ADDRESS_COMPARISONS,
+    unnecessary_box_return::UNNECESSARY_BOX_RETURN,
     unnecessary_owned_empty_strings::UNNECESSARY_OWNED_EMPTY_STRINGS,
     unnecessary_self_imports::UNNECESSARY_SELF_IMPORTS,
     unnecessary_sort_by::UNNECESSARY_SORT_BY,
     unnecessary_wraps::UNNECESSARY_WRAPS,
     unnested_or_patterns::UNNESTED_OR_PATTERNS,
     unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
     unused_async::UNUSED_ASYNC,
-    unused_box::UNUSED_BOX,
     unused_io_amount::UNUSED_IO_AMOUNT,
     unused_rounding::UNUSED_ROUNDING,
     unused_self::UNUSED_SELF,

clippy_lints/src/lib.register_nursery.rs

@@ -31,7 +31,7 @@ store.register_group(true, "clippy::nursery", Some("clippy_nursery"), vec![
     LintId::of(trait_bounds::TRAIT_DUPLICATION_IN_BOUNDS),
     LintId::of(trait_bounds::TYPE_REPETITION_IN_BOUNDS),
     LintId::of(transmute::TRANSMUTE_UNDEFINED_REPR),
-    LintId::of(unused_box::UNUSED_BOX),
+    LintId::of(unnecessary_box_return::UNNECESSARY_BOX_RETURN),
     LintId::of(unused_rounding::UNUSED_ROUNDING),
     LintId::of(use_self::USE_SELF),
 ])

clippy_lints/src/lib.rs

@@ -387,14 +387,14 @@ mod unit_hash;
 mod unit_return_expecting_ord;
 mod unit_types;
 mod unnamed_address;
+mod unnecessary_box_return;
 mod unnecessary_owned_empty_strings;
 mod unnecessary_self_imports;
 mod unnecessary_sort_by;
 mod unnecessary_wraps;
 mod unnested_or_patterns;
 mod unsafe_removed_from_name;
 mod unused_async;
-mod unused_box;
 mod unused_io_amount;
 mod unused_rounding;
 mod unused_self;
@@ -931,7 +931,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
     store.register_late_pass(|| Box::new(invalid_utf8_in_unchecked::InvalidUtf8InUnchecked));
     store.register_late_pass(|| Box::new(std_instead_of_core::StdReexports::default()));
     store.register_late_pass(|| Box::new(std_instead_of_core::StdReexports));
-    store.register_late_pass(|| Box::new(unused_box::UnusedBox));
+    store.register_late_pass(|| Box::new(unnecessary_box_return::UnnecessaryBoxReturn));
     // add lints here, do not remove this comment, it's used in `new_lint`
 }
 

clippy_lints/src/unused_box.rs renamed to clippy_lints/src/unnecessary_box_return.rs

@@ -30,13 +30,13 @@ declare_clippy_lint! {
     /// }
     /// ```
     #[clippy::version = "1.64.0"]
-    pub UNUSED_BOX,
+    pub UNNECESSARY_BOX_RETURN,
     nursery,
     "Needlessly returning a Box"
 }
-declare_lint_pass!(UnusedBox => [UNUSED_BOX]);
+declare_lint_pass!(UnnecessaryBoxReturn => [UNNECESSARY_BOX_RETURN]);
 
-impl LateLintPass<'_> for UnusedBox {
+impl LateLintPass<'_> for UnnecessaryBoxReturn {
     fn check_fn(
         &mut self,
         cx: &LateContext<'_>,
@@ -68,7 +68,7 @@ impl LateLintPass<'_> for UnusedBox {
         if implements_trait(cx, boxed_ty, sized_trait, &[]) {
             span_lint_and_sugg(
                 cx,
-                UNUSED_BOX,
+                UNNECESSARY_BOX_RETURN,
                 return_ty_hir.span,
                 format!("function returns `Box<{0}>` when `{0}` implements `Sized`", boxed_ty).as_str(),
                 "change the return type to",

tests/ui/unknown_clippy_lints.fixed

@@ -12,7 +12,7 @@
 // Shouldn't suggest rustc lint name(`dead_code`)
 #[warn(clippy::drop_copy)]
 // Shouldn't suggest removed/deprecated clippy lint name(`unused_collect`)
-#[warn(clippy::unused_box)]
+#[warn(clippy::unused_self)]
 // Shouldn't suggest renamed clippy lint name(`const_static_lifetime`)
 #[warn(clippy::redundant_static_lifetimes)]
 fn main() {}

tests/ui/unknown_clippy_lints.stderr

@@ -40,7 +40,7 @@ error: unknown lint: `clippy::unused_colle`
   --> $DIR/unknown_clippy_lints.rs:15:8
    |
 LL | #[warn(clippy::unused_colle)]
-   |        ^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::unused_box`
+   |        ^^^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::unused_self`
 
 error: unknown lint: `clippy::const_static_lifetim`
   --> $DIR/unknown_clippy_lints.rs:17:8

tests/ui/unused_box.rs renamed to tests/ui/unnecessary_box_return.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::unused_box)]
+#![warn(clippy::unnecessary_box_return)]
 
 struct Foo {}
 
@@ -8,7 +8,7 @@ fn boxed_usize() -> Box<usize> {
 }
 
 // lint
-fn boxed_string() -> Box<Foo> {
+fn boxed_foo() -> Box<Foo> {
     Box::new(Foo {})
 }
 

tests/ui/unused_box.stderr renamed to tests/ui/unnecessary_box_return.stderr

@@ -1,16 +1,16 @@
 error: function returns `Box<usize>` when `usize` implements `Sized`
-  --> $DIR/unused_box.rs:6:21
+  --> $DIR/unnecessary_box_return.rs:6:21
    |
 LL | fn boxed_usize() -> Box<usize> {
    |                     ^^^^^^^^^^ help: change the return type to: `usize`
    |
-   = note: `-D clippy::unused-box` implied by `-D warnings`
+   = note: `-D clippy::unnecessary-box-return` implied by `-D warnings`
 
 error: function returns `Box<Foo>` when `Foo` implements `Sized`
-  --> $DIR/unused_box.rs:11:22
+  --> $DIR/unnecessary_box_return.rs:11:19
    |
-LL | fn boxed_string() -> Box<Foo> {
-   |                      ^^^^^^^^ help: change the return type to: `Foo`
+LL | fn boxed_foo() -> Box<Foo> {
+   |                   ^^^^^^^^ help: change the return type to: `Foo`
 
 error: aborting due to 2 previous errors