use let chains instead of if_chain!

Author: jonboh

clippy_lints/src/unnecessary_map_on_constructor.rs

@@ -43,16 +43,15 @@ impl<'tcx> LateLintPass<'tcx> for UnnecessaryMapOnConstructor {
                 return;
             };
 
-            let (constructor_path, constructor_item) = if_chain! {
-                if let hir::ExprKind::Call(constructor, constructor_args) = recv.kind;
-                if let hir::ExprKind::Path(constructor_path) = constructor.kind;
-                if let Some(arg) = constructor_args.get(0);
-                then {
+            let (constructor_path, constructor_item) =
+                if let hir::ExprKind::Call(constructor, constructor_args) = recv.kind
+                    && let hir::ExprKind::Path(constructor_path) = constructor.kind
+                    && let Some(arg) = constructor_args.get(0)
+                {
                     (constructor_path, arg)
                 } else {
                     return;
-                }
-            };
+                };
             let constructor_symbol = match constructor_path {
                 hir::QPath::Resolved(_, path) => {
                     if let Some(path_segment) = path.segments.last() {
@@ -70,25 +69,23 @@ impl<'tcx> LateLintPass<'tcx> for UnnecessaryMapOnConstructor {
                 _ => return,
             }
 
-            if_chain! {
-                if let Some(arg) = args.get(0);
-                if let hir::ExprKind::Path(fun) = arg.kind;
-                then {
-                    let mut applicability = Applicability::MachineApplicable;
-                    let constructor_snippet =
-                        snippet_with_applicability(cx, constructor_path.span(), "_", &mut applicability);
-                    let constructor_arg_snippet =
-                        snippet_with_applicability(cx, constructor_item.span, "_", &mut applicability);
-                    span_lint_and_sugg(
-                        cx,
-                        UNNECESSARY_MAP_ON_CONSTRUCTOR,
-                        expr.span,
-                        &format!("unnecessary {} on contstuctor {constructor_snippet}(_)", path.ident.name),
-                        "try",
-                        format!("{constructor_snippet}({}({constructor_arg_snippet}))", path.ident.name),
-                        applicability,
-                    );
-                }
+            if let Some(arg) = args.get(0)
+                && let hir::ExprKind::Path(fun) = arg.kind
+            {
+                let mut applicability = Applicability::MachineApplicable;
+                let constructor_snippet =
+                    snippet_with_applicability(cx, constructor_path.span(), "_", &mut applicability);
+                let constructor_arg_snippet =
+                    snippet_with_applicability(cx, constructor_item.span, "_", &mut applicability);
+                span_lint_and_sugg(
+                    cx,
+                    UNNECESSARY_MAP_ON_CONSTRUCTOR,
+                    expr.span,
+                    &format!("unnecessary {} on contstuctor {constructor_snippet}(_)", path.ident.name),
+                    "try",
+                    format!("{constructor_snippet}({}({constructor_arg_snippet}))", path.ident.name),
+                    applicability,
+                );
             }
         }
     }