Auto merge of #5168 - lily-commure:chars_next_style, r=flip1995

Reclassify chars_next_cmp as a style lint.

This makes it consistent with chars_last_cmp.

changelog: none

Author: bors

clippy_lints/src/lib.rs

@@ -1412,6 +1412,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         LintId::of(&mem_replace::MEM_REPLACE_OPTION_WITH_NONE),
         LintId::of(&mem_replace::MEM_REPLACE_WITH_DEFAULT),
         LintId::of(&methods::CHARS_LAST_CMP),
+        LintId::of(&methods::CHARS_NEXT_CMP),
         LintId::of(&methods::INTO_ITER_ON_REF),
         LintId::of(&methods::ITER_CLONED_COLLECT),
         LintId::of(&methods::ITER_NTH_ZERO),
@@ -1494,7 +1495,6 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         LintId::of(&matches::MATCH_AS_REF),
         LintId::of(&matches::MATCH_SINGLE_BINDING),
         LintId::of(&matches::WILDCARD_IN_OR_PATTERNS),
-        LintId::of(&methods::CHARS_NEXT_CMP),
         LintId::of(&methods::CLONE_ON_COPY),
         LintId::of(&methods::FILTER_NEXT),
         LintId::of(&methods::FLAT_MAP_IDENTITY),

clippy_lints/src/methods/mod.rs

@@ -551,7 +551,7 @@ declare_clippy_lint! {
     /// if name.starts_with('_') {};
     /// ```
     pub CHARS_NEXT_CMP,
-    complexity,
+    style,
     "using `.chars().next()` to check if a string starts with a char"
 }
 

src/lintlist/mod.rs

@@ -191,7 +191,7 @@ pub const ALL_LINTS: [Lint; 355] = [
     },
     Lint {
         name: "chars_next_cmp",
-        group: "complexity",
+        group: "style",
         desc: "using `.chars().next()` to check if a string starts with a char",
         deprecation: None,
         module: "methods",