fix: single_range_in_vec_init wrongly showed field name when using Range

Author: profetia

clippy_lints/src/single_range_in_vec_init.rs

@@ -96,8 +96,8 @@ impl LateLintPass<'_> for SingleRangeInVecInit {
             // `is_from_proc_macro` will skip any `vec![]`. Let's not!
             && snippet.starts_with(suggested_type.starts_with())
             && snippet.ends_with(suggested_type.ends_with())
-            && let Some(start_snippet) = start.span.get_source_text(cx)
-            && let Some(end_snippet) = end.span.get_source_text(cx)
+            && let Some(start_snippet) = start.expr.span.get_source_text(cx)
+            && let Some(end_snippet) = end.expr.span.get_source_text(cx)
         {
             let should_emit_every_value = if let Some(step_def_id) = cx.tcx.get_diagnostic_item(sym::range_step)
                 && implements_trait(cx, ty, step_def_id, &[])

tests/ui/single_range_in_vec_init.rs

@@ -66,3 +66,10 @@ fn main() {
         vec![0..200];
     }
 }
+
+fn issue16042() {
+    use std::ops::Range;
+
+    let input = vec![Range { start: 0, end: 5 }];
+    //~^ single_range_in_vec_init
+}

tests/ui/single_range_in_vec_init.stderr

@@ -160,5 +160,22 @@ LL -     vec![0..200isize];
 LL +     (0..200isize).collect::<std::vec::Vec<isize>>();
    |
 
-error: aborting due to 10 previous errors
+error: a `Vec` of `Range` that is only one element
+  --> tests/ui/single_range_in_vec_init.rs:73:17
+   |
+LL |     let input = vec![Range { start: 0, end: 5 }];
+   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: if you wanted a `Vec` that contains the entire range, try
+   |
+LL -     let input = vec![Range { start: 0, end: 5 }];
+LL +     let input = (0..5).collect::<std::vec::Vec<i32>>();
+   |
+help: if you wanted a `Vec` of len 5, try
+   |
+LL -     let input = vec![Range { start: 0, end: 5 }];
+LL +     let input = vec![0; 5];
+   |
+
+error: aborting due to 11 previous errors