Lint

Jerry Hardee · Jerry Hardee · commit 8a8eedf388a1 · 2019-07-15T14:00:07.000-05:00
diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs
@@ -511,13 +511,11 @@ fn is_signum(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
         if sym!(signum) == method_name.ident.name;
         // Check that the receiver of the signum() is a float (expressions[0] is the receiver of
         // the method call)
-        if is_float(cx, &expressions[0]);
         then {
-            true
-        } else {
-            false
+            return is_float(cx, &expressions[0]);
         }
     }
+    false
 }
 
 fn is_float(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {

Original file line number	Diff line number	Diff line change
`@@ -511,13 +511,11 @@ fn is_signum(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {`
`511`	`511`	`if sym!(signum) == method_name.ident.name;`
`512`	`512`	`// Check that the receiver of the signum() is a float (expressions[0] is the receiver of`
`513`	`513`	`// the method call)`
`514`		`- if is_float(cx, &expressions[0]);`
`515`	`514`	`then {`
`516`		`- true`
`517`		`- } else {`
`518`		`- false`
	`515`	`+ return is_float(cx, &expressions[0]);`
`519`	`516`	`}`
`520`	`517`	`}`
	`518`	`+ false`
`521`	`519`	`}`
`522`	`520`
`523`	`521`	`fn is_float(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {`