Convert redundant_clone to an analysis pass

Author: Jarcho

clippy_lints/Cargo.toml

@@ -12,6 +12,8 @@ edition = "2024"
 arrayvec = { version = "0.7", default-features = false }
 cargo_metadata = "0.18"
 clippy_config = { path = "../clippy_config" }
+clippy_data_structures = { path = "../clippy_data_structures" }
+clippy_mir = { path = "../clippy_mir" }
 clippy_utils = { path = "../clippy_utils" }
 declare_clippy_lint = { path = "../declare_clippy_lint" }
 itertools = "0.12"

clippy_lints/src/assigning_clones.rs

@@ -155,7 +155,7 @@ fn clone_source_borrows_from_dest(cx: &LateContext<'_>, lhs: &Expr<'_>, call_spa
     let Some(mir) = enclosing_mir(cx.tcx, lhs.hir_id) else {
         return false;
     };
-    let PossibleBorrowerMap { map: borrow_map, .. } = PossibleBorrowerMap::new(cx, mir);
+    let PossibleBorrowerMap { map: borrow_map, .. } = PossibleBorrowerMap::new(cx.tcx, cx.typing_env(), mir);
 
     // The operation `dest = src.to_owned()` in MIR is split up across 3 blocks *if* the type has `Drop`
     // code. For types that don't, the second basic block is simply skipped.

clippy_lints/src/lib.rs

@@ -1,5 +1,7 @@
+#![feature(array_chunks)]
 #![feature(array_windows)]
 #![feature(box_patterns)]
+#![feature(cmp_minmax)]
 #![feature(macro_metavar_expr_concat)]
 #![feature(f128)]
 #![feature(f16)]
@@ -30,6 +32,7 @@
 
 // FIXME: switch to something more ergonomic here, once available.
 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
+extern crate indexmap;
 extern crate pulldown_cmark;
 extern crate rustc_abi;
 extern crate rustc_arena;
@@ -48,6 +51,7 @@ extern crate rustc_infer;
 extern crate rustc_lexer;
 extern crate rustc_lint;
 extern crate rustc_middle;
+extern crate rustc_mir_dataflow;
 extern crate rustc_parse;
 extern crate rustc_parse_format;
 extern crate rustc_resolve;

clippy_lints/src/needless_borrows_for_generic_args.rs

@@ -364,7 +364,10 @@ fn referent_used_exactly_once<'tcx>(
             .last()
             .is_none_or(|&(local_def_id, _)| local_def_id != body_owner_local_def_id)
         {
-            possible_borrowers.push((body_owner_local_def_id, PossibleBorrowerMap::new(cx, mir)));
+            possible_borrowers.push((
+                body_owner_local_def_id,
+                PossibleBorrowerMap::new(cx.tcx, cx.typing_env(), mir),
+            ));
         }
         let possible_borrower = &mut possible_borrowers.last_mut().unwrap().1;
         // If `only_borrowers` were used here, the `copyable_iterator::warn` test would fail. The reason is