Fix suggestion for separated_literal_suffix

Author: dswij

clippy_lints/src/misc_early/literal_suffix.rs

@@ -20,7 +20,7 @@ pub(super) fn check(cx: &EarlyContext<'_>, lit: &Lit, lit_snip: &str, suffix: &s
                 lit.span,
                 &format!("{} type suffix should not be separated by an underscore", sugg_type),
                 "remove the underscore",
-                format!("{}{}", &lit_snip[..=maybe_last_sep_idx], suffix),
+                format!("{}{}", &lit_snip[..maybe_last_sep_idx], suffix),
                 Applicability::MachineApplicable,
             );
         } else {

tests/ui/literals.stderr

@@ -2,21 +2,21 @@ error: integer type suffix should not be separated by an underscore
   --> $DIR/literals.rs:12:15
    |
 LL |     let ok4 = 0xab_cd_i32;
-   |               ^^^^^^^^^^^ help: remove the underscore: `0xab_cd_i32`
+   |               ^^^^^^^^^^^ help: remove the underscore: `0xab_cdi32`
    |
    = note: `-D clippy::separated-literal-suffix` implied by `-D warnings`
 
 error: integer type suffix should not be separated by an underscore
   --> $DIR/literals.rs:13:15
    |
 LL |     let ok5 = 0xAB_CD_u32;
-   |               ^^^^^^^^^^^ help: remove the underscore: `0xAB_CD_u32`
+   |               ^^^^^^^^^^^ help: remove the underscore: `0xAB_CDu32`
 
 error: integer type suffix should not be separated by an underscore
   --> $DIR/literals.rs:14:15
    |
 LL |     let ok5 = 0xAB_CD_isize;
-   |               ^^^^^^^^^^^^^ help: remove the underscore: `0xAB_CD_isize`
+   |               ^^^^^^^^^^^^^ help: remove the underscore: `0xAB_CDisize`
 
 error: inconsistent casing in hexadecimal literal
   --> $DIR/literals.rs:15:17
@@ -30,7 +30,7 @@ error: integer type suffix should not be separated by an underscore
   --> $DIR/literals.rs:16:17
    |
 LL |     let fail2 = 0xabCD_u32;
-   |                 ^^^^^^^^^^ help: remove the underscore: `0xabCD_u32`
+   |                 ^^^^^^^^^^ help: remove the underscore: `0xabCDu32`
 
 error: inconsistent casing in hexadecimal literal
   --> $DIR/literals.rs:16:17
@@ -42,7 +42,7 @@ error: integer type suffix should not be separated by an underscore
   --> $DIR/literals.rs:17:17
    |
 LL |     let fail2 = 0xabCD_isize;
-   |                 ^^^^^^^^^^^^ help: remove the underscore: `0xabCD_isize`
+   |                 ^^^^^^^^^^^^ help: remove the underscore: `0xabCDisize`
 
 error: inconsistent casing in hexadecimal literal
   --> $DIR/literals.rs:17:17
@@ -78,7 +78,7 @@ error: integer type suffix should not be separated by an underscore
   --> $DIR/literals.rs:21:16
    |
 LL |     let ok10 = 0_i64;
-   |                ^^^^^ help: remove the underscore: `0_i64`
+   |                ^^^^^ help: remove the underscore: `0i64`
 
 error: this is a decimal constant
   --> $DIR/literals.rs:22:17
@@ -99,7 +99,7 @@ error: integer type suffix should not be separated by an underscore
   --> $DIR/literals.rs:31:16
    |
 LL |     let ok17 = 0x123_4567_8901_usize;
-   |                ^^^^^^^^^^^^^^^^^^^^^ help: remove the underscore: `0x123_4567_8901_usize`
+   |                ^^^^^^^^^^^^^^^^^^^^^ help: remove the underscore: `0x123_4567_8901usize`
 
 error: digits grouped inconsistently by underscores
   --> $DIR/literals.rs:34:18