Collect at callsite, use eprintln instead of println

Author: phansch

clippy_dev/src/stderr_length_check.rs

@@ -11,18 +11,18 @@ const LIMIT: usize = 320;
 
 pub fn check() {
     let stderr_files = stderr_files();
-    let exceeding_files = exceeding_stderr_files(stderr_files);
+    let exceeding_files = exceeding_stderr_files(stderr_files).collect::<Vec<String>>();
 
     if !exceeding_files.is_empty() {
-        println!("Error: stderr files exceeding limit of {} lines:", LIMIT);
+        eprintln!("Error: stderr files exceeding limit of {} lines:", LIMIT);
         for path in exceeding_files {
             println!("{}", path);
         }
         std::process::exit(1);
     }
 }
 
-fn exceeding_stderr_files(files: impl Iterator<Item = walkdir::DirEntry>) -> Vec<String> {
+fn exceeding_stderr_files(files: impl Iterator<Item = walkdir::DirEntry>) -> impl Iterator<Item = String> {
     files
         .filter_map(|file| {
             let path = file.path().to_str().expect("Could not convert path to str").to_string();
@@ -33,7 +33,6 @@ fn exceeding_stderr_files(files: impl Iterator<Item = walkdir::DirEntry>) -> Vec
                 None
             }
         })
-        .collect()
 }
 
 fn stderr_files() -> impl Iterator<Item = walkdir::DirEntry> {