Remove '#[expect(clippy::similar_names)]' where needed to pass dogfood tests

tgross35 · tgross35 · commit 5250afb77d5f · 2024-02-09T23:39:36.000-06:00
diff --git a/clippy_lints/src/item_name_repetitions.rs b/clippy_lints/src/item_name_repetitions.rs
@@ -385,7 +385,6 @@ impl LateLintPass<'_> for ItemNameRepetitions {
         assert!(last.is_some());
     }
 
-    #[expect(clippy::similar_names)]
     fn check_item(&mut self, cx: &LateContext<'_>, item: &Item<'_>) {
         let item_name = item.ident.name.as_str();
         let item_camel = to_camel_case(item_name);
diff --git a/clippy_lints/src/operators/double_comparison.rs b/clippy_lints/src/operators/double_comparison.rs
@@ -8,7 +8,6 @@ use rustc_span::Span;
 
 use super::DOUBLE_COMPARISONS;
 
-#[expect(clippy::similar_names)]
 pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, op: BinOpKind, lhs: &'tcx Expr<'_>, rhs: &'tcx Expr<'_>, span: Span) {
     let (lkind, llhs, lrhs, rkind, rlhs, rrhs) = match (&lhs.kind, &rhs.kind) {
         (ExprKind::Binary(lb, llhs, lrhs), ExprKind::Binary(rb, rlhs, rrhs)) => {
diff --git a/clippy_lints/src/operators/op_ref.rs b/clippy_lints/src/operators/op_ref.rs
@@ -11,7 +11,7 @@ use rustc_middle::ty::{self, Ty};
 
 use super::OP_REF;
 
-#[expect(clippy::similar_names, clippy::too_many_lines)]
+#[expect(clippy::too_many_lines)]
 pub(crate) fn check<'tcx>(
     cx: &LateContext<'tcx>,
     e: &'tcx Expr<'_>,
diff --git a/clippy_utils/src/ast_utils.rs b/clippy_utils/src/ast_utils.rs
@@ -2,7 +2,7 @@
 //!
 //! - The `eq_foobar` functions test for semantic equality but ignores `NodeId`s and `Span`s.
 
-#![allow(clippy::similar_names, clippy::wildcard_imports, clippy::enum_glob_use)]
+#![allow(clippy::wildcard_imports, clippy::enum_glob_use)]
 
 use crate::{both, over};
 use rustc_ast::ptr::P;
@@ -296,7 +296,7 @@ pub fn eq_item<K>(l: &Item<K>, r: &Item<K>, mut eq_kind: impl FnMut(&K, &K) -> b
     eq_id(l.ident, r.ident) && over(&l.attrs, &r.attrs, eq_attr) && eq_vis(&l.vis, &r.vis) && eq_kind(&l.kind, &r.kind)
 }
 
-#[expect(clippy::too_many_lines)] // Just a big match statement
+#[expect(clippy::similar_names, clippy::too_many_lines)] // Just a big match statement
 pub fn eq_item_kind(l: &ItemKind, r: &ItemKind) -> bool {
     use ItemKind::*;
     match (l, r) {
diff --git a/clippy_utils/src/hir_utils.rs b/clippy_utils/src/hir_utils.rs
@@ -132,7 +132,6 @@ impl HirEqInterExpr<'_, '_, '_> {
     }
 
     /// Checks whether two blocks are the same.
-    #[expect(clippy::similar_names)]
     fn eq_block(&mut self, left: &Block<'_>, right: &Block<'_>) -> bool {
         use TokenKind::{Semi, Whitespace};
         if left.stmts.len() != right.stmts.len() {
@@ -247,7 +246,7 @@ impl HirEqInterExpr<'_, '_, '_> {
         res
     }
 
-    #[expect(clippy::similar_names, clippy::too_many_lines)]
+    #[expect(clippy::too_many_lines)]
     pub fn eq_expr(&mut self, left: &Expr<'_>, right: &Expr<'_>) -> bool {
         if !self.check_ctxt(left.span.ctxt(), right.span.ctxt()) {
             return false;
@@ -463,7 +462,6 @@ impl HirEqInterExpr<'_, '_, '_> {
         }
     }
 
-    #[expect(clippy::similar_names)]
     fn eq_qpath(&mut self, left: &QPath<'_>, right: &QPath<'_>) -> bool {
         match (left, right) {
             (&QPath::Resolved(ref lty, lpath), &QPath::Resolved(ref rty, rpath)) => {
@@ -1158,7 +1156,6 @@ pub fn hash_expr(cx: &LateContext<'_>, e: &Expr<'_>) -> u64 {
     h.finish()
 }
 
-#[expect(clippy::similar_names)]
 fn eq_span_tokens(
     cx: &LateContext<'_>,
     left: impl SpanRange,
diff --git a/clippy_utils/src/qualify_min_const_fn.rs b/clippy_utils/src/qualify_min_const_fn.rs
@@ -389,7 +389,6 @@ fn is_const_fn(tcx: TyCtxt<'_>, def_id: DefId, msrv: &Msrv) -> bool {
         })
 }
 
-#[expect(clippy::similar_names)] // bit too pedantic
 fn is_ty_const_destruct<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>, body: &Body<'tcx>) -> bool {
     // FIXME(effects, fee1-dead) revert to const destruct once it works again
     #[expect(unused)]
diff --git a/tests/ui/approx_const.rs b/tests/ui/approx_const.rs
@@ -1,5 +1,4 @@
 #[warn(clippy::approx_constant)]
-#[allow(clippy::similar_names)]
 fn main() {
     let my_e = 2.7182;
     //~^ ERROR: approximate value of `f{32, 64}::consts::E` found
diff --git a/tests/ui/approx_const.stderr b/tests/ui/approx_const.stderr
@@ -1,5 +1,5 @@
 error: approximate value of `f{32, 64}::consts::E` found
-  --> $DIR/approx_const.rs:4:16
+  --> $DIR/approx_const.rs:3:16
    |
 LL |     let my_e = 2.7182;
    |                ^^^^^^
@@ -9,175 +9,175 @@ LL |     let my_e = 2.7182;
    = help: to override `-D warnings` add `#[allow(clippy::approx_constant)]`
 
 error: approximate value of `f{32, 64}::consts::E` found
-  --> $DIR/approx_const.rs:6:20
+  --> $DIR/approx_const.rs:5:20
    |
 LL |     let almost_e = 2.718;
    |                    ^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_1_PI` found
-  --> $DIR/approx_const.rs:10:24
+  --> $DIR/approx_const.rs:9:24
    |
 LL |     let my_1_frac_pi = 0.3183;
    |                        ^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found
-  --> $DIR/approx_const.rs:14:28
+  --> $DIR/approx_const.rs:13:28
    |
 LL |     let my_frac_1_sqrt_2 = 0.70710678;
    |                            ^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found
-  --> $DIR/approx_const.rs:16:32
+  --> $DIR/approx_const.rs:15:32
    |
 LL |     let almost_frac_1_sqrt_2 = 0.70711;
    |                                ^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_2_PI` found
-  --> $DIR/approx_const.rs:20:24
+  --> $DIR/approx_const.rs:19:24
    |
 LL |     let my_frac_2_pi = 0.63661977;
    |                        ^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_2_SQRT_PI` found
-  --> $DIR/approx_const.rs:24:27
+  --> $DIR/approx_const.rs:23:27
    |
 LL |     let my_frac_2_sq_pi = 1.128379;
    |                           ^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_PI_2` found
-  --> $DIR/approx_const.rs:28:24
+  --> $DIR/approx_const.rs:27:24
    |
 LL |     let my_frac_pi_2 = 1.57079632679;
    |                        ^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_PI_3` found
-  --> $DIR/approx_const.rs:32:24
+  --> $DIR/approx_const.rs:31:24
    |
 LL |     let my_frac_pi_3 = 1.04719755119;
    |                        ^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_PI_4` found
-  --> $DIR/approx_const.rs:36:24
+  --> $DIR/approx_const.rs:35:24
    |
 LL |     let my_frac_pi_4 = 0.785398163397;
    |                        ^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_PI_6` found
-  --> $DIR/approx_const.rs:40:24
+  --> $DIR/approx_const.rs:39:24
    |
 LL |     let my_frac_pi_6 = 0.523598775598;
    |                        ^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::FRAC_PI_8` found
-  --> $DIR/approx_const.rs:44:24
+  --> $DIR/approx_const.rs:43:24
    |
 LL |     let my_frac_pi_8 = 0.3926990816987;
    |                        ^^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::LN_10` found
-  --> $DIR/approx_const.rs:48:20
+  --> $DIR/approx_const.rs:47:20
    |
 LL |     let my_ln_10 = 2.302585092994046;
    |                    ^^^^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::LN_2` found
-  --> $DIR/approx_const.rs:52:19
+  --> $DIR/approx_const.rs:51:19
    |
 LL |     let my_ln_2 = 0.6931471805599453;
    |                   ^^^^^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::LOG10_E` found
-  --> $DIR/approx_const.rs:56:22
+  --> $DIR/approx_const.rs:55:22
    |
 LL |     let my_log10_e = 0.4342944819032518;
    |                      ^^^^^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::LOG2_E` found
-  --> $DIR/approx_const.rs:60:21
+  --> $DIR/approx_const.rs:59:21
    |
 LL |     let my_log2_e = 1.4426950408889634;
    |                     ^^^^^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::LOG2_10` found
-  --> $DIR/approx_const.rs:64:19
+  --> $DIR/approx_const.rs:63:19
    |
 LL |     let log2_10 = 3.321928094887362;
    |                   ^^^^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::LOG10_2` found
-  --> $DIR/approx_const.rs:68:19
+  --> $DIR/approx_const.rs:67:19
    |
 LL |     let log10_2 = 0.301029995663981;
    |                   ^^^^^^^^^^^^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::PI` found
-  --> $DIR/approx_const.rs:72:17
+  --> $DIR/approx_const.rs:71:17
    |
 LL |     let my_pi = 3.1415;
    |                 ^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::PI` found
-  --> $DIR/approx_const.rs:74:21
+  --> $DIR/approx_const.rs:73:21
    |
 LL |     let almost_pi = 3.14;
    |                     ^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::SQRT_2` found
-  --> $DIR/approx_const.rs:78:18
+  --> $DIR/approx_const.rs:77:18
    |
 LL |     let my_sq2 = 1.4142;
    |                  ^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::TAU` found
-  --> $DIR/approx_const.rs:82:18
+  --> $DIR/approx_const.rs:81:18
    |
 LL |     let my_tau = 6.2832;
    |                  ^^^^^^
    |
    = help: consider using the constant directly
 
 error: approximate value of `f{32, 64}::consts::TAU` found
-  --> $DIR/approx_const.rs:84:22
+  --> $DIR/approx_const.rs:83:22
    |
 LL |     let almost_tau = 6.28;
    |                      ^^^^

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,6 @@ impl LateLintPass<'_> for ItemNameRepetitions {`
`385`	`385`	`assert!(last.is_some());`
`386`	`386`	`}`
`387`	`387`
`388`		`- #[expect(clippy::similar_names)]`
`389`	`388`	`fn check_item(&mut self, cx: &LateContext<'_>, item: &Item<'_>) {`
`390`	`389`	`let item_name = item.ident.name.as_str();`
`391`	`390`	`let item_camel = to_camel_case(item_name);`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,6 @@ impl HirEqInterExpr<'_, '_, '_> {`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`/// Checks whether two blocks are the same.`
`135`		`- #[expect(clippy::similar_names)]`
`136`	`135`	`fn eq_block(&mut self, left: &Block<'_>, right: &Block<'_>) -> bool {`
`137`	`136`	`use TokenKind::{Semi, Whitespace};`
`138`	`137`	`if left.stmts.len() != right.stmts.len() {`
`@@ -247,7 +246,7 @@ impl HirEqInterExpr<'_, '_, '_> {`
`247`	`246`	`res`
`248`	`247`	`}`
`249`	`248`
`250`		`- #[expect(clippy::similar_names, clippy::too_many_lines)]`
	`249`	`+ #[expect(clippy::too_many_lines)]`
`251`	`250`	`pub fn eq_expr(&mut self, left: &Expr<'_>, right: &Expr<'_>) -> bool {`
`252`	`251`	`if !self.check_ctxt(left.span.ctxt(), right.span.ctxt()) {`
`253`	`252`	`return false;`
`@@ -463,7 +462,6 @@ impl HirEqInterExpr<'_, '_, '_> {`
`463`	`462`	`}`
`464`	`463`	`}`
`465`	`464`
`466`		`- #[expect(clippy::similar_names)]`
`467`	`465`	`fn eq_qpath(&mut self, left: &QPath<'_>, right: &QPath<'_>) -> bool {`
`468`	`466`	`match (left, right) {`
`469`	`467`	`(&QPath::Resolved(ref lty, lpath), &QPath::Resolved(ref rty, rpath)) => {`
`@@ -1158,7 +1156,6 @@ pub fn hash_expr(cx: &LateContext<'_>, e: &Expr<'_>) -> u64 {`
`1158`	`1156`	`h.finish()`
`1159`	`1157`	`}`
`1160`	`1158`
`1161`		`-#[expect(clippy::similar_names)]`
`1162`	`1159`	`fn eq_span_tokens(`
`1163`	`1160`	`cx: &LateContext<'_>,`
`1164`	`1161`	`left: impl SpanRange,`
Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,6 @@ fn is_const_fn(tcx: TyCtxt<'_>, def_id: DefId, msrv: &Msrv) -> bool {`
`389`	`389`	`})`
`390`	`390`	`}`
`391`	`391`
`392`		`-#[expect(clippy::similar_names)] // bit too pedantic`
`393`	`392`	`fn is_ty_const_destruct<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>, body: &Body<'tcx>) -> bool {`
`394`	`393`	`// FIXME(effects, fee1-dead) revert to const destruct once it works again`
`395`	`394`	`#[expect(unused)]`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`#[warn(clippy::approx_constant)]`
`2`		`-#[allow(clippy::similar_names)]`
`3`	`2`	`fn main() {`
`4`	`3`	`let my_e = 2.7182;`
`5`	`4`	//~^ ERROR: approximate value of `f{32, 64}::consts::E` found
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error: approximate value of `f{32, 64}::consts::E` found
`2`		`- --> $DIR/approx_const.rs:4:16`
	`2`	`+ --> $DIR/approx_const.rs:3:16`
`3`	`3`	`\|`
`4`	`4`	`LL \| let my_e = 2.7182;`
`5`	`5`	`\| ^^^^^^`
`@@ -9,175 +9,175 @@ LL \| let my_e = 2.7182;`
`9`	`9`	= help: to override `-D warnings` add `#[allow(clippy::approx_constant)]`
`10`	`10`
`11`	`11`	error: approximate value of `f{32, 64}::consts::E` found
`12`		`- --> $DIR/approx_const.rs:6:20`
	`12`	`+ --> $DIR/approx_const.rs:5:20`
`13`	`13`	`\|`
`14`	`14`	`LL \| let almost_e = 2.718;`
`15`	`15`	`\| ^^^^^`
`16`	`16`	`\|`
`17`	`17`	`= help: consider using the constant directly`
`18`	`18`
`19`	`19`	error: approximate value of `f{32, 64}::consts::FRAC_1_PI` found
`20`		`- --> $DIR/approx_const.rs:10:24`
	`20`	`+ --> $DIR/approx_const.rs:9:24`
`21`	`21`	`\|`
`22`	`22`	`LL \| let my_1_frac_pi = 0.3183;`
`23`	`23`	`\| ^^^^^^`
`24`	`24`	`\|`
`25`	`25`	`= help: consider using the constant directly`
`26`	`26`
`27`	`27`	error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found
`28`		`- --> $DIR/approx_const.rs:14:28`
	`28`	`+ --> $DIR/approx_const.rs:13:28`
`29`	`29`	`\|`
`30`	`30`	`LL \| let my_frac_1_sqrt_2 = 0.70710678;`
`31`	`31`	`\| ^^^^^^^^^^`
`32`	`32`	`\|`
`33`	`33`	`= help: consider using the constant directly`
`34`	`34`
`35`	`35`	error: approximate value of `f{32, 64}::consts::FRAC_1_SQRT_2` found
`36`		`- --> $DIR/approx_const.rs:16:32`
	`36`	`+ --> $DIR/approx_const.rs:15:32`
`37`	`37`	`\|`
`38`	`38`	`LL \| let almost_frac_1_sqrt_2 = 0.70711;`
`39`	`39`	`\| ^^^^^^^`
`40`	`40`	`\|`
`41`	`41`	`= help: consider using the constant directly`
`42`	`42`
`43`	`43`	error: approximate value of `f{32, 64}::consts::FRAC_2_PI` found
`44`		`- --> $DIR/approx_const.rs:20:24`
	`44`	`+ --> $DIR/approx_const.rs:19:24`
`45`	`45`	`\|`
`46`	`46`	`LL \| let my_frac_2_pi = 0.63661977;`
`47`	`47`	`\| ^^^^^^^^^^`
`48`	`48`	`\|`
`49`	`49`	`= help: consider using the constant directly`
`50`	`50`
`51`	`51`	error: approximate value of `f{32, 64}::consts::FRAC_2_SQRT_PI` found
`52`		`- --> $DIR/approx_const.rs:24:27`
	`52`	`+ --> $DIR/approx_const.rs:23:27`
`53`	`53`	`\|`
`54`	`54`	`LL \| let my_frac_2_sq_pi = 1.128379;`
`55`	`55`	`\| ^^^^^^^^`
`56`	`56`	`\|`
`57`	`57`	`= help: consider using the constant directly`
`58`	`58`
`59`	`59`	error: approximate value of `f{32, 64}::consts::FRAC_PI_2` found
`60`		`- --> $DIR/approx_const.rs:28:24`
	`60`	`+ --> $DIR/approx_const.rs:27:24`
`61`	`61`	`\|`
`62`	`62`	`LL \| let my_frac_pi_2 = 1.57079632679;`
`63`	`63`	`\| ^^^^^^^^^^^^^`
`64`	`64`	`\|`
`65`	`65`	`= help: consider using the constant directly`
`66`	`66`
`67`	`67`	error: approximate value of `f{32, 64}::consts::FRAC_PI_3` found
`68`		`- --> $DIR/approx_const.rs:32:24`
	`68`	`+ --> $DIR/approx_const.rs:31:24`
`69`	`69`	`\|`
`70`	`70`	`LL \| let my_frac_pi_3 = 1.04719755119;`
`71`	`71`	`\| ^^^^^^^^^^^^^`
`72`	`72`	`\|`
`73`	`73`	`= help: consider using the constant directly`
`74`	`74`
`75`	`75`	error: approximate value of `f{32, 64}::consts::FRAC_PI_4` found
`76`		`- --> $DIR/approx_const.rs:36:24`
	`76`	`+ --> $DIR/approx_const.rs:35:24`
`77`	`77`	`\|`
`78`	`78`	`LL \| let my_frac_pi_4 = 0.785398163397;`
`79`	`79`	`\| ^^^^^^^^^^^^^^`
`80`	`80`	`\|`
`81`	`81`	`= help: consider using the constant directly`
`82`	`82`
`83`	`83`	error: approximate value of `f{32, 64}::consts::FRAC_PI_6` found
`84`		`- --> $DIR/approx_const.rs:40:24`
	`84`	`+ --> $DIR/approx_const.rs:39:24`
`85`	`85`	`\|`
`86`	`86`	`LL \| let my_frac_pi_6 = 0.523598775598;`
`87`	`87`	`\| ^^^^^^^^^^^^^^`
`88`	`88`	`\|`
`89`	`89`	`= help: consider using the constant directly`
`90`	`90`
`91`	`91`	error: approximate value of `f{32, 64}::consts::FRAC_PI_8` found
`92`		`- --> $DIR/approx_const.rs:44:24`
	`92`	`+ --> $DIR/approx_const.rs:43:24`
`93`	`93`	`\|`
`94`	`94`	`LL \| let my_frac_pi_8 = 0.3926990816987;`
`95`	`95`	`\| ^^^^^^^^^^^^^^^`
`96`	`96`	`\|`
`97`	`97`	`= help: consider using the constant directly`
`98`	`98`
`99`	`99`	error: approximate value of `f{32, 64}::consts::LN_10` found
`100`		`- --> $DIR/approx_const.rs:48:20`
	`100`	`+ --> $DIR/approx_const.rs:47:20`
`101`	`101`	`\|`
`102`	`102`	`LL \| let my_ln_10 = 2.302585092994046;`
`103`	`103`	`\| ^^^^^^^^^^^^^^^^^`
`104`	`104`	`\|`
`105`	`105`	`= help: consider using the constant directly`
`106`	`106`
`107`	`107`	error: approximate value of `f{32, 64}::consts::LN_2` found
`108`		`- --> $DIR/approx_const.rs:52:19`
	`108`	`+ --> $DIR/approx_const.rs:51:19`
`109`	`109`	`\|`
`110`	`110`	`LL \| let my_ln_2 = 0.6931471805599453;`
`111`	`111`	`\| ^^^^^^^^^^^^^^^^^^`
`112`	`112`	`\|`
`113`	`113`	`= help: consider using the constant directly`
`114`	`114`
`115`	`115`	error: approximate value of `f{32, 64}::consts::LOG10_E` found
`116`		`- --> $DIR/approx_const.rs:56:22`
	`116`	`+ --> $DIR/approx_const.rs:55:22`
`117`	`117`	`\|`
`118`	`118`	`LL \| let my_log10_e = 0.4342944819032518;`
`119`	`119`	`\| ^^^^^^^^^^^^^^^^^^`
`120`	`120`	`\|`
`121`	`121`	`= help: consider using the constant directly`
`122`	`122`
`123`	`123`	error: approximate value of `f{32, 64}::consts::LOG2_E` found
`124`		`- --> $DIR/approx_const.rs:60:21`
	`124`	`+ --> $DIR/approx_const.rs:59:21`
`125`	`125`	`\|`
`126`	`126`	`LL \| let my_log2_e = 1.4426950408889634;`
`127`	`127`	`\| ^^^^^^^^^^^^^^^^^^`
`128`	`128`	`\|`
`129`	`129`	`= help: consider using the constant directly`
`130`	`130`
`131`	`131`	error: approximate value of `f{32, 64}::consts::LOG2_10` found
`132`		`- --> $DIR/approx_const.rs:64:19`
	`132`	`+ --> $DIR/approx_const.rs:63:19`
`133`	`133`	`\|`
`134`	`134`	`LL \| let log2_10 = 3.321928094887362;`
`135`	`135`	`\| ^^^^^^^^^^^^^^^^^`
`136`	`136`	`\|`
`137`	`137`	`= help: consider using the constant directly`
`138`	`138`
`139`	`139`	error: approximate value of `f{32, 64}::consts::LOG10_2` found
`140`		`- --> $DIR/approx_const.rs:68:19`
	`140`	`+ --> $DIR/approx_const.rs:67:19`
`141`	`141`	`\|`
`142`	`142`	`LL \| let log10_2 = 0.301029995663981;`
`143`	`143`	`\| ^^^^^^^^^^^^^^^^^`
`144`	`144`	`\|`
`145`	`145`	`= help: consider using the constant directly`
`146`	`146`
`147`	`147`	error: approximate value of `f{32, 64}::consts::PI` found
`148`		`- --> $DIR/approx_const.rs:72:17`
	`148`	`+ --> $DIR/approx_const.rs:71:17`
`149`	`149`	`\|`
`150`	`150`	`LL \| let my_pi = 3.1415;`
`151`	`151`	`\| ^^^^^^`
`152`	`152`	`\|`
`153`	`153`	`= help: consider using the constant directly`
`154`	`154`
`155`	`155`	error: approximate value of `f{32, 64}::consts::PI` found
`156`		`- --> $DIR/approx_const.rs:74:21`
	`156`	`+ --> $DIR/approx_const.rs:73:21`
`157`	`157`	`\|`
`158`	`158`	`LL \| let almost_pi = 3.14;`
`159`	`159`	`\| ^^^^`
`160`	`160`	`\|`
`161`	`161`	`= help: consider using the constant directly`
`162`	`162`
`163`	`163`	error: approximate value of `f{32, 64}::consts::SQRT_2` found
`164`		`- --> $DIR/approx_const.rs:78:18`
	`164`	`+ --> $DIR/approx_const.rs:77:18`
`165`	`165`	`\|`
`166`	`166`	`LL \| let my_sq2 = 1.4142;`
`167`	`167`	`\| ^^^^^^`
`168`	`168`	`\|`
`169`	`169`	`= help: consider using the constant directly`
`170`	`170`
`171`	`171`	error: approximate value of `f{32, 64}::consts::TAU` found
`172`		`- --> $DIR/approx_const.rs:82:18`
	`172`	`+ --> $DIR/approx_const.rs:81:18`
`173`	`173`	`\|`
`174`	`174`	`LL \| let my_tau = 6.2832;`
`175`	`175`	`\| ^^^^^^`
`176`	`176`	`\|`
`177`	`177`	`= help: consider using the constant directly`
`178`	`178`
`179`	`179`	error: approximate value of `f{32, 64}::consts::TAU` found
`180`		`- --> $DIR/approx_const.rs:84:22`
	`180`	`+ --> $DIR/approx_const.rs:83:22`
`181`	`181`	`\|`
`182`	`182`	`LL \| let almost_tau = 6.28;`
`183`	`183`	`\| ^^^^`