Support binary cast expressions for manual_div_ceil

Author: belyakov-am

clippy_lints/src/manual_div_ceil.rs

@@ -1,6 +1,7 @@
 use clippy_config::msrvs::{self, Msrv};
 use clippy_utils::diagnostics::span_lint_and_sugg;
 use clippy_utils::source::snippet_with_applicability;
+use clippy_utils::sugg::Sugg;
 use clippy_utils::SpanlessEq;
 use rustc_ast::{BinOpKind, LitKind};
 use rustc_data_structures::packed::Pu128;
@@ -128,10 +129,10 @@ fn build_suggestion(
     rhs: &Expr<'_>,
     applicability: &mut Applicability,
 ) {
-    let dividend_snippet = snippet_with_applicability(cx, lhs.span.source_callsite(), "..", applicability);
+    let dividend_sugg = Sugg::hir_with_applicability(cx, lhs, "..", applicability).maybe_par();
     let divisor_snippet = snippet_with_applicability(cx, rhs.span.source_callsite(), "..", applicability);
 
-    let sugg = format!("{dividend_snippet}.div_ceil({divisor_snippet})");
+    let sugg = format!("{dividend_sugg}.div_ceil({divisor_snippet})");
 
     span_lint_and_sugg(
         cx,

tests/ui/manual_div_ceil.fixed

@@ -4,6 +4,7 @@
 fn main() {
     let x = 7_i32;
     let y = 4_i32;
+    let z_u: u32 = 11;
 
     // Lint.
     let _ = x.div_ceil(y);
@@ -12,6 +13,9 @@ fn main() {
 
     let _ = 7_i32.div_ceil(4);
 
+    let _ = (z_u as i32).div_ceil(y);
+    let _ = (7_u32 as i32).div_ceil(y);
+
     // No lint.
     let _ = (x + (y - 2)) / y;
     let _ = (x + (y + 1)) / y;

tests/ui/manual_div_ceil.rs

@@ -4,6 +4,7 @@
 fn main() {
     let x = 7_i32;
     let y = 4_i32;
+    let z_u: u32 = 11;
 
     // Lint.
     let _ = (x + (y - 1)) / y;
@@ -12,6 +13,9 @@ fn main() {
 
     let _ = (7_i32 + (4 - 1)) / 4;
 
+    let _ = (z_u as i32 + (y - 1)) / y;
+    let _ = (7_u32 as i32 + (y - 1)) / y;
+
     // No lint.
     let _ = (x + (y - 2)) / y;
     let _ = (x + (y + 1)) / y;

tests/ui/manual_div_ceil.stderr

@@ -1,5 +1,5 @@
 error: manually reimplementing `div_ceil`
-  --> tests/ui/manual_div_ceil.rs:9:13
+  --> tests/ui/manual_div_ceil.rs:10:13
    |
 LL |     let _ = (x + (y - 1)) / y;
    |             ^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `x.div_ceil(y)`
@@ -8,22 +8,34 @@ LL |     let _ = (x + (y - 1)) / y;
    = help: to override `-D warnings` add `#[allow(clippy::manual_div_ceil)]`
 
 error: manually reimplementing `div_ceil`
-  --> tests/ui/manual_div_ceil.rs:10:13
+  --> tests/ui/manual_div_ceil.rs:11:13
    |
 LL |     let _ = ((y - 1) + x) / y;
    |             ^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `x.div_ceil(y)`
 
 error: manually reimplementing `div_ceil`
-  --> tests/ui/manual_div_ceil.rs:11:13
+  --> tests/ui/manual_div_ceil.rs:12:13
    |
 LL |     let _ = (x + y - 1) / y;
    |             ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `x.div_ceil(y)`
 
 error: manually reimplementing `div_ceil`
-  --> tests/ui/manual_div_ceil.rs:13:13
+  --> tests/ui/manual_div_ceil.rs:14:13
    |
 LL |     let _ = (7_i32 + (4 - 1)) / 4;
    |             ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `7_i32.div_ceil(4)`
 
-error: aborting due to 4 previous errors
+error: manually reimplementing `div_ceil`
+  --> tests/ui/manual_div_ceil.rs:16:13
+   |
+LL |     let _ = (z_u as i32 + (y - 1)) / y;
+   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(z_u as i32).div_ceil(y)`
+
+error: manually reimplementing `div_ceil`
+  --> tests/ui/manual_div_ceil.rs:17:13
+   |
+LL |     let _ = (7_u32 as i32 + (y - 1)) / y;
+   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(7_u32 as i32).div_ceil(y)`
+
+error: aborting due to 6 previous errors