Rename lint unseparated_literal_suffix -> literal_suffix

Author: dswij

CHANGELOG.md

@@ -2742,6 +2742,7 @@ Released 2018-09-13
 [`let_underscore_must_use`]: https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_must_use
 [`let_unit_value`]: https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
 [`linkedlist`]: https://rust-lang.github.io/rust-clippy/master/index.html#linkedlist
+[`literal_suffix`]: https://rust-lang.github.io/rust-clippy/master/index.html#literal_suffix
 [`logic_bug`]: https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
 [`lossy_float_literal`]: https://rust-lang.github.io/rust-clippy/master/index.html#lossy_float_literal
 [`macro_use_imports`]: https://rust-lang.github.io/rust-clippy/master/index.html#macro_use_imports
@@ -2997,7 +2998,6 @@ Released 2018-09-13
 [`unsafe_derive_deserialize`]: https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_derive_deserialize
 [`unsafe_removed_from_name`]: https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_removed_from_name
 [`unsafe_vector_initialization`]: https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization
-[`unseparated_literal_suffix`]: https://rust-lang.github.io/rust-clippy/master/index.html#unseparated_literal_suffix
 [`unsound_collection_transmute`]: https://rust-lang.github.io/rust-clippy/master/index.html#unsound_collection_transmute
 [`unstable_as_mut_slice`]: https://rust-lang.github.io/rust-clippy/master/index.html#unstable_as_mut_slice
 [`unstable_as_slice`]: https://rust-lang.github.io/rust-clippy/master/index.html#unstable_as_slice

clippy_lints/src/lib.rs

@@ -825,11 +825,11 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         misc_early::BUILTIN_TYPE_SHADOW,
         misc_early::DOUBLE_NEG,
         misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
+        misc_early::LITERAL_SUFFIX,
         misc_early::MIXED_CASE_HEX_LITERALS,
         misc_early::REDUNDANT_PATTERN,
         misc_early::UNNEEDED_FIELD_PATTERN,
         misc_early::UNNEEDED_WILDCARD_PATTERN,
-        misc_early::UNSEPARATED_LITERAL_SUFFIX,
         misc_early::ZERO_PREFIXED_LITERAL,
         missing_const_for_fn::MISSING_CONST_FOR_FN,
         missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
@@ -1044,8 +1044,8 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
         LintId::of(methods::GET_UNWRAP),
         LintId::of(methods::UNWRAP_USED),
         LintId::of(misc::FLOAT_CMP_CONST),
+        LintId::of(misc_early::LITERAL_SUFFIX),
         LintId::of(misc_early::UNNEEDED_FIELD_PATTERN),
-        LintId::of(misc_early::UNSEPARATED_LITERAL_SUFFIX),
         LintId::of(missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS),
         LintId::of(missing_enforced_import_rename::MISSING_ENFORCED_IMPORT_RENAMES),
         LintId::of(missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS),

clippy_lints/src/misc_early/unseparated_literal_suffix.rs renamed to clippy_lints/src/misc_early/literal_suffix.rs

@@ -3,7 +3,7 @@ use rustc_ast::ast::Lit;
 use rustc_errors::Applicability;
 use rustc_lint::EarlyContext;
 
-use super::{LiteralSuffixStyle, UNSEPARATED_LITERAL_SUFFIX};
+use super::{LiteralSuffixStyle, LITERAL_SUFFIX};
 
 pub(super) fn check(
     cx: &EarlyContext<'_>,
@@ -32,7 +32,7 @@ pub(super) fn check(
         LiteralSuffixStyle::Separated if lit_snip.as_bytes()[maybe_last_sep_idx] != b'_' => {
             span_lint_and_sugg(
                 cx,
-                UNSEPARATED_LITERAL_SUFFIX,
+                LITERAL_SUFFIX,
                 lit.span,
                 &format!("{} type suffix should be separated by an underscore", sugg_type),
                 "add an underscore",
@@ -43,7 +43,7 @@ pub(super) fn check(
         LiteralSuffixStyle::Unseparated if lit_snip.as_bytes()[maybe_last_sep_idx] == b'_' => {
             span_lint_and_sugg(
                 cx,
-                UNSEPARATED_LITERAL_SUFFIX,
+                LITERAL_SUFFIX,
                 lit.span,
                 &format!("{} type suffix should not be separated by an underscore", sugg_type),
                 "remove the underscore",

clippy_lints/src/misc_early/mod.rs

@@ -1,10 +1,10 @@
 mod builtin_type_shadow;
 mod double_neg;
+mod literal_suffix;
 mod mixed_case_hex_literals;
 mod redundant_pattern;
 mod unneeded_field_pattern;
 mod unneeded_wildcard_pattern;
-mod unseparated_literal_suffix;
 mod zero_prefixed_literal;
 
 use clippy_utils::diagnostics::span_lint;
@@ -142,7 +142,7 @@ declare_clippy_lint! {
     /// // Good
     /// let y = 123832i32;
     /// ```
-    pub UNSEPARATED_LITERAL_SUFFIX,
+    pub LITERAL_SUFFIX,
     restriction,
     "literals whose suffix is not separated by an underscore"
 }
@@ -279,7 +279,7 @@ impl_lint_pass!(MiscEarlyLints => [
     DUPLICATE_UNDERSCORE_ARGUMENT,
     DOUBLE_NEG,
     MIXED_CASE_HEX_LITERALS,
-    UNSEPARATED_LITERAL_SUFFIX,
+    LITERAL_SUFFIX,
     ZERO_PREFIXED_LITERAL,
     BUILTIN_TYPE_SHADOW,
     REDUNDANT_PATTERN,
@@ -369,7 +369,7 @@ impl MiscEarlyLints {
                 LitIntType::Unsigned(ty) => ty.name_str(),
                 LitIntType::Unsuffixed => "",
             };
-            unseparated_literal_suffix::check(cx, lit, &lit_snip, suffix, "integer", self.literal_suffix_style);
+            literal_suffix::check(cx, lit, &lit_snip, suffix, "integer", self.literal_suffix_style);
             if lit_snip.starts_with("0x") {
                 mixed_case_hex_literals::check(cx, lit, suffix, &lit_snip);
             } else if lit_snip.starts_with("0b") || lit_snip.starts_with("0o") {
@@ -379,7 +379,7 @@ impl MiscEarlyLints {
             }
         } else if let LitKind::Float(_, LitFloatType::Suffixed(float_ty)) = lit.kind {
             let suffix = float_ty.name_str();
-            unseparated_literal_suffix::check(cx, lit, &lit_snip, suffix, "float", self.literal_suffix_style);
+            literal_suffix::check(cx, lit, &lit_snip, suffix, "float", self.literal_suffix_style);
         }
     }
 }

tests/ui-toml/separated_literal_suffix/literal_suffix.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::unseparated_literal_suffix)]
+#![warn(clippy::literal_suffix)]
 
 fn main() {
     let _ = 123i32; // warns

tests/ui-toml/separated_literal_suffix/literal_suffix.stderr

@@ -4,7 +4,7 @@ error: integer type suffix should be separated by an underscore
 LL |     let _ = 123i32; // warns
    |             ^^^^^^ help: add an underscore: `123_i32`
    |
-   = note: `-D clippy::unseparated-literal-suffix` implied by `-D warnings`
+   = note: `-D clippy::literal-suffix` implied by `-D warnings`
 
 error: aborting due to previous error
 

tests/ui-toml/unseparated_literal_suffix/literal_suffix.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::unseparated_literal_suffix)]
+#![warn(clippy::literal_suffix)]
 
 fn main() {
     let _ = 123i32;

tests/ui-toml/unseparated_literal_suffix/literal_suffix.stderr

@@ -4,7 +4,7 @@ error: integer type suffix should not be separated by an underscore
 LL |     let _ = 123_i32; // warns
    |             ^^^^^^^ help: remove the underscore: `123_`
    |
-   = note: `-D clippy::unseparated-literal-suffix` implied by `-D warnings`
+   = note: `-D clippy::literal-suffix` implied by `-D warnings`
 
 error: aborting due to previous error
 

tests/ui/literals.rs

@@ -2,7 +2,7 @@
 
 #![warn(clippy::mixed_case_hex_literals)]
 #![warn(clippy::zero_prefixed_literal)]
-#![allow(clippy::unseparated_literal_suffix)]
+#![allow(clippy::literal_suffix)]
 #![allow(dead_code)]
 
 fn main() {