Mutate vector instead of filtering

Author: rspencer01

clippy_lints/src/methods/map_with_unused_argument_over_ranges.rs

@@ -102,24 +102,16 @@ pub(super) fn check(
 
         // We need to provide nonempty parts to diag.multipart_suggestion so we
         // collate all our parts here and then remove those that are empty.
-        let parts = [
+        let mut parts = vec![
             (
                 receiver.span.to(method_call_span),
                 format!("std::iter::{method_to_use_name}"),
             ),
             new_span,
-            (
-                ex.span.shrink_to_hi(),
-                if use_take {
-                    format!(".take({count})")
-                } else {
-                    String::new()
-                },
-            ),
-        ]
-        .into_iter()
-        .filter(|part| !(part.0.is_empty() && part.1.is_empty()))
-        .collect();
+        ];
+        if use_take {
+            parts.push((ex.span.shrink_to_hi(), format!(".take({count})")));
+        }
 
         span_lint_and_then(
             cx,