Warn about false positive in test.

Allen Hsu · Allen Hsu · commit 2e4bdd88429f · 2022-07-09T19:50:41.000+10:00
diff --git a/tests/ui/repeated_where_clauses_or_trait_bounds.fixed b/tests/ui/repeated_where_clauses_or_trait_bounds.fixed
@@ -94,6 +94,7 @@ fn no_error_separate_arg_bounds(program: impl AsRef<()>, dir: impl AsRef<()>, ar
 
 trait GenericTrait<T> {}
 
+// This should not warn but currently does see #8757
 fn good_generic<T: GenericTrait<u64> + GenericTrait<u32>>(arg0: T) {
     unimplemented!();
 }
diff --git a/tests/ui/repeated_where_clauses_or_trait_bounds.rs b/tests/ui/repeated_where_clauses_or_trait_bounds.rs
@@ -94,6 +94,7 @@ fn no_error_separate_arg_bounds(program: impl AsRef<()>, dir: impl AsRef<()>, ar
 
 trait GenericTrait<T> {}
 
+// This should not warn but currently does see #8757
 fn good_generic<T: GenericTrait<u64> + GenericTrait<u32>>(arg0: T) {
     unimplemented!();
 }
diff --git a/tests/ui/repeated_where_clauses_or_trait_bounds.stderr b/tests/ui/repeated_where_clauses_or_trait_bounds.stderr
@@ -64,37 +64,37 @@ LL |         T: Clone + Clone + Clone + Copy,
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Clone + Copy`
 
 error: this trait bound is already specified in the where clause
-  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:97:20
+  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:98:20
    |
 LL | fn good_generic<T: GenericTrait<u64> + GenericTrait<u32>>(arg0: T) {
    |                    ^^^^^^^^^^^^^^^^^
    |
    = help: consider removing this trait bound
 
 error: this trait bound is already specified in the where clause
-  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:101:19
+  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:102:19
    |
 LL | fn bad_generic<T: GenericTrait<u64> + GenericTrait<u32> + GenericTrait<u64>>(arg0: T) {
    |                   ^^^^^^^^^^^^^^^^^
    |
    = help: consider removing this trait bound
 
 error: these bounds contain repeated elements
-  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:101:19
+  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:102:19
    |
 LL | fn bad_generic<T: GenericTrait<u64> + GenericTrait<u32> + GenericTrait<u64>>(arg0: T) {
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GenericTrait<u32> + GenericTrait<u64>`
 
 error: this trait bound is already specified in the where clause
-  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:109:22
+  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:110:22
    |
 LL | fn qualified_path<T: std::clone::Clone + Clone + foo::Clone>(arg0: T) {
    |                      ^^^^^^^^^^^^^^^^^
    |
    = help: consider removing this trait bound
 
 error: these bounds contain repeated elements
-  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:109:22
+  --> $DIR/repeated_where_clauses_or_trait_bounds.rs:110:22
    |
 LL | fn qualified_path<T: std::clone::Clone + Clone + foo::Clone>(arg0: T) {
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Clone + foo::Clone`

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ fn no_error_separate_arg_bounds(program: impl AsRef<()>, dir: impl AsRef<()>, ar`
`94`	`94`
`95`	`95`	`trait GenericTrait<T> {}`
`96`	`96`
	`97`	`+// This should not warn but currently does see #8757`
`97`	`98`	`fn good_generic<T: GenericTrait<u64> + GenericTrait<u32>>(arg0: T) {`
`98`	`99`	`unimplemented!();`
`99`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,37 +64,37 @@ LL \| T: Clone + Clone + Clone + Copy,`
`64`	`64`	\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Clone + Copy`
`65`	`65`
`66`	`66`	`error: this trait bound is already specified in the where clause`
`67`		`- --> $DIR/repeated_where_clauses_or_trait_bounds.rs:97:20`
	`67`	`+ --> $DIR/repeated_where_clauses_or_trait_bounds.rs:98:20`
`68`	`68`	`\|`
`69`	`69`	`LL \| fn good_generic<T: GenericTrait<u64> + GenericTrait<u32>>(arg0: T) {`
`70`	`70`	`\| ^^^^^^^^^^^^^^^^^`
`71`	`71`	`\|`
`72`	`72`	`= help: consider removing this trait bound`
`73`	`73`
`74`	`74`	`error: this trait bound is already specified in the where clause`
`75`		`- --> $DIR/repeated_where_clauses_or_trait_bounds.rs:101:19`
	`75`	`+ --> $DIR/repeated_where_clauses_or_trait_bounds.rs:102:19`
`76`	`76`	`\|`
`77`	`77`	`LL \| fn bad_generic<T: GenericTrait<u64> + GenericTrait<u32> + GenericTrait<u64>>(arg0: T) {`
`78`	`78`	`\| ^^^^^^^^^^^^^^^^^`
`79`	`79`	`\|`
`80`	`80`	`= help: consider removing this trait bound`
`81`	`81`
`82`	`82`	`error: these bounds contain repeated elements`
`83`		`- --> $DIR/repeated_where_clauses_or_trait_bounds.rs:101:19`
	`83`	`+ --> $DIR/repeated_where_clauses_or_trait_bounds.rs:102:19`
`84`	`84`	`\|`
`85`	`85`	`LL \| fn bad_generic<T: GenericTrait<u64> + GenericTrait<u32> + GenericTrait<u64>>(arg0: T) {`
`86`	`86`	\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `GenericTrait<u32> + GenericTrait<u64>`
`87`	`87`
`88`	`88`	`error: this trait bound is already specified in the where clause`
`89`		`- --> $DIR/repeated_where_clauses_or_trait_bounds.rs:109:22`
	`89`	`+ --> $DIR/repeated_where_clauses_or_trait_bounds.rs:110:22`
`90`	`90`	`\|`
`91`	`91`	`LL \| fn qualified_path<T: std::clone::Clone + Clone + foo::Clone>(arg0: T) {`
`92`	`92`	`\| ^^^^^^^^^^^^^^^^^`
`93`	`93`	`\|`
`94`	`94`	`= help: consider removing this trait bound`
`95`	`95`
`96`	`96`	`error: these bounds contain repeated elements`
`97`		`- --> $DIR/repeated_where_clauses_or_trait_bounds.rs:109:22`
	`97`	`+ --> $DIR/repeated_where_clauses_or_trait_bounds.rs:110:22`
`98`	`98`	`\|`
`99`	`99`	`LL \| fn qualified_path<T: std::clone::Clone + Clone + foo::Clone>(arg0: T) {`
`100`	`100`	\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Clone + foo::Clone`