Auto merge of #4333 - phansch:rustfix_decimal_literal_representation, r=flip1995

bors · bors · commit 20021bb4c798 · 2019-08-05T08:00:39.000Z
Add run-rustfix for decimal_literal_representation lint changelog: none cc #3630
diff --git a/tests/ui/decimal_literal_representation.fixed b/tests/ui/decimal_literal_representation.fixed
@@ -0,0 +1,25 @@
+// run-rustfix
+
+#[warn(clippy::decimal_literal_representation)]
+#[allow(unused_variables)]
+#[rustfmt::skip]
+fn main() {
+    let good = (       // Hex:
+        127,           // 0x7F
+        256,           // 0x100
+        511,           // 0x1FF
+        2048,          // 0x800
+        4090,          // 0xFFA
+        16_371,        // 0x3FF3
+        61_683,        // 0xF0F3
+        2_131_750_925, // 0x7F0F_F00D
+    );
+    let bad = (        // Hex:
+        0x8005,        // 0x8005
+        0xFF00,        // 0xFF00
+        0x7F0F_F00F, // 0x7F0F_F00F
+        0x7FFF_FFFF, // 0x7FFF_FFFF
+        #[allow(overflowing_literals)]
+        0xF0F0_F0F0, // 0xF0F0_F0F0
+    );
+}
diff --git a/tests/ui/decimal_literal_representation.rs b/tests/ui/decimal_literal_representation.rs
@@ -1,3 +1,5 @@
+// run-rustfix
+
 #[warn(clippy::decimal_literal_representation)]
 #[allow(unused_variables)]
 #[rustfmt::skip]
@@ -17,6 +19,7 @@ fn main() {
         65_280,        // 0xFF00
         2_131_750_927, // 0x7F0F_F00F
         2_147_483_647, // 0x7FFF_FFFF
+        #[allow(overflowing_literals)]
         4_042_322_160, // 0xF0F0_F0F0
     );
 }
diff --git a/tests/ui/decimal_literal_representation.stderr b/tests/ui/decimal_literal_representation.stderr
@@ -1,31 +1,31 @@
 error: integer literal has a better hexadecimal representation
-  --> $DIR/decimal_literal_representation.rs:16:9
+  --> $DIR/decimal_literal_representation.rs:18:9
    |
 LL |         32_773,        // 0x8005
    |         ^^^^^^ help: consider: `0x8005`
    |
    = note: `-D clippy::decimal-literal-representation` implied by `-D warnings`
 
 error: integer literal has a better hexadecimal representation
-  --> $DIR/decimal_literal_representation.rs:17:9
+  --> $DIR/decimal_literal_representation.rs:19:9
    |
 LL |         65_280,        // 0xFF00
    |         ^^^^^^ help: consider: `0xFF00`
 
 error: integer literal has a better hexadecimal representation
-  --> $DIR/decimal_literal_representation.rs:18:9
+  --> $DIR/decimal_literal_representation.rs:20:9
    |
 LL |         2_131_750_927, // 0x7F0F_F00F
    |         ^^^^^^^^^^^^^ help: consider: `0x7F0F_F00F`
 
 error: integer literal has a better hexadecimal representation
-  --> $DIR/decimal_literal_representation.rs:19:9
+  --> $DIR/decimal_literal_representation.rs:21:9
    |
 LL |         2_147_483_647, // 0x7FFF_FFFF
    |         ^^^^^^^^^^^^^ help: consider: `0x7FFF_FFFF`
 
 error: integer literal has a better hexadecimal representation
-  --> $DIR/decimal_literal_representation.rs:20:9
+  --> $DIR/decimal_literal_representation.rs:23:9
    |
 LL |         4_042_322_160, // 0xF0F0_F0F0
    |         ^^^^^^^^^^^^^ help: consider: `0xF0F0_F0F0`

Original file line number	Diff line number	Diff line change
`@@ -1,31 +1,31 @@`
`1`	`1`	`error: integer literal has a better hexadecimal representation`
`2`		`- --> $DIR/decimal_literal_representation.rs:16:9`
	`2`	`+ --> $DIR/decimal_literal_representation.rs:18:9`
`3`	`3`	`\|`
`4`	`4`	`LL \| 32_773, // 0x8005`
`5`	`5`	\| ^^^^^^ help: consider: `0x8005`
`6`	`6`	`\|`
`7`	`7`	= note: `-D clippy::decimal-literal-representation` implied by `-D warnings`
`8`	`8`
`9`	`9`	`error: integer literal has a better hexadecimal representation`
`10`		`- --> $DIR/decimal_literal_representation.rs:17:9`
	`10`	`+ --> $DIR/decimal_literal_representation.rs:19:9`
`11`	`11`	`\|`
`12`	`12`	`LL \| 65_280, // 0xFF00`
`13`	`13`	\| ^^^^^^ help: consider: `0xFF00`
`14`	`14`
`15`	`15`	`error: integer literal has a better hexadecimal representation`
`16`		`- --> $DIR/decimal_literal_representation.rs:18:9`
	`16`	`+ --> $DIR/decimal_literal_representation.rs:20:9`
`17`	`17`	`\|`
`18`	`18`	`LL \| 2_131_750_927, // 0x7F0F_F00F`
`19`	`19`	\| ^^^^^^^^^^^^^ help: consider: `0x7F0F_F00F`
`20`	`20`
`21`	`21`	`error: integer literal has a better hexadecimal representation`
`22`		`- --> $DIR/decimal_literal_representation.rs:19:9`
	`22`	`+ --> $DIR/decimal_literal_representation.rs:21:9`
`23`	`23`	`\|`
`24`	`24`	`LL \| 2_147_483_647, // 0x7FFF_FFFF`
`25`	`25`	\| ^^^^^^^^^^^^^ help: consider: `0x7FFF_FFFF`
`26`	`26`
`27`	`27`	`error: integer literal has a better hexadecimal representation`
`28`		`- --> $DIR/decimal_literal_representation.rs:20:9`
	`28`	`+ --> $DIR/decimal_literal_representation.rs:23:9`
`29`	`29`	`\|`
`30`	`30`	`LL \| 4_042_322_160, // 0xF0F0_F0F0`
`31`	`31`	\| ^^^^^^^^^^^^^ help: consider: `0xF0F0_F0F0`